Re: Review Request 39366: Adding job update diff details into "aurora job diff" command.

2015-10-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39366/ --- (Updated Oct. 21, 2015, 4:47 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 39366: Adding job update diff details into "aurora job diff" command.

2015-10-21 Thread Joshua Cohen
> On Oct. 20, 2015, 4:49 p.m., Joshua Cohen wrote: > > Not a blocker, but do you think the arrows in the output are necessary? > > They feel like extra noise to me. Maybe replace them with tabs instead? > > Maxim Khutornenko wrote: > Certainly not married to the arrows. Would you find this

Re: Review Request 39525: Ignore all SessionKeys.

2015-10-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39525/#review103477 --- Master (5609fc2) is red with this patch.

Re: Review Request 39525: Ignore all SessionKeys.

2015-10-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39525/ --- (Updated Oct. 21, 2015, 3:29 p.m.) Review request for Aurora, Maxim

Re: Review Request 39532: Always set SessionKey to empty in the client.

2015-10-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/#review103498 --- Ship it! Master (4eeec7a) is green with this patch.

Review Request 39532: Always set SessionKey to empty in the client.

2015-10-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Repository:

Re: Review Request 39532: Always set SessionKey to empty in the client.

2015-10-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/ --- (Updated Oct. 21, 2015, 5:30 p.m.) Review request for Aurora, Maxim