Re: Review Request 39532: Always set SessionKey to empty in the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/#review103618 --- @reviewbot retry - Kevin Sweeney On Oct. 22, 2015, 10:36 a.m.,

Re: Review Request 39532: Always set SessionKey to empty in the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/ --- (Updated Oct. 22, 2015, 10:36 a.m.) Review request for Aurora, Maxim

Re: Review Request 39532: Always set SessionKey to empty in the client.

> On Oct. 22, 2015, 10:42 a.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 56-62 > > > > > > Why removing these fields now? This does not feel like a safe > >

Re: Review Request 39532: Always set SessionKey to empty in the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/#review103625 --- Ship it! Master (4eeec7a) is green with this patch.

Re: Review Request 39532: Always set SessionKey to empty in the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/#review103616 --- Master (4eeec7a) is red with this patch.

Re: Review Request 39563: Ignore serverInfo on the client side.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39563/#review103662 --- Elaborating - as far as I can see it the only sensible

Re: Review Request 39563: Ignore serverInfo on the client side.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39563/#review103673 --- Ship it! Master (4eeec7a) is green with this patch.

Re: Review Request 39563: Ignore serverInfo on the client side.

> On Oct. 22, 2015, 11:02 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py, lines 313-315 > > > > > > This change suggests we are effectively dropping the support for

Re: Review Request 39563: Ignore serverInfo on the client side.

> On Oct. 22, 2015, 2:41 p.m., Kevin Sweeney wrote: > > Elaborating - as far as I can see it the only sensible implementation of > > this feature would be for the client to set the version in the *request* > > and for the scheduler to check it and decide whether it supported the > > requested

Re: Review Request 39563: Ignore serverInfo on the client side.

> On Oct. 22, 2015, 6:02 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py, lines 313-315 > > > > > > This change suggests we are effectively dropping the support for

Re: Review Request 39563: Ignore serverInfo on the client side.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39563/#review103675 --- Ship it! I'm fine with this patch as-is. No great reason to keep

Re: Review Request 39563: Ignore serverInfo on the client side.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39563/#review103682 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 22, 2015, 9:35

Re: Review Request 39563: Ignore serverInfo on the client side.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39563/ --- (Updated Oct. 22, 2015, 4:27 p.m.) Review request for Aurora, Maxim

Re: Review Request 39563: Ignore serverInfo on the client side.

> On Oct. 22, 2015, 6:02 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py, lines 313-315 > > > > > > This change suggests we are effectively dropping the support for

Re: Review Request 39572: Remove callable check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39572/#review103688 --- Ship it! Ship It! - Zameer Manji On Oct. 22, 2015, 4:42 p.m.,

Re: Review Request 39563: Ignore serverInfo on the client side.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39563/#review103677 --- Ship it! After talking with Kevin offline, I think this is the

Re: Review Request 39563: Ignore serverInfo on the client side.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39563/ --- (Updated Oct. 22, 2015, 4:26 p.m.) Review request for Aurora, Maxim

Re: Review Request 39563: Ignore serverInfo on the client side.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39563/ --- (Updated Oct. 22, 2015, 4:58 p.m.) Review request for Aurora, Maxim