Re: Review Request 40323: Improve the isolation in the thrift build.

> On Nov. 15, 2015, 10:57 p.m., Bill Farner wrote: > > Heh, took a few rounds to understand what was going on > > here...case-insensitive file system strikes again! > > ``` > > ... > > Making install in lib > > /Library/Developer/CommandLineTools/usr/bin/make install-am > > if test no = no;

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40334/#review106678 --- Ship it! Ship It! - Joshua Cohen On Nov. 15, 2015, 11:36 p.m.,

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/#review106684 --- Master (7b494f4) is red with this patch.

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106674 --- pants.ini (line 19)

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/ --- (Updated Nov. 16, 2015, 9:48 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 40323: Improve the isolation in the thrift build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 16, 2015, 8:13 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 40323: Improve the isolation in the thrift build.

> On Nov. 15, 2015, 10:57 p.m., Bill Farner wrote: > > Heh, took a few rounds to understand what was going on > > here...case-insensitive file system strikes again! > > ``` > > ... > > Making install in lib > > /Library/Developer/CommandLineTools/usr/bin/make install-am > > if test no = no;

Re: Review Request 40323: Improve the isolation in the thrift build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106668 --- Master (7b494f4) is red with this patch.

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 16, 2015, 10:30 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106689 --- Ship it! Master (7b494f4) is green with this patch.

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/ --- (Updated Nov. 16, 2015, 10:42 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106694 --- Ship it! Ship It! - Joshua Cohen On Nov. 16, 2015, 5:30 p.m.,

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

> On Nov. 16, 2015, 9:27 a.m., Joshua Cohen wrote: > > src/test/python/apache/aurora/admin/test_admin.py, lines 158-160 > > > > > > Why kill this? It seems like the intention was to ensure that set quota > > is

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/#review106693 --- Ship it! Ship It! - Joshua Cohen On Nov. 16, 2015, 5:42 p.m.,

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40334/#review106712 --- Ship it! Ship It! - Zameer Manji On Nov. 15, 2015, 3:36 p.m.,

Re: Review Request 40323: Improve the isolation in the thrift build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 16, 2015, 1:05 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 40323: Improve the isolation in the thrift build.

> On Nov. 16, 2015, 3:18 p.m., Zameer Manji wrote: > > build-support/thrift/Makefile, line 28 > > > > > > The ticket says this patch was committed in 0.9.2. Would it be more > > productive to upgrade to 0.9.2+

Re: Review Request 40323: Improve the isolation in the thrift build.

> On Nov. 16, 2015, 3:18 p.m., Zameer Manji wrote: > > build-support/thrift/Makefile, line 28 > > > > > > The ticket says this patch was committed in 0.9.2. Would it be more > > productive to upgrade to 0.9.2+

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 16, 2015, 1:09 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40220: Modernize the pex venv script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/ --- (Updated Nov. 16, 2015, 1:12 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 40320: Organize executor-related code into a package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40320/#review106709 --- Ship it! Ship It! - Zameer Manji On Nov. 14, 2015, 9 a.m.,

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

> On Nov. 16, 2015, 12:43 p.m., Zameer Manji wrote: > > pants.ini, line 49 > > > > > > Out of curiosity, could we replace isort with this functionality? I > > like the idea of collapsing all of that functionality

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 16, 2015, 1:11 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40323: Improve the isolation in the thrift build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 16, 2015, 1:11 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 40201: Cleanup thermos_executor test pexes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40201/ --- (Updated Nov. 16, 2015, 1:12 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40323: Improve the isolation in the thrift build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106726 --- Ship it! Master (86761e8) is green with this patch.

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106710 --- Ship it! LGTM. pants.ini (line 49)