Review Request 46133: Simplify `Credentials`; kill `ZooKeeperClient` dep.

2016-04-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46133/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1468

Re: Review Request 46111: Introduce a Curator-based `SingletonService`.

2016-04-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46111/#review128574 --- Ship it! Ship It! - Zameer Manji On April 12, 2016, 2:21

Re: Review Request 46111: Introduce a Curator-based `SingletonService`.

2016-04-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46111/#review128563 --- Ship it! Master (3cb599e) is green with this patch.

Re: Review Request 46111: Introduce a Curator-based `SingletonService`.

2016-04-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46111/#review128552 --- @ReviewBot retry - John Sirois On April 12, 2016, 3:21 p.m.,

Re: Review Request 46111: Introduce a Curator-based `SingletonService`.

2016-04-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46111/#review128545 --- Master (3cb599e) is red with this patch.

Re: Review Request 46111: Introduce a Curator-based `SingletonService`.

2016-04-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46111/#review128537 --- Helpful reference links: The leader latch cache recipe used in

Review Request 46111: Introduce a Curator-based `SingletonService`.

2016-04-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46111/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1468

Re: Review Request 46064: Removing ResourceVector enum in favor of ResourceType

2016-04-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46064/#review128491 --- Ship it! Master (a4853a4) is green with this patch.

Re: Review Request 46064: Removing ResourceVector enum in favor of ResourceType

2016-04-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46064/ --- (Updated April 12, 2016, 6:09 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 46064: Removing ResourceVector enum in favor of ResourceType

2016-04-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46064/#review128479 --- Ship it! Ship It! - Zameer Manji On April 11, 2016, 5:03

Re: Review Request 46103: Revert "Revert "Add support for storing and fetching images as properties of task configs.""

2016-04-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46103/ --- (Updated April 12, 2016, 5:37 p.m.) Review request for Aurora and Maxim

Re: Review Request 46064: Removing ResourceVector enum in favor of ResourceType

2016-04-12 Thread Bill Farner
> On April 11, 2016, 6:39 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java, line > > 31 > > > > > > It's probably time for some constants to justify these constants

Re: Review Request 46103: Revert "Revert "Add support for storing and fetching images as properties of task configs.""

2016-04-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46103/#review128458 --- Ship it! docs/development/db-migration.md (lines 30 - 33)

Re: Review Request 46064: Removing ResourceVector enum in favor of ResourceType

2016-04-12 Thread Maxim Khutornenko
> On April 12, 2016, 1:39 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java, line > > 31 > > > > > > It's probably time for some constants to justify these constants

Re: Review Request 46098: AURORA-1584: Aurora 0.13.0 release candidate missing CHANGELOG

2016-04-12 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46098/#review128433 --- Ship it! Ship It! - Stephan Erb On April 12, 2016, 5:03

Re: Review Request 46098: AURORA-1584: Aurora 0.13.0 release candidate missing CHANGELOG

2016-04-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46098/#review128421 --- Ship it! Ship It! - John Sirois On April 12, 2016, 9:03

Review Request 46098: AURORA-1584: Aurora 0.13.0 release candidate missing CHANGELOG

2016-04-12 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46098/ --- Review request for Aurora, John Sirois and Bill Farner. Bugs: AURORA-1584