Re: Review Request 46289: Make MyBatis connection pool size configurable.

2016-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46289/#review129237 --- Master (81f52e4) is green with this patch.

Re: Review Request 46289: Make MyBatis connection pool size configurable.

2016-04-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46289/ --- (Updated April 15, 2016, 7:10 p.m.) Review request for Aurora and Maxim

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

2016-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46290/#review129222 --- Ship it! Master (81f52e4) is green with this patch.

Re: Review Request 46286: Plumb Curator discovery as an option.

2016-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46286/#review129221 --- Ship it! Master (81f52e4) is green with this patch.

Re: Review Request 46289: Make MyBatis connection pool size configurable.

2016-04-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46289/#review129220 --- Ship it!

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

2016-04-15 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46290/ --- (Updated April 15, 2016, 11:59 p.m.) Review request for Aurora, Bill Farner

Re: Review Request 46286: Plumb Curator discovery as an option.

2016-04-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46286/#review129219 --- NB: Diff 2 does switch to Curator for both SchedulerIT and e2e

Re: Review Request 46289: Make MyBatis connection pool size configurable.

2016-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46289/#review129217 --- Master (81f52e4) is red with this patch.

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

2016-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46290/#review129218 --- This patch does not apply cleanly against master (81f52e4), do

Re: Review Request 46286: Plumb Curator discovery as an option.

2016-04-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46286/ --- (Updated April 15, 2016, 5:54 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 46291: Moving db migration into LogStorage

2016-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46291/#review129216 --- Ship it! Master (81f52e4) is green with this patch.

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

2016-04-15 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46290/ --- (Updated April 15, 2016, 11:46 p.m.) Review request for Aurora, Bill Farner

Review Request 46291: Moving db migration into LogStorage

2016-04-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46291/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora

Re: Review Request 46289: Make MyBatis connection pool size configurable.

2016-04-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46289/ --- (Updated April 15, 2016, 4:37 p.m.) Review request for Aurora and Maxim

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

2016-04-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46290/#review129214 ---

Re: Review Request 46289: Make MyBatis connection pool size configurable.

2016-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46289/#review129213 --- Master (81f52e4) is red with this patch.

Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

2016-04-15 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46290/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1666

Review Request 46289: Make MyBatis connection pool size configurable.

2016-04-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46289/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 46286: Plumb Curator discovery as an option.

2016-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46286/#review129211 --- Ship it! Master (81f52e4) is green with this patch.

Re: Review Request 46286: Plumb Curator discovery as an option.

2016-04-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46286/ --- (Updated April 15, 2016, 5:13 p.m.) Review request for Aurora, Bill Farner and

Review Request 46286: Plumb Curator discovery as an option.

2016-04-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46286/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1468

Re: Review Request 46167: Replace org.apache.aurora.common.base.Closure with java.util.function.Consumer

2016-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46167/#review129189 --- Master (02ffef5) is red with this patch.

Re: Review Request 46171: Centralize ZooKeeper configuration in discovery.

2016-04-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46171/#review129162 --- Ship it! Ship It! - Zameer Manji On April 13, 2016, 3:18

Re: Review Request 46171: Centralize ZooKeeper configuration in discovery.

2016-04-15 Thread Zameer Manji
> On April 14, 2016, 6:54 p.m., John Sirois wrote: > > @zmanji - friendly ping - I have the last RB adding a `-zk_use_curator` > > flag ready to post, but this needs to hit master 1st. Sorry for the delay, this slipped through the cracks. - Zameer

Re: Review Request 46241: Upgrade to Mesos 0.27.2

2016-04-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46241/#review129144 --- Ship it! Ship It! - Zameer Manji On April 14, 2016, 6:01

Re: Review Request 46241: Upgrade to Mesos 0.27.2

2016-04-15 Thread John Sirois
> On April 14, 2016, 7:08 p.m., John Sirois wrote: > > Looks like we do ~nothing with executorLost so LGTM. > > I can only imagine folks pagers going off more if they happened to alert on > > `scheduler_lost_executors`, which should now be higher if the upgrade notes > > are to be believed. >

Re: Review Request 46241: Upgrade to Mesos 0.27.2

2016-04-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46241/#review129142 --- Ship it! Ship It! - Maxim Khutornenko On April 15, 2016,

Re: Review Request 46241: Upgrade to Mesos 0.27.2

2016-04-15 Thread Joshua Cohen
> On April 15, 2016, 1:08 a.m., John Sirois wrote: > > Looks like we do ~nothing with executorLost so LGTM. > > I can only imagine folks pagers going off more if they happened to alert on > > `scheduler_lost_executors`, which should now be higher if the upgrade notes > > are to be believed.

Re: Review Request 40765: centos-6 builder

2016-04-15 Thread se choi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40765/ --- (Updated April 15, 2016, 7:38 p.m.) Review request for Aurora. Changes

Re: Review Request 40765: centos-6 builder

2016-04-15 Thread se choi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40765/ --- (Updated April 15, 2016, 7:36 p.m.) Review request for Aurora. Bugs: