Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148643 --- src/main/python/apache/aurora/client/api/__init__.py (line 266) <

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

> On Sept. 13, 2016, 1:14 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/BatchWorker.java, line 188 > > > > > > Our current metrics use 'nanos' to indicate nanoseconds instead of > > 'ns'. M

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51759/#review148633 --- I noticed that `CompletableFuture` might be suitable here. I will

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148630 --- Ship it! Master (f0ff1c4) is green with this patch. ./build-s

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148628 --- @ReviewBot retry - Zameer Manji On Sept. 12, 2016, 3:26 p.m., Z

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51759/#review148625 --- Ship it! Master (c4903d8) is green with this patch. ./build-s

Re: Review Request 51826: Implement `toString` on lazy modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51826/#review148624 --- Ship it! Master (c4903d8) is green with this patch. ./build-s

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

> On Sept. 11, 2016, 11:18 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java, > > lines 115-128 > > > > > > The `scheduleTask` method is doing some staggering amoun

Re: Review Request 51826: Implement `toString` on lazy modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51826/ --- (Updated Sept. 12, 2016, 4:07 p.m.) Review request for Aurora and Joshua Cohen.

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51759/ --- (Updated Sept. 12, 2016, 10:51 p.m.) Review request for Aurora, Joshua Cohen, S

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

> On Sept. 12, 2016, 6:26 p.m., Joshua Cohen wrote: > > Along the lines of the question Stephan raised, what happens in the event > > of a failover mid-batch, especially w.r.t. repeatable work? Same as today: the transaction either happens or does not. In case of a cron job (the only user of `

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148616 --- Master (c4903d8) is red with this patch. ./build-support/jenkins

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/ --- (Updated Sept. 12, 2016, 3:26 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

> On Sept. 11, 2016, 11:02 p.m., Stephan Erb wrote: > > Thanks for the excellent write up and the time you took to split the review > > into sizable chunks. A full review will take some time. I will start with a > > couple of highlevel questions. > > > > a) Do you have some results of the jmh

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/ --- (Updated Sept. 13, 2016, 12:08 a.m.) Review request for Aurora and Maxim Khutor

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

> On Sept. 12, 2016, 9:31 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java, line > > 75 > > > > > > Would be great to have a e2e test when this functionality is

Re: Review Request 51826: Implement `toString` on lazy modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51826/#review148608 --- Master (b429612) is green with this patch. ./build-support/jenki

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148604 --- Master (b429612) is red with this patch. ./build-support/jenkins

Re: Review Request 51826: Implement `toString` on lazy modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51826/#review148605 --- Fix it, then Ship it! :) src/main/java/org/apache/aurora/sche

Re: Review Request 51826: Implement `toString` on lazy modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51826/ --- (Updated Sept. 12, 2016, 2:44 p.m.) Review request for Aurora and Stephan Erb.

Review Request 51826: Implement `toString` on lazy modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51826/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description ---

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148602 --- Ship it! Master (b429612) is green with this patch. ./build-s

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

> On Sept. 12, 2016, 7:31 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java, > > lines 22-33 > > > > > > This is somewhat non-standard way to define cmd flag

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

> On Sept. 12, 2016, 9:31 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java, line > > 75 > > > > > > Would be great to have a e2e test when this functionality is

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/#review148600 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 12, 2016, 1:3

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/ --- (Updated Sept. 12, 2016, 9:29 p.m.) Review request for Aurora, Joshua Cohen, Ma

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

> On Sept. 12, 2016, 12:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/__init__.py, line 264 > > > > > > Why not going all the way to the client command and initializing both > > valu

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/ --- (Updated Sept. 12, 2016, 2:22 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

> On Sept. 12, 2016, 8:06 p.m., Zameer Manji wrote: > > docs/reference/scheduler-configuration.md, line 205 > > > > > > As an aside, could you file a ticket to clean up the default here? > > Seems useless ATM. > >

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

> On Sept. 12, 2016, 9:31 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java, > > lines 22-33 > > > > > > This is somewhat non-standard way to define cmd flag

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148576 --- Ship it! Master (b429612) is green with this patch. ./build-s

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

> On Sept. 12, 2016, 7:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/__init__.py, line 264 > > > > > > Why not going all the way to the client command and initializing both > > value

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

> On Sept. 12, 2016, 12:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/__init__.py, line 264 > > > > > > Why not going all the way to the client command and initializing both > > valu

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

> On Sept. 12, 2016, 12:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/__init__.py, line 264 > > > > > > Why not going all the way to the client command and initializing both > > valu

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148565 --- src/main/python/apache/aurora/client/api/__init__.py (line 264) <

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148566 --- Ship it! LGTM. I am not commiting this because there are outst

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/ --- (Updated Sept. 12, 2016, 12:39 p.m.) Review request for Aurora, Joshua Cohen an

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148564 --- Fix it, then Ship it! RELEASE-NOTES.md (line 37)

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/#review148563 --- src/main/java/org/apache/aurora/scheduler/resources/ResourceSetti

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148557 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/Read

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148549 --- Ship it! lgtm modulo the below. Thanks for iterating Karthik!

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

> On Sept. 12, 2016, 11:06 a.m., Zameer Manji wrote: > > docs/reference/scheduler-configuration.md, line 205 > > > > > > As an aside, could you file a ticket to clean up the default here? > > Seems useless ATM. > >

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

> On Sept. 12, 2016, 6:06 p.m., Zameer Manji wrote: > > docs/reference/scheduler-configuration.md, line 205 > > > > > > As an aside, could you file a ticket to clean up the default here? > > Seems useless ATM. Do y

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51759/#review148501 --- Along the lines of the question Stephan raised, what happens in th

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/#review148541 --- docs/reference/scheduler-configuration.md (line 205)

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148542 --- Ship it! Master (b429612) is green with this patch. ./build-s

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148539 --- Bumping this for visability. - Zameer Manji On Sept. 8, 2016, 5

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/ --- (Updated Sept. 12, 2016, 5:49 p.m.) Review request for Aurora, Joshua Cohen, Ma

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/#review148485 --- Master (b429612) is green with this patch. ./build-support/jenki

Review Request 51807: Introduce a flag to treat RAM as a revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51807/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti