Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

2016-09-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52276/#review150463 --- Ship it! Ship It! - Zameer Manji On Sept. 26, 2016, 2:16

Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

2016-09-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52276/#review150460 --- Ship it! Master (4ead189) is green with this patch.

Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

2016-09-26 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52276/ --- (Updated Sept. 26, 2016, 9:16 p.m.) Review request for Aurora and Zameer

Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

2016-09-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52276/#review150458 --- Master (4ead189) is red with this patch.

Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

2016-09-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52276/#review150457 --- src/main/java/org/apache/aurora/scheduler/events/Webhook.java

Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

2016-09-26 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52276/ --- Review request for Aurora and Zameer Manji. Bugs: AURORA-1783

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-26 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/#review150428 --- src/main/python/apache/aurora/executor/common/health_checker.py

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-26 Thread Zameer Manji
> On Sept. 23, 2016, 3:18 p.m., Zameer Manji wrote: > > src/main/python/apache/aurora/executor/aurora_executor.py, line 120 > > > > > > This check is brittle to determine if health checking is enabled. > > Please

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/#review150427 --- Ship it! Ship It! - Zameer Manji On Sept. 23, 2016, 11:58