Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

2016-12-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review157696 --- Master (3ea0331) is red with this patch.

Review Request 54288: Make leader elections resilient to ZK disconnections.

2016-12-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and

Re: Review Request 54269: Improve scheduling throughput via logging changes.

2016-12-01 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54269/#review157687 --- Fix it, then Ship it! Lgtm. Two comments below.

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/ --- (Updated Dec. 2, 2016, 1:28 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54269: Improve scheduling throughput via logging changes.

2016-12-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54269/ --- (Updated Dec. 1, 2016, 3:13 p.m.) Review request for Aurora, David McLaughlin,

Review Request 54269: Improve scheduling throughput via logging changes.

2016-12-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54269/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, and Stephan Erb.

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157664 --- Master (16e4651) is red with this patch.

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157662 --- @ReviewBot retry - Joshua Cohen On Dec. 1, 2016, 9:37 p.m.,

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157657 --- Ship it! Thanks, appreciate it! - Mehrdad Nurolahzade On

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157652 --- Master (16e4651) is red with this patch.

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/ --- (Updated Dec. 1, 2016, 9:37 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread David McLaughlin
> On Dec. 1, 2016, 8 p.m., Mehrdad Nurolahzade wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java, > > lines 90-94 > > > > > > Sorry, another nit, we can reduce GC overhead

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread David McLaughlin
> On Dec. 1, 2016, 9 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptorTest.java, > > line 40 > > > > > > Is there a reason we need the power mock runner? >

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157644 ---

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/ --- (Updated Dec. 1, 2016, 8:39 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157622 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Nov. 30,

Re: Review Request 54255: WIP: Update to Mesos 1.1.0.

2016-12-01 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/#review157610 --- Thanks for the tweaks to the make-mesos-native-egg script, out of

Re: Review Request 54255: WIP: Update to Mesos 1.1.0.

2016-12-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/#review157606 --- Master (8bcad84) is green with this patch.

Re: Review Request 54107: changes to intercept and time mybatis invocations

2016-12-01 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157601 --- Ship it! Ship It!

Review Request 54255: WIP: Update to Mesos 1.1.0.

2016-12-01 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/ --- Review request for Aurora. Bugs: AURORA-1813

Re: Review Request 54250: Revert removal of twitter/commons/zk based leadership code

2016-12-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54250/#review157571 --- Master (8bcad84) is green with this patch.