-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review157610
-----------------------------------------------------------



Thanks for the tweaks to the make-mesos-native-egg script, out of curiosity, 
what was the build time after the changes?


src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
 (line 94)
<https://reviews.apache.org/r/54255/#comment228221>

    What's the reasoning for this change?


- Joshua Cohen


On Dec. 1, 2016, 4:34 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2016, 4:34 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1813
>     https://issues.apache.org/jira/browse/AURORA-1813
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I will finish this work early next week. I will let you know when this patch 
> is ready for review/merge.
> 
> What have I done already:
> 
> * uploaded the new egg files. 
> 
> What is still missing:
> 
> * rebuild our packer image
> * update vagrant box to use the new image
> * prepare aurora-packaging for Mesos 1.1.0
> * run end-to-end tests
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126 
>   build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd 
>   build-support/python/make-mesos-native-egg 
> bcc6e85abb7536002afb3071c08e2008bcc1ecca 
>   build.gradle f257440e67384d9bd223b3c39785525bdb54dd9b 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 
> 4a1e0876609ce8eda457c0174e3ea3fbb8609376 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
>  7dc9eff2c7058e90eb93f7d7f4f378e8883989e5 
> 
> Diff: https://reviews.apache.org/r/54255/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to