Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review169977 --- Master (c32f14c) is red with this patch.

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- (Updated March 24, 2017, 4:38 a.m.) Review request for Aurora, David

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

2017-03-23 Thread Zameer Manji
> On March 11, 2017, 4:28 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java > > Lines 108-111 (patched) > > > > > > If the need for the flag is

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

2017-03-23 Thread Zameer Manji
> On March 11, 2017, 4:28 a.m., Stephan Erb wrote: > > I need a little bit more context to understand what is going on here: > > > > * Do you plan to use this with Thermos or an alternative executor? Or both? > > * It seems like we don't need this for Thermos as we already create > >

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
> On March 23, 2017, 4:52 p.m., David McLaughlin wrote: > > src/main/python/apache/aurora/admin/admin.py > > Lines 244 (patched) > > > > > > Where is options.no_retry defined? duh ! Bad push my bad. - Karthik

Re: Review Request 57881: Remove use of deprecated fields in tests

2017-03-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57881/#review169906 --- Ship it! Master (33acb89) is green with this patch.

Re: Review Request 57881: Remove use of deprecated fields in tests

2017-03-23 Thread Nicolás Donatucci
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57881/ --- (Updated March 23, 2017, 5:49 p.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review169894 --- src/main/python/apache/aurora/admin/admin.py Lines 244 (patched)

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review169889 --- Ship it! Master (33acb89) is green with this patch.

Re: Review Request 57881: Remove use of deprecated fields in tests

2017-03-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57881/#review169884 --- Master (33acb89) is red with this patch.

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- (Updated March 23, 2017, 4:23 p.m.) Review request for Aurora, David

Review Request 57881: Remove use of deprecated fields in tests

2017-03-23 Thread Nicolás Donatucci
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57881/ --- Review request for Aurora, Stephan Erb and Zameer Manji. Repository: aurora

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review169847 --- Master (33acb89) is red with this patch.

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- (Updated March 23, 2017, 8:23 a.m.) Review request for Aurora, David

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- (Updated March 23, 2017, 8:23 a.m.) Review request for Aurora, David

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- (Updated March 23, 2017, 8:22 a.m.) Review request for Aurora, David

Re: Review Request 57717: Support Mesos Maintenance

2017-03-23 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57717/#review169845 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On March 22,