Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/ --- (Updated April 27, 2015, 10:44 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review81753 --- Ship it! Ship It! - Bill Farner On April 27, 2015, 11:14 p.m.,

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review81747 --- Ship it! Master (94fe6c9) is green with this patch.

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/ --- (Updated April 27, 2015, 11:14 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-27 Thread Ben Mahler
On April 27, 2015, 11:05 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java, line 51 https://reviews.apache.org/r/33243/diff/2/?file=943401#file943401line51 Remove `credentials.get()`, it will throw a NullPointerException in this

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review81750 --- Ship it! Master (297c0eb) is green with this patch.

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review80276 --- Master (b18dc44) is red with this patch.

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-15 Thread Ben Mahler
On April 15, 2015, 10:49 p.m., Aurora ReviewBot wrote: Master (b18dc44) is red with this patch. ./build-support/jenkins/build.sh :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2