Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-29 Thread Stephan Erb
On Aug. 26, 2015, 7:55 p.m., Zameer Manji wrote: The ticket referenced also talks about {{mesos.ip}}, will you also add support for that? Steve Niemitz wrote: It's not exposed anywhere by mesos AFAIK. If someone can correct me I can add it in another review. I have to agree,

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-26 Thread Steve Niemitz
On Aug. 26, 2015, 5:39 p.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/config/test_thrift.py, line 177 https://reviews.apache.org/r/37801/diff/1/?file=1053308#file1053308line177 Would be great to have a non-empty hostname as well to explicitly assert its value. Is

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-26 Thread Steve Niemitz
On Aug. 26, 2015, 5:39 p.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/config/test_thrift.py, line 177 https://reviews.apache.org/r/37801/diff/1/?file=1053308#file1053308line177 Would be great to have a non-empty hostname as well to explicitly assert its value.

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-26 Thread Steve Niemitz
On Aug. 26, 2015, 5:55 p.m., Zameer Manji wrote: The ticket referenced also talks about {{mesos.ip}}, will you also add support for that? It's not exposed anywhere by mesos AFAIK. If someone can correct me I can add it in another review. - Steve

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37801/#review96565 --- The ticket referenced also talks about {{mesos.ip}}, will you also

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-26 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37801/ --- (Updated Aug. 26, 2015, 5:05 p.m.) Review request for Aurora. Bugs:

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37801/#review96560 --- src/test/python/apache/aurora/config/test_thrift.py (line 177)

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37801/#review96595 --- Ship it! Master (1a3ed7f) is green with this patch.