On Aug. 26, 2015, 7:55 p.m., Zameer Manji wrote:
The ticket referenced also talks about {{mesos.ip}}, will you also add
support for that?
Steve Niemitz wrote:
It's not exposed anywhere by mesos AFAIK. If someone can correct me I
can add it in another review.
I have to agree,
On Aug. 26, 2015, 5:39 p.m., Maxim Khutornenko wrote:
src/test/python/apache/aurora/config/test_thrift.py, line 177
https://reviews.apache.org/r/37801/diff/1/?file=1053308#file1053308line177
Would be great to have a non-empty hostname as well to explicitly
assert its value.
Is
On Aug. 26, 2015, 5:39 p.m., Maxim Khutornenko wrote:
src/test/python/apache/aurora/config/test_thrift.py, line 177
https://reviews.apache.org/r/37801/diff/1/?file=1053308#file1053308line177
Would be great to have a non-empty hostname as well to explicitly
assert its value.
On Aug. 26, 2015, 5:55 p.m., Zameer Manji wrote:
The ticket referenced also talks about {{mesos.ip}}, will you also add
support for that?
It's not exposed anywhere by mesos AFAIK. If someone can correct me I can add
it in another review.
- Steve
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96565
---
The ticket referenced also talks about {{mesos.ip}}, will you also
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
---
(Updated Aug. 26, 2015, 5:05 p.m.)
Review request for Aurora.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96560
---
src/test/python/apache/aurora/config/test_thrift.py (line 177)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96595
---
Ship it!
Master (1a3ed7f) is green with this patch.