Re: Review Request 43150: Expose MyBatis PoolState via stats

2016-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43150/#review117687 --- Ship it!

Re: Review Request 43150: Expose MyBatis PoolState via stats

2016-02-03 Thread Zameer Manji
> On Feb. 3, 2016, 2:19 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java, line > > 138 > > > > > > Recommend using statsProvider.untracked() here. What's the

Re: Review Request 43150: Expose MyBatis PoolState via stats

2016-02-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43150/ --- (Updated Feb. 3, 2016, 2:23 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 43150: Expose MyBatis PoolState via stats

2016-02-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43150/#review117686 --- Ship it! Master (2d91e18) is green with this patch.

Re: Review Request 43150: Expose MyBatis PoolState via stats

2016-02-03 Thread Zameer Manji
> On Feb. 3, 2016, 2:08 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java, line > > 275 > > > > > > Consider a bit more DRY - _almost_ like having local functions: > >

Re: Review Request 43150: Expose MyBatis PoolState via stats

2016-02-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43150/#review117690 --- Ship it! Ship It! - Bill Farner On Feb. 3, 2016, 2:23 p.m.,

Re: Review Request 43150: Expose MyBatis PoolState via stats

2016-02-03 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43150/#review117692 --- Ship it! Ship It! - John Sirois On Feb. 3, 2016, 3:23 p.m.,

Re: Review Request 43150: Expose MyBatis PoolState via stats

2016-02-03 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43150/#review117683 --- Ship it! Drive by LGTM.

Re: Review Request 43150: Expose MyBatis PoolState via stats

2016-02-03 Thread John Sirois
> On Feb. 3, 2016, 3:19 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java, line > > 138 > > > > > > Recommend using statsProvider.untracked() here. > > Zameer

Re: Review Request 43150: Expose MyBatis PoolState via stats

2016-02-03 Thread Maxim Khutornenko
> On Feb. 3, 2016, 10:19 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java, line > > 138 > > > > > > Recommend using statsProvider.untracked() here. > > Zameer

Re: Review Request 43150: Expose MyBatis PoolState via stats

2016-02-03 Thread Maxim Khutornenko
> On Feb. 3, 2016, 10:19 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java, line > > 138 > > > > > > Recommend using statsProvider.untracked() here. > > Zameer