Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130980 --- Ship it! Ship It! - John Sirois On April 28, 2016, 1:37

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/ --- (Updated April 28, 2016, 7:37 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
> On April 28, 2016, 10:02 a.m., John Sirois wrote: > > build-support/packer/build.sh, line 44 > > > > > > I'm missing how this is needed too. > > Joshua Cohen wrote: > If I remove this we don't have a jdk in

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
> On April 28, 2016, 10:02 a.m., John Sirois wrote: > > build-support/packer/build.sh, line 44 > > > > > > I'm missing how this is needed too. > > Joshua Cohen wrote: > If I remove this we don't have a jdk in

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130948 --- Ship it! Master (e817eb1) is green with this patch.

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Joshua Cohen
> On April 28, 2016, 4:02 p.m., John Sirois wrote: > > build-support/packer/build.sh, line 44 > > > > > > I'm missing how this is needed too. > > Joshua Cohen wrote: > If I remove this we don't have a jdk in the

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
> On April 28, 2016, 10:02 a.m., John Sirois wrote: > > build-support/packer/build.sh, line 44 > > > > > > I'm missing how this is needed too. > > Joshua Cohen wrote: > If I remove this we don't have a jdk in

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
> On April 28, 2016, 10:02 a.m., John Sirois wrote: > > build-support/packer/build.sh, line 44 > > > > > > I'm missing how this is needed too. > > Joshua Cohen wrote: > If I remove this we don't have a jdk in

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/ --- (Updated April 28, 2016, 5:08 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130929 --- build-support/packer/build.sh (line 37)

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130930 --- Ship it! Master (e817eb1) is green with this patch.

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Joshua Cohen
> On April 28, 2016, 3:54 p.m., Maxim Khutornenko wrote: > > build-support/packer/build.sh, line 37 > > > > > > What about the `java2-runtime-headless` proposed in that pull request? > > Did you find it redundant?

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130924 --- build-support/packer/build.sh (line 37)

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130923 --- Ship it! Ship It! - Stephan Erb On April 28, 2016, 5:48