Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-30 Thread Zameer Manji
> On Aug. 30, 2016, 12:37 a.m., Stephan Erb wrote: > > Were you able to test this on a cluster with concurrent modifications? > > Right now, I am not confident this is working as most ouf our thrift > > responses contain unordered sequences. I would therefore suspect that we > > get a

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-30 Thread Zameer Manji
> On Aug. 30, 2016, 12:37 a.m., Stephan Erb wrote: > > Were you able to test this on a cluster with concurrent modifications? > > Right now, I am not confident this is working as most ouf our thrift > > responses contain unordered sequences. I would therefore suspect that we > > get a

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-30 Thread Zameer Manji
> On Aug. 29, 2016, 6:32 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java, > > lines 139-142 > > > > > > Am I reading this correctly: you're buffering the

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-30 Thread Stephan Erb
> On Aug. 30, 2016, 9:37 a.m., Stephan Erb wrote: > > Were you able to test this on a cluster with concurrent modifications? > > Right now, I am not confident this is working as most ouf our thrift > > responses contain unordered sequences. I would therefore suspect that we > > get a

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-30 Thread Joshua Cohen
> On Aug. 30, 2016, 1:32 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java, > > lines 139-142 > > > > > > Am I reading this correctly: you're buffering the

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-30 Thread Zameer Manji
> On Aug. 30, 2016, 12:37 a.m., Stephan Erb wrote: > > Were you able to test this on a cluster with concurrent modifications? > > Right now, I am not confident this is working as most ouf our thrift > > responses contain unordered sequences. I would therefore suspect that we > > get a

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-30 Thread Zameer Manji
> On Aug. 29, 2016, 6:32 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java, > > lines 139-142 > > > > > > Am I reading this correctly: you're buffering the

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51513/#review147270 --- Were you able to test this on a cluster with concurrent

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51513/#review147256 --- Ship it! Master (c34f78a) is green with this patch.

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51513/#review147255 ---

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51513/#review147253 --- Reviewers: This is a simple implementation, but I think it works