Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/ --- (Updated April 9, 2015, 11:44 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review79468 --- Ship it! src/test/java/org/apache/aurora/scheduler/http/api/securi

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review79427 --- Ping, wfarner - Kevin Sweeney On April 6, 2015, 10:56 a.m., Kevin

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78958 --- Ship it! Master (27a602d) is green with this patch. ./build-suppo

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/ --- (Updated April 6, 2015, 10:56 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32559: Add Kerberos support to the scheduler

> On April 2, 2015, 5:23 p.m., Bill Farner wrote: > > src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh, line 1 > > > > > > Please invoke this from the existing end-to-end test script to avoid > > another qu

Re: Review Request 32559: Add Kerberos support to the scheduler

> On April 2, 2015, 5:23 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, > > lines 182-186 > > > > > > Why is this in a `finally`? Seems like a

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78834 --- This patch does not apply cleanly on master (05d75e5), do you need t

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/ --- (Updated April 3, 2015, 2:19 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32559: Add Kerberos support to the scheduler

> On April 2, 2015, 10:23 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java, > > line 46 > > > > > > What does this mean? Perhaps the missing context is

Re: Review Request 32559: Add Kerberos support to the scheduler

> On April 2, 2015, 10:23 a.m., Bill Farner wrote: > > src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh, line 1 > > > > > > Please invoke this from the existing end-to-end test script to avoid > > another q

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78608 --- src/main/java/org/apache/aurora/scheduler/http/api/security/Authori

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78549 --- Ship it! Ship It! - Joshua Cohen On March 27, 2015, 8:50 p.m., K

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78113 --- Ship it! Master (45f2a84) is green with this patch. ./build-suppo

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/ --- (Updated March 27, 2015, 1:50 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78109 --- @ReviewBot retry - Kevin Sweeney On March 27, 2015, 12:48 p.m., K

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78107 --- src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh

Re: Review Request 32559: Add Kerberos support to the scheduler

> On March 27, 2015, 6:09 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java, > > line 42 > > > > > > It feels like most of this stuff c

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78102 --- Master (45f2a84) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/ --- (Updated March 27, 2015, 12:48 p.m.) Review request for Aurora, Joshua Cohen an

Re: Review Request 32559: Add Kerberos support to the scheduler

> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote: > > examples/vagrant/provision-dev-cluster.sh, line 20 > > > > > > Is this needed to build kerberos in the test script? Do we need to > > build it from source? Can w

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78075 --- examples/vagrant/provision-dev-cluster.sh

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78006 --- Ship it! Master (45f2a84) is green with this patch. ./build-suppo

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/ --- (Updated March 26, 2015, 6:23 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78003 --- This patch does not apply cleanly on master (45f2a84), do you need t

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/ --- (Updated March 26, 2015, 6:13 p.m.) Review request for Aurora, Joshua Cohen and

Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora D