Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

> On Sept. 16, 2015, 2:54 p.m., Zameer Manji wrote: > > I'm proposing some changes in this review which I think will greatly > > simplify the code. > > Maxim Khutornenko wrote: > I agree there are ways to improve this functionality but given this is > mostly a restore of the old (and

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- (Updated Sept. 17, 2015, 12:26 p.m.) Review request for Aurora, Maxim

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

> On Sept. 16, 2015, 2:54 p.m., Zameer Manji wrote: > > commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java, line 40 > > > > > > Since the properties we are interested in are basically a Map

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99429 --- This is now on master. Thanks for the contribution! - Zameer Manji

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99430 --- Ship it! Master (d98bfc8) is green with this patch.

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99428 --- Ship it! Ship It! - Zameer Manji On Sept. 17, 2015, 12:26 p.m.,

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- (Updated Sept. 16, 2015, 2:53 p.m.) Review request for Aurora, Maxim

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99317 --- Ship it! Master (9dff057) is green with this patch.

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

> On Sept. 15, 2015, 4:25 p.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java, > > line 76 > > > > > > Revert Done - Joe

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99312 --- I'm proposing some changes in this review which I think will

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

> On Sept. 16, 2015, 2:54 p.m., Zameer Manji wrote: > > I'm proposing some changes in this review which I think will greatly > > simplify the code. > > Maxim Khutornenko wrote: > I agree there are ways to improve this functionality but given this is > mostly a restore of the old (and

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

> On Sept. 16, 2015, 9:54 p.m., Zameer Manji wrote: > > I'm proposing some changes in this review which I think will greatly > > simplify the code. I agree there are ways to improve this functionality but given this is mostly a restore of the old (and proven) commons code can we move these

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

> On Sept. 16, 2015, 2:54 p.m., Zameer Manji wrote: > > I'm proposing some changes in this review which I think will greatly > > simplify the code. > > Maxim Khutornenko wrote: > I agree there are ways to improve this functionality but given this is > mostly a restore of the old (and

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

> On Sept. 15, 2015, 5:32 p.m., Bill Farner wrote: > > This patch is looking good to me, but i won't have time to give it a fair > > look as i head out of town. I'd like to tap out so you don't have to wait > > 3 weeks to land it :-) Roger, thanks! - Joe

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

I can replace Bill on this review. On Wed, Sep 16, 2015 at 10:30 AM, Joe Smith wrote: > > > > On Sept. 15, 2015, 5:32 p.m., Bill Farner wrote: > > > This patch is looking good to me, but i won't have time to give it a > fair look as i head out of town. I'd like to tap out

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99132 --- This patch is looking good to me, but i won't have time to give it

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- (Updated Sept. 14, 2015, 11:46 a.m.) Review request for Aurora, Maxim

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

> On Sept. 11, 2015, 5:15 p.m., Bill Farner wrote: > > api/src/main/thrift/org/apache/aurora/gen/storage.thrift, lines 130-139 > > > > > > How about map for arbitrary metadata? then you don't > >

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review98712 --- Ship it! LGTM

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review98714 --- api/src/main/thrift/org/apache/aurora/gen/storage.thrift (lines

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review98518 --- .gitignore (line 14)

Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs:

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review98544 --- Ship it! Master (e57993b) is green with this patch.