Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review128162 --- Ship it! Ship It! - Bill Farner On April 9, 2016, 7:37

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review128048 --- Ship it! Master (0dd096d) is green with this patch.

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review128016 --- Master (0dd096d) is red with this patch.

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/ --- (Updated April 9, 2016, 8:37 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-09 Thread John Sirois
> On April 7, 2016, 6:42 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java, > > line 108 > > > > > > Shouldn't this be fatal? To me to looks like this

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review127817 ---

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review127713 --- Ship it! Ship It! - Zameer Manji On April 7, 2016, 4:07

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-07 Thread John Sirois
> On April 7, 2016, 6:42 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java, > > line 108 > > > > > > Shouldn't this be fatal? To me to looks like this

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review127708 ---

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review127691 --- Ship it! Master (c0cb631) is green with this patch.

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review127687 --- Ship it! Master (c0cb631) is green with this patch.

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-07 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review127683 --- Helpful reference links: The path cache recipe used:

Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

2016-04-07 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1468