Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.

2016-10-17 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52921/#review152893 --- Ship it! Ship It! - John Sirois On Oct. 16, 2016, 5:04

Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.

2016-10-17 Thread John Sirois
> On Oct. 17, 2016, 9:41 a.m., Joshua Cohen wrote: > > Should we also add: > > > > if (o == null) { > > return false; > > } > > > > ? > > > > Curious if we're able to see a difference in benchmarks from this change? It would be a bit of black magic if that were significantly

Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.

2016-10-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52921/#review152889 --- Should we also add: if (o == null) { return false;

Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.

2016-10-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52921/#review152814 --- Master (ac8b802) is green with this patch.

Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.

2016-10-16 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52921/ --- (Updated Oct. 17, 2016, 1:04 a.m.) Review request for Aurora. Repository: