Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-11-09 Thread Reza Motamedi
I ran `./build-support/jenkins/build.sh` and everything looked fine on my Mac. Can you tell me what the error message was? Regards, ~RM On Tue, Nov 7, 2017 at 4:33 PM, David McLaughlin wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63436/ > >

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-11-07 Thread Reza Motamedi
Testing now. Regards, ~ Reza On Tue, Nov 7, 2017 at 4:33 PM, David McLaughlin wrote: > > > > On Nov. 8, 2017, 12:22 a.m., Aurora ReviewBot wrote: > > > Master (ad86177) is green with this patch. > > > ./build-support/jenkins/build.sh > > > > > > I will refresh this build result if you post a

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-11-07 Thread David McLaughlin
> On Nov. 8, 2017, 12:22 a.m., Aurora ReviewBot wrote: > > Master (ad86177) is green with this patch. > > ./build-support/jenkins/build.sh > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" This fails for me consistently using: ./build-support/j

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review190402 --- Ship it! Master (ad86177) is green with this patch. ./build-s

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-11-07 Thread David McLaughlin
> On Nov. 8, 2017, 12:02 a.m., David McLaughlin wrote: > > @ReviewBot retry Ran into this when trying to commit to master: PASS src/main/js/components/__tests__/StateMachine-test.js FAIL src/main/js/components/__tests__/ErrorBoundary-test.js ? ErrorBoundary › Should show the error message whe

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-11-07 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review190392 --- @ReviewBot retry - David McLaughlin On Oct. 31, 2017, 8:15 p.m.

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-31 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review189781 --- Ship it! Ship It! - David McLaughlin On Oct. 31, 2017, 8:15

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-31 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review189779 --- Ship it! ui/src/main/js/components/__tests__/ErrorBoundary-tes

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review189757 --- Ship it! Master (d106b4e) is green with this patch. ./build-s

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-31 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review189756 --- Ship it! Ship It! - Joshua Cohen On Oct. 31, 2017, 8:15 p.m.

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-31 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/ --- (Updated Oct. 31, 2017, 8:15 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-30 Thread Joshua Cohen
> On Oct. 31, 2017, 2:08 a.m., David McLaughlin wrote: > > ui/src/main/js/components/ErrorBoundary.js > > Lines 28 (patched) > > > > > > Link to the Apache JIRA? And ask them to post the stacktrace below? Could even

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-30 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review189684 --- +1 to fix the error message in test. Wonder if we could try this?

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review189683 --- Ship it! Master (87eb891) is green with this patch. ./build-s

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-30 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review189682 --- This looks good. Just to confirm - the behavior we'd see after thi

Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-30 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, and Kai Huang. Repos