Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/#review199627 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On March 20,

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

> On March 20, 2018, 5:06 p.m., Santhosh Kumar Shanmugham wrote: > > docs/features/custom-executors.md > > Line 151 (original), 151 (patched) > > > > > > Link to > >

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/#review199624 --- Ship it! Master (b3fa9fe) is green with this patch.

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

> On March 20, 2018, 5:06 p.m., Santhosh Kumar Shanmugham wrote: > > RELEASE-NOTES.md > > Lines 7 (patched) > > > > > > s/---/-/g Great catch! > On March 20, 2018, 5:06 p.m., Santhosh Kumar Shanmugham wrote: > >

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/#review199618 --- Ship it! Master (b3fa9fe) is green with this patch.

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/#review199509 --- Fix it, then Ship it! LGTM. +1 to adding an e2e test.

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/ --- (Updated March 20, 2018, 4:24 p.m.) Review request for Aurora, Jordan Ly,

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/#review199578 --- Ship it! src/test/python/apache/aurora/config/test_thrift.py

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

> On March 19, 2018, 5:41 p.m., David McLaughlin wrote: > > Not sure how possible it is given the requirement for a completely custom > > executor, but e2e coverage would be great. Definitely possible, it's the end goal of going through my Aurora DSL backlog. I will most likely have to use

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/#review199504 --- Not sure how possible it is given the requirement for a

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/#review199503 --- Ship it! Ship It! - David McLaughlin On March 19, 2018,

Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/ --- Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan