date:20150623

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35498/#review88946
---

Ship it!


Master (2df2db9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 23, 2015, 9:13 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35498/
> ---
> 
> (Updated June 23, 2015, 9:13 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1350
> https://issues.apache.org/jira/browse/AURORA-1350
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Compute SLA stats for non-prod jobs
> 
> This is a first iteration closely following the design proposal of Maxim as 
> posted on the mailinglist. Feedback welcome.
> 
> 
> Diffs
> -
> 
>   docs/sla.md 14e9108fda91200bbf56384c96b9cd926689311f 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 82f36d5ca15df18bdc8ebbbd868d3394db38e603 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> 64e986fb2e0f955dd4a9c7824eac9494728bf24e 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> cb98834e925793fc116814371548a30470830164 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d 
> 
> Diff: https://reviews.apache.org/r/35498/diff/
> 
> 
> Testing
> ---
> 
> `./gradlew -Pq build` and a manual verification in Vagrant.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-23 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35498/
---

(Updated June 23, 2015, 11:13 a.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
---

Add missing periods to flag help text.


Bugs: AURORA-1350
https://issues.apache.org/jira/browse/AURORA-1350


Repository: aurora


Description
---

Compute SLA stats for non-prod jobs

This is a first iteration closely following the design proposal of Maxim as 
posted on the mailinglist. Feedback welcome.


Diffs (updated)
-

  docs/sla.md 14e9108fda91200bbf56384c96b9cd926689311f 
  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
82f36d5ca15df18bdc8ebbbd868d3394db38e603 
  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
  src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
64e986fb2e0f955dd4a9c7824eac9494728bf24e 
  src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
cb98834e925793fc116814371548a30470830164 
  src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d 

Diff: https://reviews.apache.org/r/35498/diff/


Testing
---

`./gradlew -Pq build` and a manual verification in Vagrant.


Thanks,

Stephan Erb

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Maxim Khutornenko



> On June 23, 2015, 2:19 a.m., Zameer Manji wrote:
> > src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java, line 69
> > 
> >
> > We can remove this test now that the gc executor is gone.

Seems like a valid test to have as the underlying functionality is still in use.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review88901
---


On June 23, 2015, 1:50 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> ---
> 
> (Updated June 23, 2015, 1:50 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Jave side of changes for removing gc executor support.
> 
> TaskLauncher refactoring will be addressed in a separate diff.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
>   debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
>   debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
>   debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
>   docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
>   examples/scheduler/scheduler-local.sh 
> 6253d505f9851aea613bc95c15c313b03b57af11 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 414539b1917b5d33c577f1539575934c7f7c8167 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> f4b867cbbcdbcc792518c2f90807834e47dce253 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 6edec22aba135136c4ce4066b9535f23de077db7 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8bcac6c4f93eaca7250d43ab81a72102b91bf836 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> f2ef70ddc5a859811f0e6c2ade62e115639c1654 
>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
> d2ec944ca12456c23eb54c9be8b1e6756f35e7f1 
>   src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
> ec43a44d9cbd0f303e4833953cdb65664d5ed569 
> 
> Diff: https://reviews.apache.org/r/35760/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/
---

(Updated June 23, 2015, 2:24 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

Adding missing Protobufs coverage and refactoring CommandUtilTest.


Bugs: AURORA-1334
https://issues.apache.org/jira/browse/AURORA-1334


Repository: aurora


Description
---

Jave side of changes for removing gc executor support.

TaskLauncher refactoring will be addressed in a separate diff.


Diffs (updated)
-

  config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
  debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
  debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
  debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
  docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
  examples/scheduler/scheduler-local.sh 
6253d505f9851aea613bc95c15c313b03b57af11 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
414539b1917b5d33c577f1539575934c7f7c8167 
  examples/vagrant/upstart/aurora-scheduler.conf 
f4b867cbbcdbcc792518c2f90807834e47dce253 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
6edec22aba135136c4ce4066b9535f23de077db7 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
8bcac6c4f93eaca7250d43ab81a72102b91bf836 
  src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
f2ef70ddc5a859811f0e6c2ade62e115639c1654 
  src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
d2ec944ca12456c23eb54c9be8b1e6756f35e7f1 
  src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
ec43a44d9cbd0f303e4833953cdb65664d5ed569 

Diff: https://reviews.apache.org/r/35760/diff/


Testing
---


Thanks,

Maxim Khutornenko

Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-1334
https://issues.apache.org/jira/browse/AURORA-1334


Repository: aurora


Description
---

Replacing TaskLauncher abstraction with TaskStatusUpdateManager.

Will not apply cleanly. Depends on https://reviews.apache.org/r/35760/.


Diffs
-

  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
6edec22aba135136c4ce4066b9535f23de077db7 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
cd55a6ee7424873c3e615d95422c9ecab6442f46 
  src/main/java/org/apache/aurora/scheduler/TaskStatusUpdateManager.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
8bcac6c4f93eaca7250d43ab81a72102b91bf836 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
4f7a1bec8c32aef4b5f435c760f69de13888ea9d 
  src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
126001a90c819f9b3bfd448a060102bcef8b2a35 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
e4e158721e0bdc7ed8a02eea24f4915ab937b9c7 

Diff: https://reviews.apache.org/r/35761/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/#review88977
---


This patch does not apply cleanly on master (2df2db9), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 23, 2015, 2:29 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35761/
> ---
> 
> (Updated June 23, 2015, 2:29 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replacing TaskLauncher abstraction with TaskStatusUpdateManager.
> 
> Will not apply cleanly. Depends on https://reviews.apache.org/r/35760/.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 6edec22aba135136c4ce4066b9535f23de077db7 
>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
> cd55a6ee7424873c3e615d95422c9ecab6442f46 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusUpdateManager.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8bcac6c4f93eaca7250d43ab81a72102b91bf836 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> 4f7a1bec8c32aef4b5f435c760f69de13888ea9d 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> 126001a90c819f9b3bfd448a060102bcef8b2a35 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> e4e158721e0bdc7ed8a02eea24f4915ab937b9c7 
> 
> Diff: https://reviews.apache.org/r/35761/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review88983
---

Ship it!


Master (2df2db9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 23, 2015, 2:24 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> ---
> 
> (Updated June 23, 2015, 2:24 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Jave side of changes for removing gc executor support.
> 
> TaskLauncher refactoring will be addressed in a separate diff.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
>   debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
>   debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
>   debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
>   docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
>   examples/scheduler/scheduler-local.sh 
> 6253d505f9851aea613bc95c15c313b03b57af11 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 414539b1917b5d33c577f1539575934c7f7c8167 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> f4b867cbbcdbcc792518c2f90807834e47dce253 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 6edec22aba135136c4ce4066b9535f23de077db7 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8bcac6c4f93eaca7250d43ab81a72102b91bf836 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> f2ef70ddc5a859811f0e6c2ade62e115639c1654 
>   src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
> d2ec944ca12456c23eb54c9be8b1e6756f35e7f1 
>   src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
> ec43a44d9cbd0f303e4833953cdb65664d5ed569 
> 
> Diff: https://reviews.apache.org/r/35760/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-06-23 Thread Jake Farrell


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33778/#review88987
---


Are you able to update this Steve? would love to get this in for 0.9.0

- Jake Farrell


On May 19, 2015, 4:19 p.m., Steve Salevan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33778/
> ---
> 
> (Updated May 19, 2015, 4:19 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-1116
> https://issues.apache.org/jira/browse/AURORA-1116
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This review board adds support for building Red Hat-flavored packages for the 
> Aurora scheduler alongside its client and Thermos-related binaries:
> 
> aurora - Aurora Scheduler
> aurora-client - Aurora client and admin tool
> aurora-thermos - Thermos executor, runner, and observer
> aurora-debuginfo - Debugging symbols for Python/libmesos integration
> 
> If you'd like to give it a whirl, the following Make targets will spin up new 
> RPMs:
> 
> make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped 
> versioning, suitable for producing nightly updates
> make (release_srpm|release_rpm) - builds without timestamped versioning
> 
> Let me know what you think, and thanks!
> 
> 
> Diffs
> -
> 
>   packaging/rpm/Makefile PRE-CREATION 
>   packaging/rpm/aurora.init.sh PRE-CREATION 
>   packaging/rpm/aurora.logrotate PRE-CREATION 
>   packaging/rpm/aurora.service PRE-CREATION 
>   packaging/rpm/aurora.spec PRE-CREATION 
>   packaging/rpm/aurora.startup.sh PRE-CREATION 
>   packaging/rpm/aurora.sysconfig PRE-CREATION 
>   packaging/rpm/clusters.json PRE-CREATION 
>   packaging/rpm/thermos-observer.init.sh PRE-CREATION 
>   packaging/rpm/thermos-observer.logrotate PRE-CREATION 
>   packaging/rpm/thermos-observer.service PRE-CREATION 
>   packaging/rpm/thermos-observer.startup.sh PRE-CREATION 
>   packaging/rpm/thermos-observer.sysconfig PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33778/diff/
> 
> 
> Testing
> ---
> 
> Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 
> and F19
> 
> 
> Thanks,
> 
> Steve Salevan
> 
>

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review89007
---

Ship it!


LGTM so long as end-to-end tests come up green.


docs/storage-config.md (line 103)


Consider a significantly higher number as the advice to make it clear, e.g. 
365days.



src/main/java/org/apache/aurora/scheduler/SchedulerModule.java (line 104)


while you're here, remove this newline


- Bill Farner


On June 23, 2015, 2:24 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> ---
> 
> (Updated June 23, 2015, 2:24 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Jave side of changes for removing gc executor support.
> 
> TaskLauncher refactoring will be addressed in a separate diff.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
>   debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
>   debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
>   debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
>   docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
>   examples/scheduler/scheduler-local.sh 
> 6253d505f9851aea613bc95c15c313b03b57af11 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 414539b1917b5d33c577f1539575934c7f7c8167 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> f4b867cbbcdbcc792518c2f90807834e47dce253 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 6edec22aba135136c4ce4066b9535f23de077db7 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8bcac6c4f93eaca7250d43ab81a72102b91bf836 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> f2ef70ddc5a859811f0e6c2ade62e115639c1654 
>   src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
> d2ec944ca12456c23eb54c9be8b1e6756f35e7f1 
>   src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
> ec43a44d9cbd0f303e4833953cdb65664d5ed569 
> 
> Diff: https://reviews.apache.org/r/35760/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/#review89008
---


LGTM overall, will give a ship once the rebase comes out green.


src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java (line 164)


Accessing the Impl suggests an encapsulagion problem.  Can you use the 
interface instead?



src/main/java/org/apache/aurora/scheduler/TaskStatusUpdateManager.java (line 21)


How about `TaskStatusReceiver` or `TaskStatusHandler`?



src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java (line 176)


Please include a comment explaining the rationale behind the default.


- Bill Farner


On June 23, 2015, 2:29 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35761/
> ---
> 
> (Updated June 23, 2015, 2:29 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replacing TaskLauncher abstraction with TaskStatusUpdateManager.
> 
> Will not apply cleanly. Depends on https://reviews.apache.org/r/35760/.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 6edec22aba135136c4ce4066b9535f23de077db7 
>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
> cd55a6ee7424873c3e615d95422c9ecab6442f46 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusUpdateManager.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8bcac6c4f93eaca7250d43ab81a72102b91bf836 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> 4f7a1bec8c32aef4b5f435c760f69de13888ea9d 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> 126001a90c819f9b3bfd448a060102bcef8b2a35 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> e4e158721e0bdc7ed8a02eea24f4915ab937b9c7 
> 
> Diff: https://reviews.apache.org/r/35761/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Maxim Khutornenko



> On June 23, 2015, 5:49 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 103
> > 
> >
> > Consider a significantly higher number as the advice to make it clear, 
> > e.g. 365days.

Done.


> On June 23, 2015, 5:49 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 108
> > 
> >
> > while you're here, remove this newline

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review89007
---


On June 23, 2015, 2:24 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> ---
> 
> (Updated June 23, 2015, 2:24 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Jave side of changes for removing gc executor support.
> 
> TaskLauncher refactoring will be addressed in a separate diff.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
>   debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
>   debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
>   debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
>   docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
>   examples/scheduler/scheduler-local.sh 
> 6253d505f9851aea613bc95c15c313b03b57af11 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 414539b1917b5d33c577f1539575934c7f7c8167 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> f4b867cbbcdbcc792518c2f90807834e47dce253 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 6edec22aba135136c4ce4066b9535f23de077db7 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8bcac6c4f93eaca7250d43ab81a72102b91bf836 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> f2ef70ddc5a859811f0e6c2ade62e115639c1654 
>   src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
> d2ec944ca12456c23eb54c9be8b1e6756f35e7f1 
>   src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
> ec43a44d9cbd0f303e4833953cdb65664d5ed569 
> 
> Diff: https://reviews.apache.org/r/35760/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/
---

(Updated June 23, 2015, 6 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

Bill's comments.


Bugs: AURORA-1334
https://issues.apache.org/jira/browse/AURORA-1334


Repository: aurora


Description
---

Jave side of changes for removing gc executor support.

TaskLauncher refactoring will be addressed in a separate diff.


Diffs (updated)
-

  config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
  debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
  debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
  debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
  docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
  examples/scheduler/scheduler-local.sh 
6253d505f9851aea613bc95c15c313b03b57af11 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
414539b1917b5d33c577f1539575934c7f7c8167 
  examples/vagrant/upstart/aurora-scheduler.conf 
f4b867cbbcdbcc792518c2f90807834e47dce253 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
6edec22aba135136c4ce4066b9535f23de077db7 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
8bcac6c4f93eaca7250d43ab81a72102b91bf836 
  src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
f2ef70ddc5a859811f0e6c2ade62e115639c1654 
  src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
d2ec944ca12456c23eb54c9be8b1e6756f35e7f1 
  src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
ec43a44d9cbd0f303e4833953cdb65664d5ed569 

Diff: https://reviews.apache.org/r/35760/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review89016
---

Ship it!


Master (2df2db9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 23, 2015, 6 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> ---
> 
> (Updated June 23, 2015, 6 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Jave side of changes for removing gc executor support.
> 
> TaskLauncher refactoring will be addressed in a separate diff.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
>   debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
>   debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
>   debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
>   docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
>   examples/scheduler/scheduler-local.sh 
> 6253d505f9851aea613bc95c15c313b03b57af11 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 414539b1917b5d33c577f1539575934c7f7c8167 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> f4b867cbbcdbcc792518c2f90807834e47dce253 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 6edec22aba135136c4ce4066b9535f23de077db7 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8bcac6c4f93eaca7250d43ab81a72102b91bf836 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> f2ef70ddc5a859811f0e6c2ade62e115639c1654 
>   src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
> d2ec944ca12456c23eb54c9be8b1e6756f35e7f1 
>   src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
> ec43a44d9cbd0f303e4833953cdb65664d5ed569 
> 
> Diff: https://reviews.apache.org/r/35760/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/
---

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-1298
https://issues.apache.org/jira/browse/AURORA-1298


Repository: aurora


Description
---

DbTaskStore: delete unreferenced job keys.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 
30e3469a9f69091b929a9243f84036fa2fdd0539 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
3ada6286e6ef6e3302802b74eec6c46dd582dc10 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
7ee001f9c019a1e7b669ae5cec6088bf974a3746 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 
8258fb102b7f5fca9635143ebaed542d43abeb9f 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
24cf52680b69e23f5ccbbcada0606975b0405d5b 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
63a784f843eb7edf9a13c623e5355169c7e8623b 
  src/test/java/org/apache/aurora/scheduler/storage/db/DbTaskStoreTest.java 
dda988d03634f8de582cf2b8ccdeb433c3e3de0c 

Diff: https://reviews.apache.org/r/35793/diff/


Testing
---

Note that this removes a defensive branch wherein we checked for inbound config 
references before attempting to delete.  With this change, we proactively 
delete and count on foreign key constraints to prevent deletion of rows that 
are still referenced.  I propose we adopt this as our pattern for handling 
shared references, as it seems to be the most sane approach available.

A gotcha with this case is that i do not believe mybatis provides a 
vendor-neutral approach to identify a consistency violation, and the best 
signal is a generic `PersistenceException`.  This is unfortunate since we can't 
distinguish between a hopeless query with invalid syntax, a network 
disconnection, or the anticipated case of a consistency violation.


Thanks,

Bill Farner

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/
---

(Updated June 23, 2015, 6:28 p.m.)


Review request for Aurora and Maxim Khutornenko.


Changes
---

Remove stale TODO.


Bugs: AURORA-1298
https://issues.apache.org/jira/browse/AURORA-1298


Repository: aurora


Description
---

DbTaskStore: delete unreferenced job keys.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 
30e3469a9f69091b929a9243f84036fa2fdd0539 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
3ada6286e6ef6e3302802b74eec6c46dd582dc10 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
7ee001f9c019a1e7b669ae5cec6088bf974a3746 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 
8258fb102b7f5fca9635143ebaed542d43abeb9f 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
24cf52680b69e23f5ccbbcada0606975b0405d5b 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
63a784f843eb7edf9a13c623e5355169c7e8623b 
  src/test/java/org/apache/aurora/scheduler/storage/db/DbTaskStoreTest.java 
dda988d03634f8de582cf2b8ccdeb433c3e3de0c 

Diff: https://reviews.apache.org/r/35793/diff/


Testing
---

Note that this removes a defensive branch wherein we checked for inbound config 
references before attempting to delete.  With this change, we proactively 
delete and count on foreign key constraints to prevent deletion of rows that 
are still referenced.  I propose we adopt this as our pattern for handling 
shared references, as it seems to be the most sane approach available.

A gotcha with this case is that i do not believe mybatis provides a 
vendor-neutral approach to identify a consistency violation, and the best 
signal is a generic `PersistenceException`.  This is unfortunate since we can't 
distinguish between a hopeless query with invalid syntax, a network 
disconnection, or the anticipated case of a consistency violation.


Thanks,

Bill Farner

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko



> On June 23, 2015, 5:55 p.m., Bill Farner wrote:
> > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line 
> > 167
> > 
> >
> > Accessing the Impl suggests an encapsulagion problem.  Can you use the 
> > interface instead?

Yes, changed to AbstractExecutionThreadService.


> On June 23, 2015, 5:55 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskStatusUpdateManager.java, 
> > line 21
> > 
> >
> > How about `TaskStatusReceiver` or `TaskStatusHandler`?

Going with TaskStatusHandler as it was on my list as well.


> On June 23, 2015, 5:55 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 176
> > 
> >
> > Please include a comment explaining the rationale behind the default.

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/#review89008
---


On June 23, 2015, 2:29 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35761/
> ---
> 
> (Updated June 23, 2015, 2:29 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replacing TaskLauncher abstraction with TaskStatusUpdateManager.
> 
> Will not apply cleanly. Depends on https://reviews.apache.org/r/35760/.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 6edec22aba135136c4ce4066b9535f23de077db7 
>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
> cd55a6ee7424873c3e615d95422c9ecab6442f46 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusUpdateManager.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8bcac6c4f93eaca7250d43ab81a72102b91bf836 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> 4f7a1bec8c32aef4b5f435c760f69de13888ea9d 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> 126001a90c819f9b3bfd448a060102bcef8b2a35 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> e4e158721e0bdc7ed8a02eea24f4915ab937b9c7 
> 
> Diff: https://reviews.apache.org/r/35761/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/
---

(Updated June 23, 2015, 6:35 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

Rebased and addressed Bill's comments.


Bugs: AURORA-1334
https://issues.apache.org/jira/browse/AURORA-1334


Repository: aurora


Description (updated)
---

Replacing TaskLauncher abstraction with TaskStatusUpdateManager.


Diffs (updated)
-

  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
ae31bdb587c0ea8380fc15c71fcf34e7e19405a6 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
cd55a6ee7424873c3e615d95422c9ecab6442f46 
  src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
17b358533853596f0a577958a3a7303fa61bf299 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
4f7a1bec8c32aef4b5f435c760f69de13888ea9d 
  src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
126001a90c819f9b3bfd448a060102bcef8b2a35 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
e4e158721e0bdc7ed8a02eea24f4915ab937b9c7 

Diff: https://reviews.apache.org/r/35761/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/#review89023
---

Ship it!


Master (68c4620) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 23, 2015, 6:28 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35793/
> ---
> 
> (Updated June 23, 2015, 6:28 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1298
> https://issues.apache.org/jira/browse/AURORA-1298
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> DbTaskStore: delete unreferenced job keys.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 
> 30e3469a9f69091b929a9243f84036fa2fdd0539 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> 3ada6286e6ef6e3302802b74eec6c46dd582dc10 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 7ee001f9c019a1e7b669ae5cec6088bf974a3746 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  8258fb102b7f5fca9635143ebaed542d43abeb9f 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 24cf52680b69e23f5ccbbcada0606975b0405d5b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 63a784f843eb7edf9a13c623e5355169c7e8623b 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbTaskStoreTest.java 
> dda988d03634f8de582cf2b8ccdeb433c3e3de0c 
> 
> Diff: https://reviews.apache.org/r/35793/diff/
> 
> 
> Testing
> ---
> 
> Note that this removes a defensive branch wherein we checked for inbound 
> config references before attempting to delete.  With this change, we 
> proactively delete and count on foreign key constraints to prevent deletion 
> of rows that are still referenced.  I propose we adopt this as our pattern 
> for handling shared references, as it seems to be the most sane approach 
> available.
> 
> A gotcha with this case is that i do not believe mybatis provides a 
> vendor-neutral approach to identify a consistency violation, and the best 
> signal is a generic `PersistenceException`.  This is unfortunate since we 
> can't distinguish between a hopeless query with invalid syntax, a network 
> disconnection, or the anticipated case of a consistency violation.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/#review89026
---

Ship it!


Master (68c4620) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 23, 2015, 6:35 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35761/
> ---
> 
> (Updated June 23, 2015, 6:35 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replacing TaskLauncher abstraction with TaskStatusUpdateManager.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ae31bdb587c0ea8380fc15c71fcf34e7e19405a6 
>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
> cd55a6ee7424873c3e615d95422c9ecab6442f46 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 17b358533853596f0a577958a3a7303fa61bf299 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> 4f7a1bec8c32aef4b5f435c760f69de13888ea9d 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> 126001a90c819f9b3bfd448a060102bcef8b2a35 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> e4e158721e0bdc7ed8a02eea24f4915ab937b9c7 
> 
> Diff: https://reviews.apache.org/r/35761/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/#review89022
---



src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
(line 132)


Any particular reason you've settled on an explicit removal call as opposed 
to a dedicated java trigger (1)? Triggers certainly have their pitfals but they 
may provide a cleaner solution and let us migrate easier to pure SQL triggers 
when H2 implements support for them (2)

(1) - http://www.h2database.com/html/features.html#triggers
(2) - http://www.h2database.com/html/roadmap.html



src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
(line 135)


A stat counter recording a successful removal would be nice here and below. 
That would help us monitoring cleanup health.


- Maxim Khutornenko


On June 23, 2015, 6:28 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35793/
> ---
> 
> (Updated June 23, 2015, 6:28 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1298
> https://issues.apache.org/jira/browse/AURORA-1298
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> DbTaskStore: delete unreferenced job keys.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 
> 30e3469a9f69091b929a9243f84036fa2fdd0539 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> 3ada6286e6ef6e3302802b74eec6c46dd582dc10 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 7ee001f9c019a1e7b669ae5cec6088bf974a3746 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  8258fb102b7f5fca9635143ebaed542d43abeb9f 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 24cf52680b69e23f5ccbbcada0606975b0405d5b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 63a784f843eb7edf9a13c623e5355169c7e8623b 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbTaskStoreTest.java 
> dda988d03634f8de582cf2b8ccdeb433c3e3de0c 
> 
> Diff: https://reviews.apache.org/r/35793/diff/
> 
> 
> Testing
> ---
> 
> Note that this removes a defensive branch wherein we checked for inbound 
> config references before attempting to delete.  With this change, we 
> proactively delete and count on foreign key constraints to prevent deletion 
> of rows that are still referenced.  I propose we adopt this as our pattern 
> for handling shared references, as it seems to be the most sane approach 
> available.
> 
> A gotcha with this case is that i do not believe mybatis provides a 
> vendor-neutral approach to identify a consistency violation, and the best 
> signal is a generic `PersistenceException`.  This is unfortunate since we 
> can't distinguish between a hopeless query with invalid syntax, a network 
> disconnection, or the anticipated case of a consistency violation.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Bill Farner



> On June 23, 2015, 6:58 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java,
> >  line 133
> > 
> >
> > Any particular reason you've settled on an explicit removal call as 
> > opposed to a dedicated java trigger (1)? Triggers certainly have their 
> > pitfals but they may provide a cleaner solution and let us migrate easier 
> > to pure SQL triggers when H2 implements support for them (2)
> > 
> > (1) - http://www.h2database.com/html/features.html#triggers
> > (2) - http://www.h2database.com/html/roadmap.html

Biggest issue is coupling to h2.  H2 only supports triggers written in java, 
implementing their API.  This would present a pretty big hurdle for using a 
different vendor.


> On June 23, 2015, 6:58 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java,
> >  line 136
> > 
> >
> > A stat counter recording a successful removal would be nice here and 
> > below. That would help us monitoring cleanup health.

What's the shelf life of that?  This seems like something we won't want to 
sprinkle in each of the many forthcoming places we need to do this, and doesn't 
seem like we'd actually be able to alert on it.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/#review89022
---


On June 23, 2015, 6:28 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35793/
> ---
> 
> (Updated June 23, 2015, 6:28 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1298
> https://issues.apache.org/jira/browse/AURORA-1298
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> DbTaskStore: delete unreferenced job keys.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 
> 30e3469a9f69091b929a9243f84036fa2fdd0539 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> 3ada6286e6ef6e3302802b74eec6c46dd582dc10 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 7ee001f9c019a1e7b669ae5cec6088bf974a3746 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  8258fb102b7f5fca9635143ebaed542d43abeb9f 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 24cf52680b69e23f5ccbbcada0606975b0405d5b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 63a784f843eb7edf9a13c623e5355169c7e8623b 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbTaskStoreTest.java 
> dda988d03634f8de582cf2b8ccdeb433c3e3de0c 
> 
> Diff: https://reviews.apache.org/r/35793/diff/
> 
> 
> Testing
> ---
> 
> Note that this removes a defensive branch wherein we checked for inbound 
> config references before attempting to delete.  With this change, we 
> proactively delete and count on foreign key constraints to prevent deletion 
> of rows that are still referenced.  I propose we adopt this as our pattern 
> for handling shared references, as it seems to be the most sane approach 
> available.
> 
> A gotcha with this case is that i do not believe mybatis provides a 
> vendor-neutral approach to identify a consistency violation, and the best 
> signal is a generic `PersistenceException`.  This is unfortunate since we 
> can't distinguish between a hopeless query with invalid syntax, a network 
> disconnection, or the anticipated case of a consistency violation.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/#review89039
---

Ship it!



src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java (line 
233)


s/manager/handler/


- Bill Farner


On June 23, 2015, 6:35 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35761/
> ---
> 
> (Updated June 23, 2015, 6:35 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replacing TaskLauncher abstraction with TaskStatusUpdateManager.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ae31bdb587c0ea8380fc15c71fcf34e7e19405a6 
>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
> cd55a6ee7424873c3e615d95422c9ecab6442f46 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 17b358533853596f0a577958a3a7303fa61bf299 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> 4f7a1bec8c32aef4b5f435c760f69de13888ea9d 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> 126001a90c819f9b3bfd448a060102bcef8b2a35 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> e4e158721e0bdc7ed8a02eea24f4915ab937b9c7 
> 
> Diff: https://reviews.apache.org/r/35761/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/#review89047
---


Discussed with Bill offline and it seems like having an offline periodic async 
GC processor would be a better long term solution. It would allow us to handle 
all cleanup in a single place but more importantly will remove the implicit 
perf tax applied on every GC-enabled transaction.

- Maxim Khutornenko


On June 23, 2015, 6:28 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35793/
> ---
> 
> (Updated June 23, 2015, 6:28 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1298
> https://issues.apache.org/jira/browse/AURORA-1298
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> DbTaskStore: delete unreferenced job keys.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 
> 30e3469a9f69091b929a9243f84036fa2fdd0539 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> 3ada6286e6ef6e3302802b74eec6c46dd582dc10 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 7ee001f9c019a1e7b669ae5cec6088bf974a3746 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  8258fb102b7f5fca9635143ebaed542d43abeb9f 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 24cf52680b69e23f5ccbbcada0606975b0405d5b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 63a784f843eb7edf9a13c623e5355169c7e8623b 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbTaskStoreTest.java 
> dda988d03634f8de582cf2b8ccdeb433c3e3de0c 
> 
> Diff: https://reviews.apache.org/r/35793/diff/
> 
> 
> Testing
> ---
> 
> Note that this removes a defensive branch wherein we checked for inbound 
> config references before attempting to delete.  With this change, we 
> proactively delete and count on foreign key constraints to prevent deletion 
> of rows that are still referenced.  I propose we adopt this as our pattern 
> for handling shared references, as it seems to be the most sane approach 
> available.
> 
> A gotcha with this case is that i do not believe mybatis provides a 
> vendor-neutral approach to identify a consistency violation, and the best 
> signal is a generic `PersistenceException`.  This is unfortunate since we 
> can't distinguish between a hopeless query with invalid syntax, a network 
> disconnection, or the anticipated case of a consistency violation.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/
---

(Updated June 23, 2015, 8:39 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

Bill's comment.


Bugs: AURORA-1334
https://issues.apache.org/jira/browse/AURORA-1334


Repository: aurora


Description
---

Replacing TaskLauncher abstraction with TaskStatusUpdateManager.


Diffs (updated)
-

  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
ae31bdb587c0ea8380fc15c71fcf34e7e19405a6 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
cd55a6ee7424873c3e615d95422c9ecab6442f46 
  src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
17b358533853596f0a577958a3a7303fa61bf299 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
4f7a1bec8c32aef4b5f435c760f69de13888ea9d 
  src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
126001a90c819f9b3bfd448a060102bcef8b2a35 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
e4e158721e0bdc7ed8a02eea24f4915ab937b9c7 

Diff: https://reviews.apache.org/r/35761/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko



> On June 23, 2015, 7:46 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, 
> > line 242
> > 
> >
> > s/manager/handler/

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/#review89039
---


On June 23, 2015, 6:35 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35761/
> ---
> 
> (Updated June 23, 2015, 6:35 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replacing TaskLauncher abstraction with TaskStatusUpdateManager.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ae31bdb587c0ea8380fc15c71fcf34e7e19405a6 
>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
> cd55a6ee7424873c3e615d95422c9ecab6442f46 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 17b358533853596f0a577958a3a7303fa61bf299 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> 4f7a1bec8c32aef4b5f435c760f69de13888ea9d 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> 126001a90c819f9b3bfd448a060102bcef8b2a35 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> e4e158721e0bdc7ed8a02eea24f4915ab937b9c7 
> 
> Diff: https://reviews.apache.org/r/35761/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Bill Farner



> On June 23, 2015, 8:12 p.m., Maxim Khutornenko wrote:
> > Discussed with Bill offline and it seems like having an offline periodic 
> > async GC processor would be a better long term solution. It would allow us 
> > to handle all cleanup in a single place but more importantly will remove 
> > the implicit perf tax applied on every GC-enabled transaction.

Thanks, this is a much more tidy approach.  Updated diff coming shortly.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/#review89047
---


On June 23, 2015, 6:28 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35793/
> ---
> 
> (Updated June 23, 2015, 6:28 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1298
> https://issues.apache.org/jira/browse/AURORA-1298
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> DbTaskStore: delete unreferenced job keys.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 
> 30e3469a9f69091b929a9243f84036fa2fdd0539 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> 3ada6286e6ef6e3302802b74eec6c46dd582dc10 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 7ee001f9c019a1e7b669ae5cec6088bf974a3746 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  8258fb102b7f5fca9635143ebaed542d43abeb9f 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 24cf52680b69e23f5ccbbcada0606975b0405d5b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 63a784f843eb7edf9a13c623e5355169c7e8623b 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbTaskStoreTest.java 
> dda988d03634f8de582cf2b8ccdeb433c3e3de0c 
> 
> Diff: https://reviews.apache.org/r/35793/diff/
> 
> 
> Testing
> ---
> 
> Note that this removes a defensive branch wherein we checked for inbound 
> config references before attempting to delete.  With this change, we 
> proactively delete and count on foreign key constraints to prevent deletion 
> of rows that are still referenced.  I propose we adopt this as our pattern 
> for handling shared references, as it seems to be the most sane approach 
> available.
> 
> A gotcha with this case is that i do not believe mybatis provides a 
> vendor-neutral approach to identify a consistency violation, and the best 
> signal is a generic `PersistenceException`.  This is unfortunate since we 
> can't distinguish between a hopeless query with invalid syntax, a network 
> disconnection, or the anticipated case of a consistency violation.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 35812: Remove "enable_legacy_constraints" flag.

2015-06-23 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/
---

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-1074
https://issues.apache.org/jira/browse/AURORA-1074


Repository: aurora


Description
---

Remove the "enable_legacy_constraints" flag and associated behaviour.


Diffs
-

  NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 b77b0ebbf303778e528b16ff3db1aa4e76f1 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 abbd23dd3ee4382565ce846eb035e2aa502badae 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 38ef412a6d29dfef7b305e00cf44522818303965 

Diff: https://reviews.apache.org/r/35812/diff/


Testing
---

./gradlew build -Pq


Thanks,

Zameer Manji

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

2015-06-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/#review89102
---

Ship it!


Master (4b8c34c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 23, 2015, 11:58 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35812/
> ---
> 
> (Updated June 23, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1074
> https://issues.apache.org/jira/browse/AURORA-1074
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove the "enable_legacy_constraints" flag and associated behaviour.
> 
> 
> Diffs
> -
> 
>   NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  abbd23dd3ee4382565ce846eb035e2aa502badae 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  38ef412a6d29dfef7b305e00cf44522818303965 
> 
> Diff: https://reviews.apache.org/r/35812/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Review Request 35813: Removing GC executor code.

2015-06-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/
---

Review request for Aurora, Bill Farner and Brian Wickman.


Bugs: AURORA-1333
https://issues.apache.org/jira/browse/AURORA-1333


Repository: aurora


Description
---

Removing GC executor code.


Diffs
-

  api/src/main/thrift/org/apache/aurora/gen/BUILD 
fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
  api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
  debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
  debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
  docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
  examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
  src/main/python/apache/aurora/executor/BUILD 
cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
  src/main/python/apache/aurora/executor/bin/BUILD 
0fbb0f1ee63499d9ce36150ae5e68fcc8a9e 
  src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
8093717266f8620ebc6ef4c028ac8c87ab8d22be 
  src/main/python/apache/aurora/executor/gc_executor.py 
d4392faf50f8c72f08f951962913248045d7fcb5 
  src/main/python/apache/thermos/cli/commands/BUILD 
1dae8c981bd750807ddd1b6071e232ff2697537d 
  src/main/python/apache/thermos/cli/commands/gc.py 
23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
  src/main/python/apache/thermos/cli/main.py 
f20f612790550b77ee3dc969c37317b014a64972 
  src/main/python/apache/thermos/core/BUILD 
efb68e84cf547cb9505a8caf5b47be394dee5145 
  src/main/python/apache/thermos/core/helper.py 
8cd32948663a5d5a1e975e1661b78de701710436 
  src/main/python/apache/thermos/core/inspector.py 
4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
  src/main/python/apache/thermos/monitoring/BUILD 
633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
  src/main/python/apache/thermos/monitoring/garbage.py 
aa5a2729ae6c94b6a270d97425767ccee121e588 
  src/test/python/apache/aurora/executor/BUILD 
f415ecc77022b34f053c35272d004e133803d702 
  src/test/python/apache/aurora/executor/bin/BUILD 
2caab2aec136ede9b51ce3bdd0d139270024ba48 
  src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py 
d4c1d572663039eb742f70de1e06d708eb0b769a 
  src/test/python/apache/aurora/executor/test_gc_executor.py 
17d359054d1fc33f79a7612162064abd335ccf81 
  src/test/python/apache/thermos/cli/commands/test_import.py 
74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
  src/test/python/apache/thermos/monitoring/BUILD 
89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
  src/test/python/apache/thermos/monitoring/test_garbage.py 
4309c46a3af5f12c8eb3192e3156348fa7c0db23 

Diff: https://reviews.apache.org/r/35813/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89104
---


slightly overzealous deleting.  the thermos gc stuff should still be part of 
the thermos toolchain.


src/main/python/apache/thermos/cli/commands/BUILD 


same



src/main/python/apache/thermos/cli/main.py 


no need to delete this.  'thermos gc' is a separate, valid command.


- Brian Wickman


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> ---
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
> https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Removing GC executor code.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
> a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD 
> cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> 0fbb0f1ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 
> 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 
> 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py 
> f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD 
> efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 
> 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 
> 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 
> 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py 
> aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD 
> f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 
> 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py 
> d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 
> 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 
> 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 
> 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89108
---

Ship it!


Master (4b8c34c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> ---
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
> https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Removing GC executor code.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
> a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD 
> cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> 0fbb0f1ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 
> 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 
> 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py 
> f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD 
> efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 
> 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 
> 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 
> 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py 
> aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD 
> f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 
> 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py 
> d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 
> 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 
> 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 
> 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Maxim Khutornenko



> On June 24, 2015, 12:31 a.m., Brian Wickman wrote:
> > slightly overzealous deleting.  the thermos gc stuff should still be part 
> > of the thermos toolchain.

Should not we rather rely on task reconciliation to do any cleanup instead? 
Force GCing a task does not seem to be a critical feature (in fact it's 
currently broken AURORA-1347) but comes with a maintenance burden. Is there a 
particular reason to hold on to it?


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89104
---


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> ---
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
> https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Removing GC executor code.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
> a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD 
> cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> 0fbb0f1ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 
> 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 
> 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py 
> f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD 
> efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 
> 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 
> 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 
> 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py 
> aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD 
> f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 
> 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py 
> d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 
> 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 
> 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 
> 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Maxim Khutornenko



> On June 24, 2015, 12:31 a.m., Brian Wickman wrote:
> > slightly overzealous deleting.  the thermos gc stuff should still be part 
> > of the thermos toolchain.
> 
> Maxim Khutornenko wrote:
> Should not we rather rely on task reconciliation to do any cleanup 
> instead? Force GCing a task does not seem to be a critical feature (in fact 
> it's currently broken AURORA-1347) but comes with a maintenance burden. Is 
> there a particular reason to hold on to it?

Actually meant "task reconciliation + mesos slave GC" above.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89104
---


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> ---
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
> https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Removing GC executor code.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
> a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD 
> cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> 0fbb0f1ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 
> 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 
> 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py 
> f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD 
> efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 
> 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 
> 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 
> 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py 
> aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD 
> f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 
> 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py 
> d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 
> 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 
> 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 
> 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35498: Compute SLA stats for non-prod jobs

Re: Review Request 35498: Compute SLA stats for non-prod jobs

Re: Review Request 35760: Removing GcExecutorLauncher code.

Re: Review Request 35760: Removing GcExecutorLauncher code.

Review Request 35761: Refactoring TaskLauncher.

Re: Review Request 35761: Refactoring TaskLauncher.

Re: Review Request 35760: Removing GcExecutorLauncher code.

Re: Review Request 33778: Adds RPM specfile and support scripting

Re: Review Request 35760: Removing GcExecutorLauncher code.

Re: Review Request 35761: Refactoring TaskLauncher.

Re: Review Request 35760: Removing GcExecutorLauncher code.

Re: Review Request 35760: Removing GcExecutorLauncher code.

Re: Review Request 35760: Removing GcExecutorLauncher code.

Review Request 35793: DbTaskStore: delete unreferenced job keys.

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

Re: Review Request 35761: Refactoring TaskLauncher.

Re: Review Request 35761: Refactoring TaskLauncher.

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

Re: Review Request 35761: Refactoring TaskLauncher.

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

Re: Review Request 35761: Refactoring TaskLauncher.

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

Re: Review Request 35761: Refactoring TaskLauncher.

Re: Review Request 35761: Refactoring TaskLauncher.

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

Review Request 35812: Remove "enable_legacy_constraints" flag.

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

Review Request 35813: Removing GC executor code.

Re: Review Request 35813: Removing GC executor code.

Re: Review Request 35813: Removing GC executor code.

Re: Review Request 35813: Removing GC executor code.

Re: Review Request 35813: Removing GC executor code.

33 matches

Site Navigation

Mail list logo

Footer information