Re: Review Request 40201: Cleanup thermos_executor test pexes.

2015-11-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40201/#review106421 --- Ship it! Ship It! - Joshua Cohen On Nov. 13, 2015, 3:32 p.m.,

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40197/#review106424 --- pants.ini (lines 27 - 29)

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread Bill Farner
> On Nov. 13, 2015, 8:55 a.m., John Sirois wrote: > > pants.ini, line 33 > > > > > > Seems worth a note this is only used by the vagrant provisioning ... or > > add this to `examples/vagrant/aurorabuild.sh`: > >

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40197/#review106422 --- Ship it! Ship It! - Joshua Cohen On Nov. 11, 2015, 8:30 p.m.,

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread John Sirois
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote: > > pants.ini, line 33 > > > > > > Seems worth a note this is only used by the vagrant provisioning ... or > > add this to `examples/vagrant/aurorabuild.sh`: > >

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread John Sirois
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote: > > pants.ini, line 33 > > > > > > Seems worth a note this is only used by the vagrant provisioning ... or > > add this to `examples/vagrant/aurorabuild.sh`: > >

Re: Review Request 40220: Modernize the pex venv script.

2015-11-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/#review106419 --- Ship it! Ship It! - Joshua Cohen On Nov. 12, 2015, 8:35 a.m.,

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-13 Thread John Sirois
> On Nov. 13, 2015, 8:42 a.m., Joshua Cohen wrote: > > pants.ini, lines 27-29 > > > > > > When I went to commit this change, I got a merge conflict applying the > > patch. According to git, these lines are not found

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-13 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40197/ --- (Updated Nov. 13, 2015, 8:46 a.m.) Review request for Aurora, Joshua Cohen and

Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40299/ --- Review request for Aurora, Joshua Cohen and John Sirois. Bugs: AURORA-1538

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40299/#review106438 --- pants.ini (line 33)

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40299/#review106451 --- Ship it! Ship It! - John Sirois On Nov. 13, 2015, 10:24 a.m.,

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40299/#review106437 --- Ship it! Master (cc7f5a1) is green with this patch.

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40299/#review106448 --- Ship it! Ship It! - Joshua Cohen On Nov. 13, 2015, 4:34 p.m.,

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40299/#review106447 --- Ship it! LGTM mod a pending comment - John Sirois On Nov. 13,

Re: Review Request 40201: Cleanup thermos_executor test pexes.

2015-11-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40201/#review106467 --- Ship it! Ship It! - Zameer Manji On Nov. 13, 2015, 7:32 a.m.,

Re: Review Request 40304: Upgrade to checkstyle 6.12.1

2015-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40304/#review106484 --- Ship it! Master (ba9819e) is green with this patch.

Re: Review Request 40304: Upgrade to checkstyle 6.12.1

2015-11-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40304/#review106507 --- Ship it! Ship It! - Zameer Manji On Nov. 13, 2015, 10:39 a.m.,

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106505 --- Ship it! Master (ba9819e) is green with this patch.

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-13 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 13, 2015, 4:27 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-13 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40219/#review106527 --- Replacement RB using official plugin is here: