Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

2016-01-11 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/ --- (Updated Jan. 12, 2016, 1:15 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

2016-01-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/#review113898 --- Ship it! Master (f064dc1) is green with this patch.

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

2016-01-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review113862 --- src/main/java/org/apache/aurora/scheduler/OfferAllocation.java

Re: Review Request 41785: Replace scheduler log scaffolding with logback

2016-01-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41785/ --- (Updated Jan. 11, 2016, 8:55 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

2016-01-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/ --- (Updated Jan. 12, 2016, 2:29 a.m.) Review request for Aurora, Maxim

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

2016-01-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42177/#review113921 --- Ship it! Master (f064dc1) is green with this patch.

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

2016-01-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review113917 --- Ship it! Master (f064dc1) is green with this patch.

Re: Review Request 41785: Replace scheduler log scaffolding with logback

2016-01-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41785/#review113934 --- Master (6a5309a) is green with this patch.

Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

2016-01-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42177/ --- Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill

Re: Review Request 34568: run tasks as user that match aurora-role

2016-01-11 Thread Bill Farner
> On Jan. 9, 2016, 4:43 p.m., Benjamin Staffin wrote: > > Any chance of getting this merged? It might be a surprise to some users, > > since right now there's no requirement for matching role accounts to exist > > inside the docker images, but with the right documentation about how to > >

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-11 Thread Bill Farner
> On Jan. 8, 2016, 10:50 a.m., Stephan Erb wrote: > > docs/deploying-aurora-scheduler.md, line 187 > > > > > > Make it more explicit that those will only be used if a job has no > > custom paramters. > > George

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

2016-01-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review113768 --- Nice job! Most comments here are nits to align code

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-11 Thread Bill Farner
> On Jan. 8, 2016, 10:50 a.m., Stephan Erb wrote: > > docs/deploying-aurora-scheduler.md, line 187 > > > > > > Make it more explicit that those will only be used if a job has no > > custom paramters. > > George

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

2016-01-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review113785 --- src/main/java/org/apache/aurora/scheduler/OfferAllocation.java

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-11 Thread George Sirois
> On Jan. 8, 2016, 6:50 p.m., Stephan Erb wrote: > > docs/deploying-aurora-scheduler.md, line 187 > > > > > > Make it more explicit that those will only be used if a job has no > > custom paramters. > > George

Re: Review Request 42145: Use tags instead of branches for release candidates.

2016-01-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42145/#review113764 --- build-support/release/release-candidate (line 29)

Re: Review Request 42145: Use tags instead of branches for release candidates.

2016-01-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42145/#review113778 --- Ship it! Master (e4c9c73) is green with this patch.

Re: Review Request 42145: Use tags instead of branches for release candidates.

2016-01-11 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42145/#review113809 --- Ship it! Ship It! - Zameer Manji On Jan. 11, 2016, 7:22 a.m.,

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-11 Thread Stephan Erb
> On Jan. 8, 2016, 7:50 p.m., Stephan Erb wrote: > > docs/deploying-aurora-scheduler.md, line 187 > > > > > > Make it more explicit that those will only be used if a job has no > > custom paramters. > > George

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

2016-01-11 Thread Amol Deshmukh
> On Jan. 10, 2016, 5:21 a.m., Bill Farner wrote: > > -1, please add test coverage to mitigate likelihood of breaking this change. > > Joshua Cohen wrote: > +1 to the -1 ;). Please add tests! Please let me know if you have suggestions/guidance for adding tests for this change. Given that

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42077/#review113825 --- Ship it! Master (f064dc1) is green with this patch.

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-11 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42077/ --- (Updated Jan. 11, 2016, 7:32 p.m.) Review request for Aurora, Joshua Cohen and