Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131679 --- Master (8a2fc4c) is red with this patch.

Re: Review Request 46948: Adding mesos resource converter

2016-05-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46948/#review131680 --- Ship it! lgtm once coverage is added.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 4, 2016, 2:36 p.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 4, 2016, 2:13 p.m.) Review request for Aurora, John Sirois, Maxim

Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46997/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

2016-05-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46997/#review131770 --- Ship it! Master (f25a4b1) is green with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131685 --- Ship it! Master (8a2fc4c) is green with this patch.

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131707 --- @ReviewBot retry - Maxim Khutornenko On May 4, 2016, 2:36

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Maxim Khutornenko
> On May 4, 2016, 12:19 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java, > > lines 76-78 > > > > > > Does this have to be bundled into this RB?

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131703 --- Ship it! build-support/packer/build.sh (line 68)

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131710 --- Ship it! Master (8a2fc4c) is green with this patch.

Re: Review Request 46948: Adding mesos resource converter

2016-05-04 Thread Maxim Khutornenko
> On May 4, 2016, 2:29 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java, > > line 34 > > > > > > Can you add tests for these classes? These are already

Re: Review Request 46948: Adding mesos resource converter

2016-05-04 Thread Joshua Cohen
> On May 4, 2016, 2:29 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java, > > line 34 > > > > > > Can you add tests for these classes? > > Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Joshua Cohen
> On May 4, 2016, 4:47 p.m., Maxim Khutornenko wrote: > > build-support/packer/build.sh, line 68 > > > > > > Is it possible to carve out a version constant here? Sure, will do. - Joshua

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/ --- (Updated May 4, 2016, 6:41 p.m.) Review request for Aurora, John Sirois, Maxim

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Joshua Cohen
> On May 4, 2016, 12:19 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java, > > lines 76-78 > > > > > > Does this have to be bundled into this RB?

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

2016-05-04 Thread Joshua Cohen
> On May 4, 2016, 12:19 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java, > > lines 76-78 > > > > > > Does this have to be bundled into this RB?

Re: Review Request 46948: Adding mesos resource converter

2016-05-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46948/#review131735 --- Ship it! Ship It! - Zameer Manji On May 3, 2016, 2:11 p.m.,