Re: Review Request 50584: Upgrade to Mesos 1.0.0

2016-07-29 Thread Maxim Khutornenko
> On July 29, 2016, 7:37 p.m., Maxim Khutornenko wrote: > > build-support/packer/build.sh, line 141 > > > > > > Is there a release note or a jira link that would support mesos.native > > -> mesos.executor

Re: Review Request 50584: Upgrade to Mesos 1.0.0

2016-07-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50584/#review144185 --- Ship it! Ship It! - Maxim Khutornenko On July 28, 2016,

Re: Review Request 50584: Upgrade to Mesos 1.0.0

2016-07-29 Thread Joshua Cohen
> On July 29, 2016, 7:37 p.m., Maxim Khutornenko wrote: > > build-support/packer/build.sh, line 141 > > > > > > Is there a release note or a jira link that would support mesos.native > > -> mesos.executor

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-29 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50432/ --- (Updated July 29, 2016, 2 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50432/#review144191 --- src/main/python/apache/aurora/client/config.py

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-29 Thread Mehrdad Nurolahzade
> On July 29, 2016, 2:03 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/config.py, line 138 > > > > > > Isn't this undoing the bug fix to compare w/ `Empty` instead of `None`? You are right, not

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-29 Thread Igor Morozov
> On July 29, 2016, 7:25 p.m., Maxim Khutornenko wrote: > > Finally had time to go over this review in detail. I am afraid the proposed > > approach of rolling back the arbitrary update may not work in general case > > and result in unexpected outcome, inconsistent job state and hard to > >

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-29 Thread Maxim Khutornenko
> On July 29, 2016, 7:25 p.m., Maxim Khutornenko wrote: > > Finally had time to go over this review in detail. I am afraid the proposed > > approach of rolling back the arbitrary update may not work in general case > > and result in unexpected outcome, inconsistent job state and hard to > >

Re: Review Request 50530: AURORA-1656 Document tier concept

2016-07-29 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50530/#review144167 --- Can we git this merged? - Mehrdad Nurolahzade On July 27,

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-29 Thread Igor Morozov
> On July 29, 2016, 7:25 p.m., Maxim Khutornenko wrote: > > Finally had time to go over this review in detail. I am afraid the proposed > > approach of rolling back the arbitrary update may not work in general case > > and result in unexpected outcome, inconsistent job state and hard to > >

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50432/#review144195 --- Ship it! Master (e14d0a3) is green with this patch.

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

2016-07-29 Thread Mehrdad Nurolahzade
> On July 29, 2016, 2:03 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/config.py, line 138 > > > > > > Isn't this undoing the bug fix to compare w/ `Empty` instead of `None`? > > Mehrdad

Re: Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144202 --- Ship it! Ship It! - David McLaughlin On July 29, 2016, 9:21

Re: Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144206 --- Ship it! Master (e14d0a3) is green with this patch.

Re: Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144212 --- Props to Joshua for finding a problem with these test scenarios.

Re: Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/ --- (Updated July 29, 2016, 3:46 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144215 --- Master (e14d0a3) is red with this patch.

Re: Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/ --- (Updated July 29, 2016, 3:44 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144223 --- Ship it! Ship It! - Joshua Cohen On July 29, 2016, 10:46

Review Request 50617: AURORA-1741 Added missing test cases

2016-07-29 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs: