Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-02 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147667 --- Ship it! Ship it! I am not a fan of extensive mocking.

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-02 Thread John Sirois
> On Sept. 2, 2016, 12:35 p.m., John Sirois wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 251 > > > > > > You might extract this as a helper function > > (`_entity_exists(returncode:

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-02 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147681 --- Ship it!

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-02 Thread John Sirois
> On Sept. 2, 2016, 12:35 p.m., John Sirois wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 251 > > > > > > You might extract this as a helper function > > (`_entity_exists(returncode:

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-02 Thread Zhitao Li
> On Sept. 2, 2016, 6:35 p.m., John Sirois wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 251 > > > > > > You might extract this as a helper function > > (`_entity_exists(returncode:

Re: Review Request 51615: Upgrade to latest CherryPy.

2016-09-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51615/#review147698 --- Ship it! Master (80cf585) is green with this patch.

Re: Review Request 51595: Add Job Store and Dynamic Reservations design docs

2016-09-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51595/#review147687 --- AFAIK, the Job Store design doc is on hold right? Maybe we

Review Request 51615: Upgrade to latest CherryPy.

2016-09-02 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51615/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description

Re: Review Request 51602: Extend the resource isolation and oversubscription documentation

2016-09-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51602/#review147686 --- Ship it! LGTM. Should we link to the `latest` version of the

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

2016-09-02 Thread Kai Huang
> On Sept. 1, 2016, 7:51 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 467 > > > > > > This is not sufficent to determine if healthchecking occurs. > > > > We now

Re: Review Request 51615: Upgrade to latest CherryPy.

2016-09-02 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51615/#review147696 --- Ship it! Ship It! - Stephan Erb On Sept. 2, 2016, 10:55

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

2016-09-02 Thread Kai Huang
> On Sept. 1, 2016, 7:59 p.m., Dmitriy Shirchenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, > > lines 126-131 > > > > > > +1 on @zmanji's comment. > >

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

2016-09-02 Thread Zameer Manji
> On Sept. 1, 2016, 12:51 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 467 > > > > > > This is not sufficent to determine if healthchecking occurs. > > > > We now

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-09-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51384/#review147694 --- Looks great! Only a few comments left.

Re: Review Request 51602: Extend the resource isolation and oversubscription documentation

2016-09-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51602/#review147701 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 2, 2016,

Re: Review Request 51595: Add Job Store and Dynamic Reservations design docs

2016-09-02 Thread Maxim Khutornenko
> On Sept. 2, 2016, 7:13 p.m., Zameer Manji wrote: > > AFAIK, the Job Store design doc is on hold right? > > > > Maybe we shouldn't link to it until someone works on it. +1. That design doc needs some love before we can start linking it. - Maxim