Re: Review Request 52437: Adding support for Ubuntu Xenial packages

> On Sept. 30, 2016, 2:31 p.m., Dmitriy Shirchenko wrote: > > builder/deb/ubuntu-xenial/Dockerfile, lines 36-40 > > > > > > For my own curiousity: is the step of adding gpg keys strictly > > necessary? Why does

Re: Review Request 52453: Add a patch that links client and executor change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151098 --- Master (ed72b1b) is green with this patch.

Review Request 52453: Add a patch that links client and executor change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-894

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review151091 --- Ship it! Ship It! - Dmitriy Shirchenko On Sept. 30, 2016,

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review151066 --- builder/deb/ubuntu-xenial/Dockerfile (lines 36 - 40)

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review151078 --- Ship it! Ship It! - Zameer Manji On Sept. 29, 2016, 4:43

Review Request 52437: Adding support for Ubuntu Xenial packages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/ --- Review request for Aurora. Repository: aurora-packaging Description ---

Re: Review Request 52428: Add missing libffi build dep to support pants.

> On Sept. 30, 2016, 12:58 p.m., Stephan Erb wrote: > > Do the vagrant files have to be adapted as well? Nope - those support testing and the testing does not use pants, just its products in `.rpm` or `.deb` form. - John --- This is

Re: Review Request 52428: Add missing libffi build dep to support pants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151061 --- Ship it! Do the vagrant files have to be adapted as well? -

Re: Review Request 52428: Add missing libffi build dep to support pants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151055 --- Ship it! Ship It! - Joshua Cohen On Sept. 30, 2016, 6:17

Re: Review Request 52428: Add missing libffi build dep to support pants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151053 --- Ship it! Ship It! - Zameer Manji On Sept. 30, 2016, 11:17

Review Request 52428: Add missing libffi build dep to support pants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Repository:

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/#review151050 --- Ship it! Master (59b4d31) is green with this patch.

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/#review151045 --- Ship it! Ship It! - Joshua Cohen On Sept. 30, 2016, 5:17

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/ --- (Updated Sept. 30, 2016, 5:17 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

> On Sept. 30, 2016, 4:11 p.m., Joshua Cohen wrote: > > Can you add a test case for the scenario where a status provider throws > > during initialization? > > Kai Huang wrote: > Oh, that's a good point. Will do. Thanks. e2e's passed for me locally w/ this patch, so once the tests are

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

> On Sept. 30, 2016, 4:11 p.m., Joshua Cohen wrote: > > Can you add a test case for the scenario where a status provider throws > > during initialization? Oh, that's a good point. Will do. - Kai --- This is an automatically generated

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/#review151029 --- Can you add a test case for the scenario where a status provider

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52300/#review151028 --- Ship it! Master (1a72438) is green with this patch.

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52300/ --- (Updated Sept. 30, 2016, 3:19 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 52422: Improve docker perf in the Vagrant vm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52422/#review151018 --- Ship it! Master (655105d) is green with this patch.

Re: Review Request 52422: Improve docker perf in the Vagrant vm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52422/#review151017 --- Ship it! Ship It! - Joshua Cohen On Sept. 30, 2016, 2:15

Review Request 52422: Improve docker perf in the Vagrant vm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52422/ --- Review request for Aurora and Joshua Cohen. Bugs: AURORA-1784

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52300/#review151005 --- Ship it! Master (655105d) is green with this patch.

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52300/ --- (Updated Sept. 30, 2016, 10:08 a.m.) Review request for Aurora, Joshua Cohen