Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-09-30 Thread Renan DelValle 


> On Sept. 30, 2016, 2:31 p.m., Dmitriy Shirchenko wrote:
> > builder/deb/ubuntu-xenial/Dockerfile, lines 36-40
> > 
> >
> > For my own curiousity: is the step of adding gpg keys strictly 
> > necessary? Why does ubuntu need it but not debian?

Hmmm, I'm actually not too sure on this since I cribbed this from the Ubuntu 
Trusty setup. It seems that the version we want in this case isn't the default 
one in Ubuntu so we set the repo and keys manually.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review151066
---


On Sept. 30, 2016, 12:23 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Sept. 30, 2016, 12:23 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52453: Add a patch that links client and executor change

2016-09-30 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/#review151098
---



Master (ed72b1b) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 30, 2016, 9:52 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52453/
> ---
> 
> (Updated Sept. 30, 2016, 9:52 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-894
> https://issues.apache.org/jira/browse/AURORA-894
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Add support for receiving a new HealthCheckConfig attribute 
> "min_consecutive_successes" in health checker.
> - Add an entry in release note that describes the health check driven update 
> feature.
> 
> This patch is related to https://reviews.apache.org/r/52094/, in which I 
> added a new configuration value "min_consecutive_successes" in 
> HealthCheckConfig.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 03fbffdc3862a94c2ba42c9b9e8f2be4094129b8 
> 
> Diff: https://reviews.apache.org/r/52453/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./pants test.pytest src/test/python/apache/aurora/executor::
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Review Request 52453: Add a patch that links client and executor change

2016-09-30 Thread Kai Huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/
---

Review request for Aurora, Joshua Cohen and Zameer Manji.


Bugs: AURORA-894
https://issues.apache.org/jira/browse/AURORA-894


Repository: aurora


Description
---

- Add support for receiving a new HealthCheckConfig attribute 
"min_consecutive_successes" in health checker.
- Add an entry in release note that describes the health check driven update 
feature.

This patch is related to https://reviews.apache.org/r/52094/, in which I added 
a new configuration value "min_consecutive_successes" in HealthCheckConfig.


Diffs
-

  RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
  src/main/python/apache/aurora/executor/common/health_checker.py 
03fbffdc3862a94c2ba42c9b9e8f2be4094129b8 

Diff: https://reviews.apache.org/r/52453/diff/


Testing
---

./build-support/jenkins/build.sh

./pants test.pytest src/test/python/apache/aurora/executor::

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Kai Huang

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-09-30 Thread Dmitriy Shirchenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review151091
---


Ship it!




Ship It!

- Dmitriy Shirchenko


On Sept. 30, 2016, 7:23 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Sept. 30, 2016, 7:23 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-09-30 Thread Dmitriy Shirchenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review151066
---




builder/deb/ubuntu-xenial/Dockerfile (lines 36 - 40)


For my own curiousity: is the step of adding gpg keys strictly necessary? 
Why does ubuntu need it but not debian?


- Dmitriy Shirchenko


On Sept. 30, 2016, 7:23 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Sept. 30, 2016, 7:23 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-30 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52094/#review151078
---


Ship it!




Ship It!

- Zameer Manji


On Sept. 29, 2016, 4:43 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52094/
> ---
> 
> (Updated Sept. 29, 2016, 4:43 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1224
> https://issues.apache.org/jira/browse/AURORA-1224
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add min_consecutive_health_checks to HealthCheckConfig.
> 
> [Summary]
> HealthCheckConfig should accept a new configuration value that will tell how 
> many positive consecutive health checks an instance requires to move from 
> STARTING to RUNNING.
> 
> [Background]
> This review depends on the executor change(AURORA-1225). Please see 
> https://reviews.apache.org/r/51876/ for more details and background.
> 
> [Change List]
> 1. Add a configuration value "min_consecutive_health_checks"(default=1) to 
> HealthCheckConfig struct.
> 2. Modify the default value of watch_secs to be 0.
> 3. Add a client-side constraint: 
> initial_interval_secs >= min_consecutive_health_checks * interval_secs
> 4. Update the unit tests for health check config in client/config.py, skip 
> unit tests related to watch_secs.
> 
> 
> Diffs
> -
> 
>   docs/reference/configuration.md f2a0b1873f31e91f3bf0cac6f8448e8130fae688 
>   src/main/python/apache/aurora/client/config.py 
> 0186af52f0d7d7e3981ec59bf6a01aafee2bcfb1 
>   src/main/python/apache/aurora/config/schema/base.py 
> 845163043b0b7b2f9e7aca14677ca9f094658551 
>   src/test/python/apache/aurora/client/test_config.py 
> 5cf68a5145ddf9478baa30453c0bcb73136fa7eb 
> 
> Diff: https://reviews.apache.org/r/52094/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./pants test.pytest src/test/python/apache/aurora/client::
> 
> ./pants test.pytest src/test/python/apache/aurora/config::
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Review Request 52437: Adding support for Ubuntu Xenial packages

2016-09-30 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/
---

Review request for Aurora.


Repository: aurora-packaging


Description
---

Added builder and test environment for Xenial as well as updated instructions 
on how to test it.

Added distributtion to release-candidate script.


Diffs
-

  build-support/release/release-candidate 
c08c88529ec036989032869198da7a21dcf6ac35 
  builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
  builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
  test/deb/ubuntu-xenial/README.md PRE-CREATION 
  test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
  test/deb/ubuntu-xenial/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/52437/diff/


Testing
---

Created artifacts using the build-artifacts script.

Brought a vagrant image up, installed all deb files created by the artifacts 
script, started both aurora-scheduler and thermos services, and launched a 
sample job.


Thanks,

Renan DelValle

Re: Review Request 52428: Add missing libffi build dep to support pants.

2016-09-30 Thread John Sirois 


> On Sept. 30, 2016, 12:58 p.m., Stephan Erb wrote:
> > Do the vagrant files have to be adapted as well?

Nope - those support testing and the testing does not use pants, just its 
products in `.rpm` or `.deb` form.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52428/#review151061
---


On Sept. 30, 2016, 12:17 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52428/
> ---
> 
> (Updated Sept. 30, 2016, 12:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> builder/deb/debian-jessie/Dockerfile | 1 +
>  builder/deb/ubuntu-trusty/Dockerfile | 1 +
>  builder/rpm/centos-7/Dockerfile  | 1 +
>  3 files changed, 3 insertions(+)
> 
> 
> Diffs
> -
> 
>   builder/deb/debian-jessie/Dockerfile 
> 4a70359f56b5c4b3a3dd30d005f39ee03707427a 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 56f81e3b0533d2a2be84e723c143dee3e6e7e79a 
>   builder/rpm/centos-7/Dockerfile 3431860708f59460dd2f6b575e23f280e903d41e 
> 
> Diff: https://reviews.apache.org/r/52428/diff/
> 
> 
> Testing
> ---
> 
> This corrects the missing deps seen here:
>   https://builds.apache.org/job/aurora-packaging-nightly/440/
> 
> Now locally green:
> ```
> (aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o 
> snapshot.tar.gz HEAD
> (aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz 
> 0.17.0-SNAPSHOT
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 52428: Add missing libffi build dep to support pants.

2016-09-30 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52428/#review151061
---


Ship it!




Do the vagrant files have to be adapted as well?

- Stephan Erb


On Sept. 30, 2016, 8:17 nachm., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52428/
> ---
> 
> (Updated Sept. 30, 2016, 8:17 nachm.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> builder/deb/debian-jessie/Dockerfile | 1 +
>  builder/deb/ubuntu-trusty/Dockerfile | 1 +
>  builder/rpm/centos-7/Dockerfile  | 1 +
>  3 files changed, 3 insertions(+)
> 
> 
> Diffs
> -
> 
>   builder/deb/debian-jessie/Dockerfile 
> 4a70359f56b5c4b3a3dd30d005f39ee03707427a 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 56f81e3b0533d2a2be84e723c143dee3e6e7e79a 
>   builder/rpm/centos-7/Dockerfile 3431860708f59460dd2f6b575e23f280e903d41e 
> 
> Diff: https://reviews.apache.org/r/52428/diff/
> 
> 
> Testing
> ---
> 
> This corrects the missing deps seen here:
>   https://builds.apache.org/job/aurora-packaging-nightly/440/
> 
> Now locally green:
> ```
> (aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o 
> snapshot.tar.gz HEAD
> (aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz 
> 0.17.0-SNAPSHOT
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 52428: Add missing libffi build dep to support pants.

2016-09-30 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52428/#review151055
---


Ship it!




Ship It!

- Joshua Cohen


On Sept. 30, 2016, 6:17 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52428/
> ---
> 
> (Updated Sept. 30, 2016, 6:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> builder/deb/debian-jessie/Dockerfile | 1 +
>  builder/deb/ubuntu-trusty/Dockerfile | 1 +
>  builder/rpm/centos-7/Dockerfile  | 1 +
>  3 files changed, 3 insertions(+)
> 
> 
> Diffs
> -
> 
>   builder/deb/debian-jessie/Dockerfile 
> 4a70359f56b5c4b3a3dd30d005f39ee03707427a 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 56f81e3b0533d2a2be84e723c143dee3e6e7e79a 
>   builder/rpm/centos-7/Dockerfile 3431860708f59460dd2f6b575e23f280e903d41e 
> 
> Diff: https://reviews.apache.org/r/52428/diff/
> 
> 
> Testing
> ---
> 
> This corrects the missing deps seen here:
>   https://builds.apache.org/job/aurora-packaging-nightly/440/
> 
> Now locally green:
> ```
> (aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o 
> snapshot.tar.gz HEAD
> (aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz 
> 0.17.0-SNAPSHOT
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 52428: Add missing libffi build dep to support pants.

2016-09-30 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52428/#review151053
---


Ship it!




Ship It!

- Zameer Manji


On Sept. 30, 2016, 11:17 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52428/
> ---
> 
> (Updated Sept. 30, 2016, 11:17 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> builder/deb/debian-jessie/Dockerfile | 1 +
>  builder/deb/ubuntu-trusty/Dockerfile | 1 +
>  builder/rpm/centos-7/Dockerfile  | 1 +
>  3 files changed, 3 insertions(+)
> 
> 
> Diffs
> -
> 
>   builder/deb/debian-jessie/Dockerfile 
> 4a70359f56b5c4b3a3dd30d005f39ee03707427a 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 56f81e3b0533d2a2be84e723c143dee3e6e7e79a 
>   builder/rpm/centos-7/Dockerfile 3431860708f59460dd2f6b575e23f280e903d41e 
> 
> Diff: https://reviews.apache.org/r/52428/diff/
> 
> 
> Testing
> ---
> 
> This corrects the missing deps seen here:
>   https://builds.apache.org/job/aurora-packaging-nightly/440/
> 
> Now locally green:
> ```
> (aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o 
> snapshot.tar.gz HEAD
> (aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz 
> 0.17.0-SNAPSHOT
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Review Request 52428: Add missing libffi build dep to support pants.

2016-09-30 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52428/
---

Review request for Aurora, Joshua Cohen and Stephan Erb.


Repository: aurora-packaging


Description
---

builder/deb/debian-jessie/Dockerfile | 1 +
 builder/deb/ubuntu-trusty/Dockerfile | 1 +
 builder/rpm/centos-7/Dockerfile  | 1 +
 3 files changed, 3 insertions(+)


Diffs
-

  builder/deb/debian-jessie/Dockerfile 4a70359f56b5c4b3a3dd30d005f39ee03707427a 
  builder/deb/ubuntu-trusty/Dockerfile 56f81e3b0533d2a2be84e723c143dee3e6e7e79a 
  builder/rpm/centos-7/Dockerfile 3431860708f59460dd2f6b575e23f280e903d41e 

Diff: https://reviews.apache.org/r/52428/diff/


Testing
---

This corrects the missing deps seen here:
  https://builds.apache.org/job/aurora-packaging-nightly/440/

Now locally green:
```
(aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o 
snapshot.tar.gz HEAD
(aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz 
0.17.0-SNAPSHOT
```


Thanks,

John Sirois

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-30 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review151050
---


Ship it!




Master (59b4d31) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 30, 2016, 5:17 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51876/
> ---
> 
> (Updated Sept. 30, 2016, 5:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1225
> https://issues.apache.org/jira/browse/AURORA-1225
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Modify executor state transition logic to rely on health checks (if enabled).
> 
> [Summary]
> Executor needs to start executing user content in STARTING and transition to 
> RUNNING when a successful required number of health checks is reached.
> 
> This review contains a series of executor changes that implement the health 
> check driven updates. It gives more context of the design of this feature.
> 
> [Background]
> Please see this epic: https://issues.apache.org/jira/browse/AURORA-1225
> and the design doc: 
> https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
>  for more details and background.
> 
> [Description]
> If health check is enabled on vCurrent executor, the health checker will send 
> a "TASK_RUNNING" message when a successful required number of health checks 
> is reached within the initial_interval_secs. On the other hand, a 
> "TASK_FAILED" message was sent if the health checker fails to reach the 
> required number of health checks within that period, or a maximum number of 
> failed health check limit is reached after the initital_interval_secs.
> 
> If health check is disabled on the vCurrent executor, it will sends 
> "TASK_RUNNING" message to scheduler after the thermos runner was started. In 
> this scenario, the behavior of vCurrent executor will be the same as the 
> vPrev executor.
> 
> [Change List]
> The current change set includes:
> 1. Removed the status memoization in ChainedStatusChecker.
> 2. Modified the StatusManager to be edge triggered.
> 3. Changed the Aurora Executor callback function.
> 4. Modified the Health Checker and redefined the meaning 
> initial_interval_secs.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> ce5ef680f01831cd89fced8969ae3246c7f60cfd 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 5fc845eceac6f0c048d7489fdc4c672b0c609ea0 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 795dae2d6b661fc528d952c2315196d94127961f 
>   src/main/python/apache/aurora/executor/status_manager.py 
> 228a99a05f339e21cd7e769a42b9b2276e7bc3fc 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> bb6ea69dd94298c5b8cf4d5f06d06eea7790d66e 
>   src/test/python/apache/aurora/executor/common/test_status_checker.py 
> 5be1981c8c8e88258456adb21aa3ca7c0aa472a7 
>   src/test/python/apache/aurora/executor/test_status_manager.py 
> ce4679ba1aa7b42cf0115c943d84663030182d23 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 0bfe9e931f873c9f804f2ba4012e050e1f9fd24e 
> 
> Diff: https://reviews.apache.org/r/51876/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./pants test.pytest src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-30 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review151045
---


Ship it!




Ship It!

- Joshua Cohen


On Sept. 30, 2016, 5:17 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51876/
> ---
> 
> (Updated Sept. 30, 2016, 5:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1225
> https://issues.apache.org/jira/browse/AURORA-1225
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Modify executor state transition logic to rely on health checks (if enabled).
> 
> [Summary]
> Executor needs to start executing user content in STARTING and transition to 
> RUNNING when a successful required number of health checks is reached.
> 
> This review contains a series of executor changes that implement the health 
> check driven updates. It gives more context of the design of this feature.
> 
> [Background]
> Please see this epic: https://issues.apache.org/jira/browse/AURORA-1225
> and the design doc: 
> https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
>  for more details and background.
> 
> [Description]
> If health check is enabled on vCurrent executor, the health checker will send 
> a "TASK_RUNNING" message when a successful required number of health checks 
> is reached within the initial_interval_secs. On the other hand, a 
> "TASK_FAILED" message was sent if the health checker fails to reach the 
> required number of health checks within that period, or a maximum number of 
> failed health check limit is reached after the initital_interval_secs.
> 
> If health check is disabled on the vCurrent executor, it will sends 
> "TASK_RUNNING" message to scheduler after the thermos runner was started. In 
> this scenario, the behavior of vCurrent executor will be the same as the 
> vPrev executor.
> 
> [Change List]
> The current change set includes:
> 1. Removed the status memoization in ChainedStatusChecker.
> 2. Modified the StatusManager to be edge triggered.
> 3. Changed the Aurora Executor callback function.
> 4. Modified the Health Checker and redefined the meaning 
> initial_interval_secs.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> ce5ef680f01831cd89fced8969ae3246c7f60cfd 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 5fc845eceac6f0c048d7489fdc4c672b0c609ea0 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 795dae2d6b661fc528d952c2315196d94127961f 
>   src/main/python/apache/aurora/executor/status_manager.py 
> 228a99a05f339e21cd7e769a42b9b2276e7bc3fc 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> bb6ea69dd94298c5b8cf4d5f06d06eea7790d66e 
>   src/test/python/apache/aurora/executor/common/test_status_checker.py 
> 5be1981c8c8e88258456adb21aa3ca7c0aa472a7 
>   src/test/python/apache/aurora/executor/test_status_manager.py 
> ce4679ba1aa7b42cf0115c943d84663030182d23 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 0bfe9e931f873c9f804f2ba4012e050e1f9fd24e 
> 
> Diff: https://reviews.apache.org/r/51876/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./pants test.pytest src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-30 Thread Kai Huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/
---

(Updated Sept. 30, 2016, 5:17 p.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Changes
---

Add test case for the scenario where a status provider throws during 
initialization.


Bugs: AURORA-1225
https://issues.apache.org/jira/browse/AURORA-1225


Repository: aurora


Description
---

Modify executor state transition logic to rely on health checks (if enabled).

[Summary]
Executor needs to start executing user content in STARTING and transition to 
RUNNING when a successful required number of health checks is reached.

This review contains a series of executor changes that implement the health 
check driven updates. It gives more context of the design of this feature.

[Background]
Please see this epic: https://issues.apache.org/jira/browse/AURORA-1225
and the design doc: 
https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
 for more details and background.

[Description]
If health check is enabled on vCurrent executor, the health checker will send a 
"TASK_RUNNING" message when a successful required number of health checks is 
reached within the initial_interval_secs. On the other hand, a "TASK_FAILED" 
message was sent if the health checker fails to reach the required number of 
health checks within that period, or a maximum number of failed health check 
limit is reached after the initital_interval_secs.

If health check is disabled on the vCurrent executor, it will sends 
"TASK_RUNNING" message to scheduler after the thermos runner was started. In 
this scenario, the behavior of vCurrent executor will be the same as the vPrev 
executor.

[Change List]
The current change set includes:
1. Removed the status memoization in ChainedStatusChecker.
2. Modified the StatusManager to be edge triggered.
3. Changed the Aurora Executor callback function.
4. Modified the Health Checker and redefined the meaning initial_interval_secs.


Diffs (updated)
-

  src/main/python/apache/aurora/executor/aurora_executor.py 
ce5ef680f01831cd89fced8969ae3246c7f60cfd 
  src/main/python/apache/aurora/executor/common/health_checker.py 
5fc845eceac6f0c048d7489fdc4c672b0c609ea0 
  src/main/python/apache/aurora/executor/common/status_checker.py 
795dae2d6b661fc528d952c2315196d94127961f 
  src/main/python/apache/aurora/executor/status_manager.py 
228a99a05f339e21cd7e769a42b9b2276e7bc3fc 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
bb6ea69dd94298c5b8cf4d5f06d06eea7790d66e 
  src/test/python/apache/aurora/executor/common/test_status_checker.py 
5be1981c8c8e88258456adb21aa3ca7c0aa472a7 
  src/test/python/apache/aurora/executor/test_status_manager.py 
ce4679ba1aa7b42cf0115c943d84663030182d23 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
0bfe9e931f873c9f804f2ba4012e050e1f9fd24e 

Diff: https://reviews.apache.org/r/51876/diff/


Testing
---

./build-support/jenkins/build.sh

./pants test.pytest src/test/python/apache/aurora/executor::


Thanks,

Kai Huang

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-30 Thread Joshua Cohen 


> On Sept. 30, 2016, 4:11 p.m., Joshua Cohen wrote:
> > Can you add a test case for the scenario where a status provider throws 
> > during initialization?
> 
> Kai Huang wrote:
> Oh, that's a good point. Will do.

Thanks. e2e's passed for me locally w/ this patch, so once the tests are added 
this is good to go!


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review151029
---


On Sept. 29, 2016, 11:11 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51876/
> ---
> 
> (Updated Sept. 29, 2016, 11:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1225
> https://issues.apache.org/jira/browse/AURORA-1225
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Modify executor state transition logic to rely on health checks (if enabled).
> 
> [Summary]
> Executor needs to start executing user content in STARTING and transition to 
> RUNNING when a successful required number of health checks is reached.
> 
> This review contains a series of executor changes that implement the health 
> check driven updates. It gives more context of the design of this feature.
> 
> [Background]
> Please see this epic: https://issues.apache.org/jira/browse/AURORA-1225
> and the design doc: 
> https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
>  for more details and background.
> 
> [Description]
> If health check is enabled on vCurrent executor, the health checker will send 
> a "TASK_RUNNING" message when a successful required number of health checks 
> is reached within the initial_interval_secs. On the other hand, a 
> "TASK_FAILED" message was sent if the health checker fails to reach the 
> required number of health checks within that period, or a maximum number of 
> failed health check limit is reached after the initital_interval_secs.
> 
> If health check is disabled on the vCurrent executor, it will sends 
> "TASK_RUNNING" message to scheduler after the thermos runner was started. In 
> this scenario, the behavior of vCurrent executor will be the same as the 
> vPrev executor.
> 
> [Change List]
> The current change set includes:
> 1. Removed the status memoization in ChainedStatusChecker.
> 2. Modified the StatusManager to be edge triggered.
> 3. Changed the Aurora Executor callback function.
> 4. Modified the Health Checker and redefined the meaning 
> initial_interval_secs.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> ce5ef680f01831cd89fced8969ae3246c7f60cfd 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 5fc845eceac6f0c048d7489fdc4c672b0c609ea0 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 795dae2d6b661fc528d952c2315196d94127961f 
>   src/main/python/apache/aurora/executor/status_manager.py 
> 228a99a05f339e21cd7e769a42b9b2276e7bc3fc 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> bb6ea69dd94298c5b8cf4d5f06d06eea7790d66e 
>   src/test/python/apache/aurora/executor/common/test_status_checker.py 
> 5be1981c8c8e88258456adb21aa3ca7c0aa472a7 
>   src/test/python/apache/aurora/executor/test_status_manager.py 
> ce4679ba1aa7b42cf0115c943d84663030182d23 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 0bfe9e931f873c9f804f2ba4012e050e1f9fd24e 
> 
> Diff: https://reviews.apache.org/r/51876/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./pants test.pytest src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-30 Thread Kai Huang 


> On Sept. 30, 2016, 4:11 p.m., Joshua Cohen wrote:
> > Can you add a test case for the scenario where a status provider throws 
> > during initialization?

Oh, that's a good point. Will do.


- Kai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review151029
---


On Sept. 29, 2016, 11:11 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51876/
> ---
> 
> (Updated Sept. 29, 2016, 11:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1225
> https://issues.apache.org/jira/browse/AURORA-1225
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Modify executor state transition logic to rely on health checks (if enabled).
> 
> [Summary]
> Executor needs to start executing user content in STARTING and transition to 
> RUNNING when a successful required number of health checks is reached.
> 
> This review contains a series of executor changes that implement the health 
> check driven updates. It gives more context of the design of this feature.
> 
> [Background]
> Please see this epic: https://issues.apache.org/jira/browse/AURORA-1225
> and the design doc: 
> https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
>  for more details and background.
> 
> [Description]
> If health check is enabled on vCurrent executor, the health checker will send 
> a "TASK_RUNNING" message when a successful required number of health checks 
> is reached within the initial_interval_secs. On the other hand, a 
> "TASK_FAILED" message was sent if the health checker fails to reach the 
> required number of health checks within that period, or a maximum number of 
> failed health check limit is reached after the initital_interval_secs.
> 
> If health check is disabled on the vCurrent executor, it will sends 
> "TASK_RUNNING" message to scheduler after the thermos runner was started. In 
> this scenario, the behavior of vCurrent executor will be the same as the 
> vPrev executor.
> 
> [Change List]
> The current change set includes:
> 1. Removed the status memoization in ChainedStatusChecker.
> 2. Modified the StatusManager to be edge triggered.
> 3. Changed the Aurora Executor callback function.
> 4. Modified the Health Checker and redefined the meaning 
> initial_interval_secs.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> ce5ef680f01831cd89fced8969ae3246c7f60cfd 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 5fc845eceac6f0c048d7489fdc4c672b0c609ea0 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 795dae2d6b661fc528d952c2315196d94127961f 
>   src/main/python/apache/aurora/executor/status_manager.py 
> 228a99a05f339e21cd7e769a42b9b2276e7bc3fc 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> bb6ea69dd94298c5b8cf4d5f06d06eea7790d66e 
>   src/test/python/apache/aurora/executor/common/test_status_checker.py 
> 5be1981c8c8e88258456adb21aa3ca7c0aa472a7 
>   src/test/python/apache/aurora/executor/test_status_manager.py 
> ce4679ba1aa7b42cf0115c943d84663030182d23 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 0bfe9e931f873c9f804f2ba4012e050e1f9fd24e 
> 
> Diff: https://reviews.apache.org/r/51876/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./pants test.pytest src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

2016-09-30 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review151029
---



Can you add a test case for the scenario where a status provider throws during 
initialization?

- Joshua Cohen


On Sept. 29, 2016, 11:11 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51876/
> ---
> 
> (Updated Sept. 29, 2016, 11:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1225
> https://issues.apache.org/jira/browse/AURORA-1225
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Modify executor state transition logic to rely on health checks (if enabled).
> 
> [Summary]
> Executor needs to start executing user content in STARTING and transition to 
> RUNNING when a successful required number of health checks is reached.
> 
> This review contains a series of executor changes that implement the health 
> check driven updates. It gives more context of the design of this feature.
> 
> [Background]
> Please see this epic: https://issues.apache.org/jira/browse/AURORA-1225
> and the design doc: 
> https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
>  for more details and background.
> 
> [Description]
> If health check is enabled on vCurrent executor, the health checker will send 
> a "TASK_RUNNING" message when a successful required number of health checks 
> is reached within the initial_interval_secs. On the other hand, a 
> "TASK_FAILED" message was sent if the health checker fails to reach the 
> required number of health checks within that period, or a maximum number of 
> failed health check limit is reached after the initital_interval_secs.
> 
> If health check is disabled on the vCurrent executor, it will sends 
> "TASK_RUNNING" message to scheduler after the thermos runner was started. In 
> this scenario, the behavior of vCurrent executor will be the same as the 
> vPrev executor.
> 
> [Change List]
> The current change set includes:
> 1. Removed the status memoization in ChainedStatusChecker.
> 2. Modified the StatusManager to be edge triggered.
> 3. Changed the Aurora Executor callback function.
> 4. Modified the Health Checker and redefined the meaning 
> initial_interval_secs.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> ce5ef680f01831cd89fced8969ae3246c7f60cfd 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 5fc845eceac6f0c048d7489fdc4c672b0c609ea0 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 795dae2d6b661fc528d952c2315196d94127961f 
>   src/main/python/apache/aurora/executor/status_manager.py 
> 228a99a05f339e21cd7e769a42b9b2276e7bc3fc 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> bb6ea69dd94298c5b8cf4d5f06d06eea7790d66e 
>   src/test/python/apache/aurora/executor/common/test_status_checker.py 
> 5be1981c8c8e88258456adb21aa3ca7c0aa472a7 
>   src/test/python/apache/aurora/executor/test_status_manager.py 
> ce4679ba1aa7b42cf0115c943d84663030182d23 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 0bfe9e931f873c9f804f2ba4012e050e1f9fd24e 
> 
> Diff: https://reviews.apache.org/r/51876/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./pants test.pytest src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-30 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review151028
---


Ship it!




Master (1a72438) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 30, 2016, 3:19 p.m., JING CHEN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> ---
> 
> (Updated Sept. 30, 2016, 3:19 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
> https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Running task ssh without an instance should pick the random instance
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> d2233b67b37f8b34fae62372aa5d95e0a2e827b5 
> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> ---
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-30 Thread JING CHEN 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/
---

(Updated Sept. 30, 2016, 3:19 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

fix a typo


Bugs: AURORA-1110
https://issues.apache.org/jira/browse/AURORA-1110


Repository: aurora


Description
---

Running task ssh without an instance should pick the random instance


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/options.py 
1245ff15a69a4b4347672f7b556985521e813a00 
  src/main/python/apache/aurora/client/cli/task.py 
a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
  src/test/python/apache/aurora/client/cli/test_task.py 
d2233b67b37f8b34fae62372aa5d95e0a2e827b5 

Diff: https://reviews.apache.org/r/52300/diff/


Testing
---

verified in vagrant


Thanks,

JING CHEN

Re: Review Request 52422: Improve docker perf in the Vagrant vm.

2016-09-30 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52422/#review151018
---


Ship it!




Master (655105d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 30, 2016, 2:15 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52422/
> ---
> 
> (Updated Sept. 30, 2016, 2:15 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1784
> https://issues.apache.org/jira/browse/AURORA-1784
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use the aufs storage driver for better disk io perf and eliminate a
> high timeout workaround for slow container image copies.
> 
>  examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout 
> | 1 -
>  examples/vagrant/provision-dev-cluster.sh   
> | 5 +++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> 
> Diffs
> -
> 
>   examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout 
> 108b54e5fa5e3229376cb7250272120b48b4089d 
>   examples/vagrant/provision-dev-cluster.sh 
> 7a35971c7c2df6346018439ef98505d786454c54 
> 
> Diff: https://reviews.apache.org/r/52422/diff/
> 
> 
> Testing
> ---
> 
> Greater than 2x speed improvement on file ops in the steady state and
> copy timeouts in the executor now avoided.
> 
> Before:
> ```
> vagrant@aurora:~$ docker info 2>/dev/null | grep -E "Storage|loop"
> Storage Driver: devicemapper
>  Data file: /dev/loop0
>  Metadata file: /dev/loop1
>  Data loop file: /var/lib/docker/devicemapper/devicemapper/data
>  Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
> vagrant@aurora:~$ time docker run --rm python:2.7 /usr/bin/python -c 
> "print('Hello Storage Driver')"
> Hello Storage Driver
> 
> real  0m1.053s
> user  0m0.007s
> sys   0m0.010s
> ```
> 
> After:
> ```
> vagrant@aurora:~$ docker info 2>/dev/null | grep Storage
> Storage Driver: aufs
> vagrant@aurora:~$ time docker run --rm python:2.7 /usr/bin/python -c 
> "print('Hello Storage Driver')"
> Hello Storage Driver
> 
> real  0m0.413s
> user  0m0.006s
> sys   0m0.012s
> ```
> 
> NB: In this test, the active ingredient is `--rm` which removes the
> container, engaging the storage driver in a serious way.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 52422: Improve docker perf in the Vagrant vm.

2016-09-30 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52422/#review151017
---


Ship it!




Ship It!

- Joshua Cohen


On Sept. 30, 2016, 2:15 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52422/
> ---
> 
> (Updated Sept. 30, 2016, 2:15 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1784
> https://issues.apache.org/jira/browse/AURORA-1784
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use the aufs storage driver for better disk io perf and eliminate a
> high timeout workaround for slow container image copies.
> 
>  examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout 
> | 1 -
>  examples/vagrant/provision-dev-cluster.sh   
> | 5 +++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> 
> Diffs
> -
> 
>   examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout 
> 108b54e5fa5e3229376cb7250272120b48b4089d 
>   examples/vagrant/provision-dev-cluster.sh 
> 7a35971c7c2df6346018439ef98505d786454c54 
> 
> Diff: https://reviews.apache.org/r/52422/diff/
> 
> 
> Testing
> ---
> 
> Greater than 2x speed improvement on file ops in the steady state and
> copy timeouts in the executor now avoided.
> 
> Before:
> ```
> vagrant@aurora:~$ docker info 2>/dev/null | grep -E "Storage|loop"
> Storage Driver: devicemapper
>  Data file: /dev/loop0
>  Metadata file: /dev/loop1
>  Data loop file: /var/lib/docker/devicemapper/devicemapper/data
>  Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
> vagrant@aurora:~$ time docker run --rm python:2.7 /usr/bin/python -c 
> "print('Hello Storage Driver')"
> Hello Storage Driver
> 
> real  0m1.053s
> user  0m0.007s
> sys   0m0.010s
> ```
> 
> After:
> ```
> vagrant@aurora:~$ docker info 2>/dev/null | grep Storage
> Storage Driver: aufs
> vagrant@aurora:~$ time docker run --rm python:2.7 /usr/bin/python -c 
> "print('Hello Storage Driver')"
> Hello Storage Driver
> 
> real  0m0.413s
> user  0m0.006s
> sys   0m0.012s
> ```
> 
> NB: In this test, the active ingredient is `--rm` which removes the
> container, engaging the storage driver in a serious way.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Review Request 52422: Improve docker perf in the Vagrant vm.

2016-09-30 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52422/
---

Review request for Aurora and Joshua Cohen.


Bugs: AURORA-1784
https://issues.apache.org/jira/browse/AURORA-1784


Repository: aurora


Description
---

Use the aufs storage driver for better disk io perf and eliminate a
high timeout workaround for slow container image copies.

 examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout | 
1 -
 examples/vagrant/provision-dev-cluster.sh   | 
5 +++--
 2 files changed, 3 insertions(+), 3 deletions(-)


Diffs
-

  examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout 
108b54e5fa5e3229376cb7250272120b48b4089d 
  examples/vagrant/provision-dev-cluster.sh 
7a35971c7c2df6346018439ef98505d786454c54 

Diff: https://reviews.apache.org/r/52422/diff/


Testing
---

Greater than 2x speed improvement on file ops in the steady state and
copy timeouts in the executor now avoided.

Before:
```
vagrant@aurora:~$ docker info 2>/dev/null | grep -E "Storage|loop"
Storage Driver: devicemapper
 Data file: /dev/loop0
 Metadata file: /dev/loop1
 Data loop file: /var/lib/docker/devicemapper/devicemapper/data
 Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
vagrant@aurora:~$ time docker run --rm python:2.7 /usr/bin/python -c 
"print('Hello Storage Driver')"
Hello Storage Driver

real0m1.053s
user0m0.007s
sys 0m0.010s
```

After:
```
vagrant@aurora:~$ docker info 2>/dev/null | grep Storage
Storage Driver: aufs
vagrant@aurora:~$ time docker run --rm python:2.7 /usr/bin/python -c 
"print('Hello Storage Driver')"
Hello Storage Driver

real0m0.413s
user0m0.006s
sys 0m0.012s
```

NB: In this test, the active ingredient is `--rm` which removes the
container, engaging the storage driver in a serious way.


Thanks,

John Sirois

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-30 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review151005
---


Ship it!




Master (655105d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 30, 2016, 10:08 a.m., JING CHEN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> ---
> 
> (Updated Sept. 30, 2016, 10:08 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
> https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Running task ssh without an instance should pick the random instance
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> d2233b67b37f8b34fae62372aa5d95e0a2e827b5 
> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> ---
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-30 Thread JING CHEN 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/
---

(Updated Sept. 30, 2016, 10:08 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

add a helper function to create _CommandOption_, add a new test case where 
getTaskStatus is called when instanceId is not specified in the query


Bugs: AURORA-1110
https://issues.apache.org/jira/browse/AURORA-1110


Repository: aurora


Description
---

Running task ssh without an instance should pick the random instance


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/options.py 
1245ff15a69a4b4347672f7b556985521e813a00 
  src/main/python/apache/aurora/client/cli/task.py 
a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
  src/test/python/apache/aurora/client/cli/test_task.py 
d2233b67b37f8b34fae62372aa5d95e0a2e827b5 

Diff: https://reviews.apache.org/r/52300/diff/


Testing
---

verified in vagrant


Thanks,

JING CHEN