Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 6, 2016, 9:16 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151636 --- This patch does not apply cleanly against master (5fc633c), do

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 6, 2016, 9:06 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 6, 2016, 9:10 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 6, 2016, 9:10 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 6, 2016, 11:14 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151639 --- This patch does not apply cleanly against master (5fc633c), do

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151640 --- Master (5fc633c) is green with this patch.

Re: Review Request 52610: Use the Thrift binary protocol in the Aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52610/#review151694 --- Ship it! Master (b417be3) is green with this patch.

Re: Review Request 52610: Use the Thrift binary protocol in the Aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52610/#review151707 --- Ship it! Ship It! - John Sirois On Oct. 6, 2016, 12:14

Review Request 52610: Use the Thrift binary protocol in the Aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52610/ --- Review request for Aurora, John Sirois and Zameer Manji. Repository: aurora

Re: Review Request 52609: Manually configure the private network interface in Vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52609/#review151705 --- I added myself as a reviewer since I'm running Vagrant 1.8.6.

Re: Review Request 52609: Manually configure the private network interface in Vagrant

> On Oct. 6, 2016, 1:10 p.m., John Sirois wrote: > > I added myself as a reviewer since I'm running Vagrant 1.8.6. I'll have > > time to confirm your issue and fix later today and have some feedback for > > you by tomorrow latest. I can confirm both the failure to autoprovision under 1.8.6

Re: Review Request 52609: Manually configure the private network interface in Vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52609/#review151692 --- Ship it! Master (b417be3) is green with this patch.

Re: Review Request 52610: Use the Thrift binary protocol in the Aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52610/#review151698 --- Ship it! Thanks for doing this. I'm glad to see that my

Re: Review Request 52609: Manually configure the private network interface in Vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52609/#review151714 --- Ship it! Ship It! - John Sirois On Oct. 6, 2016, 12:14

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/#review151684 --- Ship it! Ship It! - Joshua Cohen On Oct. 6, 2016, 4:26

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

> On Oct. 3, 2016, 12:22 p.m., Joshua Cohen wrote: > > I don't think that the registry to resolve against should be an argument to > > the docker helper, as this should likely be controlled by Aurora operators, > > not by Aurora users. When we originally discussed this, we talked about > >

Re: Review Request 52609: Manually configure the private network interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52609/ --- (Updated Oct. 6, 2016, 6:05 p.m.) Review request for Aurora. Repository:

Re: Review Request 52609: Manually configure the private network interface in Vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52609/ --- (Updated Oct. 6, 2016, 6:09 p.m.) Review request for Aurora. Summary

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151685 --- Can you add some tests for `CookieAuthModule`? I suspect this

Review Request 52609: Manually configure the private network interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52609/ --- Review request for Aurora. Repository: aurora Description --- I am not

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151674 --- Code looks much better now. Thanks for your effort.

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/#review151677 --- Master (fdb536a) is green with this patch.

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/ --- (Updated Oct. 6, 2016, 6:21 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 5, 2016, 7:52 p.m., Joshua Cohen wrote: > > Overall looks good to me. One question: the executor currently only > > supports RO volumes (everything is a bind mount). This is because [Mesos > > itself only supports RO > >

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

Just make them public and add a `@VisibleForTesting` annotation. We do this in many places to make the code testable. On Thu, Oct 6, 2016 at 2:55 PM, Pradyumna Kaushik wrote: > Correction, > > I need to create mocks of TaskGroups.java and TaskGroup.java and not >

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151750 --- Master (09b8e58) is red with this patch.

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 6, 2016, 2:52 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java, line 102 > > > > > > Update `scheduler-configuration.md` to pick up this new flag? > > Zameer

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151755 --- Ship it! lgtm modulo style issues from review bot and updating

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

> On Oct. 5, 2016, 10:52 p.m., Aurora ReviewBot wrote: > > Master (e91130e) is red with this patch. > > ./build-support/jenkins/build.sh > > > > > > org.apache.aurora.common.stats.RateTest > testZeroDelta FAILED > > java.lang.NoClassDefFoundError at RateTest.java:229 > >

Re: Review Request 52591: Remove untested classes that no longer exist.

> On Oct. 5, 2016, 9:51 p.m., Zameer Manji wrote: > > How did you determine this? Like so: ``` $ sed -r -e 's|\$.*||' -e 's|$|.java|' config/legacy_untested_classes.txt | sort -u | while read file; do test -f src/main/java/$file || echo "DNE: $file"; done DNE:

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/#review151668 --- Ship it! Ship It! - Stephan Erb On Okt. 6, 2016, 6:01

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/#review151670 --- Master (fdb536a) is green with this patch.

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/ --- (Updated Oct. 6, 2016, 10:26 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

> On Oct. 5, 2016, 10:52 p.m., Aurora ReviewBot wrote: > > Master (e91130e) is red with this patch. > > ./build-support/jenkins/build.sh > > > > > > org.apache.aurora.common.stats.RateTest > testZeroDelta FAILED > > java.lang.NoClassDefFoundError at RateTest.java:229 > >

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/ --- (Updated Oct. 6, 2016, 10:01 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

> On Oct. 5, 2016, 10:07 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java, > > line 29 > > > > > > Maybe we can remove the 'Twitter' reference here? Removed. -