Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/ --- (Updated Oct. 24, 2017, 12:09 a.m.) Review request for Aurora, David

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/ --- (Updated Oct. 24, 2017, midnight) Review request for Aurora, David McLaughlin

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Reza Motamedi
> On Oct. 23, 2017, 7:47 p.m., David McLaughlin wrote: > > ui/src/main/js/pages/Instance.js > > Line 34 (original), 38 (patched) > > > > > > enzyme allows you to update props, you can most likely test that when > >

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review188982 --- Ship it! Ship It! - Stephan Erb On Oct. 23, 2017, 4:14

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review188979 --- ui/src/main/js/pages/Instance.js Line 34 (original), 38

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189014 --- Ship it! Master (a673c5b) is green with this patch.

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review188977 --- Master (ec64011) is red with this patch.

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review188973 --- Master (ec64011) is red with this patch.

Review Request 63217: Update to shiro 1.2.5

2017-10-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63217/ --- Review request for Aurora, David McLaughlin and Stephan Erb. Repository:

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review188940 --- Ship it! Master (dbe9a52) is green with this patch.

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-23 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/ --- (Updated Oct. 23, 2017, 2:14 p.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 63217: Update to shiro 1.2.5

2017-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63217/#review188947 --- Master (063df5f) is red with this patch.

Re: Review Request 63197: Fix back button issue on Jobs page

2017-10-23 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63197/#review188948 --- Ship it! Ship It! - Kai Huang On Oct. 21, 2017, 1:34 a.m.,

Re: Review Request 63197: Fix back button issue on Jobs page

2017-10-23 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63197/#review188949 --- Ship it! Ship It! - Reza Motamedi On Oct. 21, 2017, 1:34

Re: Review Request 63217: Update to shiro 1.2.5

2017-10-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63217/#review188950 --- @ReviewBot retry - Bill Farner On Oct. 23, 2017, 7:36 a.m.,

Re: Review Request 63217: Update to shiro 1.2.5

2017-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63217/#review188939 --- Ship it! Master (dbe9a52) is green with this patch.

Re: Review Request 63217: Update to shiro 1.2.5

2017-10-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63217/#review188944 --- Ship it! Ship It! - Stephan Erb On Okt. 23, 2017, 4:36