Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/
---

(Updated April 9, 2015, 4:45 a.m.)


Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Repository: aurora


Description
---

Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
  
src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
 6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
  src/main/java/org/apache/aurora/scheduler/http/HttpService.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
50f377587ac05dbb72063ea02502e6d980148d3e 
  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
e03009c12de5a09761c1f444c6439ef3144b0b17 
  
src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
 21fd027976f75acc427c6d9265a7c7a91895d53d 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
  src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
7f80757cb40af7dde042f1d39355eadf2b3b1aee 
  src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
c5c5f789de6bf7693520081d0c1acc5165603242 
  
src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 
45a23fdc58ca7475a805c549463e87ddaa915e74 

Diff: https://reviews.apache.org/r/32806/diff/


Testing
---

Test suite + end-to-end tests.


Thanks,

Bill Farner

Re: Review Request 32861: Increase executor resource epsilon to match the minimum required by Mesos

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32861/#review79480
---

Ship it!


Ship It!

- Bill Farner


On April 8, 2015, 7:35 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32861/
> ---
> 
> (Updated April 8, 2015, 7:35 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1246
> https://issues.apache.org/jira/browse/AURORA-1246
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Increase executor resource epsilon to match the minimum required by Mesos.
> 
> Mesos issues warnings for executors with <32MB RAM. By increasing the epsilon 
> in Aurora, we shift some resources from the task to the executor. However, 
> the total resources per container remains constant.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> f55d1f4fff4724b0fb651b6f0dc10d2e8f62beff 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 8ae68653427c0bdbf33751d5ed4b74afcaf98a7b 
> 
> Diff: https://reviews.apache.org/r/32861/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 32806: Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.

[Bill Farner]

> On April 3, 2015, 9:13 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line 
> > 295
> > 
> >
> > +newline before

Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32806/#review78802
---


On April 3, 2015, 3:06 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32806/
> ---
> 
> (Updated April 3, 2015, 3:06 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove use of LocalServiceRegistry, simplify plumbing of HTTP address.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 5f6a019e4d6401e1efd075b72c049fa245cc0d0a 
>   
> src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
>  6d92ae3c8ec46e7964e81e507a2f2a7f2db68cfd 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 2af009d3d9ec44a70659225d0c18de9fda3a6f7a 
>   src/main/java/org/apache/aurora/scheduler/http/HttpService.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 50f377587ac05dbb72063ea02502e6d980148d3e 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> e03009c12de5a09761c1f444c6439ef3144b0b17 
>   
> src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
>  21fd027976f75acc427c6d9265a7c7a91895d53d 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> d212bbdf3c37be8e1e00eb169cf40b90fe69ed5f 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> c3e40d88fe7ee1a447d1d61980b69bd1b46881e7 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> 7f80757cb40af7dde042f1d39355eadf2b3b1aee 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> c5c5f789de6bf7693520081d0c1acc5165603242 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java
>  76cb691e6d7d4fada3a18fde73aceed7039bcaa4 
> 
> Diff: https://reviews.apache.org/r/32806/diff/
> 
> 
> Testing
> ---
> 
> Test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 32907: Generalizing preemption reservation pool.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32907/#review79470
---

Ship it!



src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java


Does this fail if the pending task was deleted?  It's probably fine to let 
expiration handle invalidation in that case, but just check that this doesn't 
NPE or similar.



src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java


"A bi-directional cache of items.  Entries are..."



src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java


Consider exposing a `size()` function on `BiCache` and pushing the stat up 
to alleaviate the need to plumb the stat name through.  At that point i think 
you can reasonably remove `BiCacheSettings` and inject just the expiry time.



src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java


Consider s/Iterable/Set/, or at least Collection here so you don't need to 
do Iterables.isEmpty at the call site.



src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java


Please document the justification for getting the last element.



src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java


Since the BiCache is completely controlled by TaskScheduler, consider using 
a real instance rather than a mock.  If this makes tests harder to write or 
read, though, don't bother.



src/test/java/org/apache/aurora/scheduler/async/preemptor/BiCacheTest.java


One more test case: key collision behavior with identical and different 
values



src/test/java/org/apache/aurora/scheduler/async/preemptor/BiCacheTest.java


Is there not a compiler warning on the lack of type witness on 
ImmutableSet.of()?


- Bill Farner


On April 6, 2015, 11:51 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32907/
> ---
> 
> (Updated April 6, 2015, 11:51 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1219
> https://issues.apache.org/jira/browse/AURORA-1219
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Current preemption model assumes tracking preemption slots/reservations by 
> taskId. This reduces preemption efficiency as it only takes a specific taskId 
> scheduling round to claim the PreemptionSlot and then subsequently make a 
> slave reservation. 
> 
> This diff generalizes the preemption pool by TaskGroupKey. Preemption slots 
> are now created and cached by TaskGroupKey and are available to _any_ task 
> from the same TaskGroup. 
> 
> This change should also simplify the algorithm in 
> https://reviews.apache.org/r/32597/.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> e87dda47a355654c66f6f54fb25a4d9a7f68422d 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> ebc520ebb4dddbc69b2b4a6f9174c1451d61887a 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
>  67ad5d7f9909bc892301c19586561b6cdbfe79e6 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotCache.java
>  b5a42a0a0498f06a382576e2c3a839bbb7f1d2b1 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
> 77617ec9a2bcd062d5b80cd2b4c58dc80514 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java
>  1092c055588363794b37a965fb2f17a6e50d92d7 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> c5643d9d99fc46d55fd6c48161230139fb7f12b8 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 88c0163170ebc25995d9ef8b1543335a4322bb8e 
>   src/test/java/org/apache/aurora/scheduler/async/preemptor/BiCacheTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java
>  bcd1b4e854f5ea227268c73156bc97c7c937c1de 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotCacheTest.java
>  80bd13a192bda64759b5a93749ec47ddfeae504a 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  281f4e02650727aa5d0a35a09dcf0eb823ad1b50 
> 
> Diff: h

Re: Review Request 32905: Remove factory.py

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32905/#review79469
---

Ship it!


Well done!


src/main/python/apache/aurora/admin/admin.py


Consider including the list of known clusters in this message 
(`CLUSTERS.keys()`)



src/test/python/apache/aurora/client/cli/test_api_from_cli.py


+4 indent.  here and elsewhere



src/test/python/apache/aurora/client/cli/test_context.py


Make this a one-liner


- Bill Farner


On April 7, 2015, 12:05 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32905/
> ---
> 
> (Updated April 7, 2015, 12:05 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch removes `src/main/python/apache/aurora/client/factory.py` which 
> was a pile of technical debt. By removing the indirection of creating client 
> object the code is much easier to understand. As a result of removing this 
> file many tests had to be touched because they were patching CLUSTERS via 
> factory.py. The need to patch CLUSTERS at each test site was removed and 
> replaced by modifying `AuroraClientCommandTest` to patch CLUSTERS before 
> running any test. This approach is required because 
> `FakeAuroraCommandContext` inherits from `AuroraCommandContext` which causes 
> the execute on import code in clusters.py to execute for each test.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/BUILD 
> 7a100d1a4a74aae034082f34db051c9cc31f8540 
>   src/main/python/apache/aurora/admin/admin.py 
> d9ed66c490d7d8351fd1b37b83ae82830a304b0b 
>   src/main/python/apache/aurora/client/BUILD 
> bf196bf86b36db0d72f8e096260c9a900f74d07c 
>   src/main/python/apache/aurora/client/cli/BUILD 
> ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
>   src/main/python/apache/aurora/client/cli/context.py 
> 51c7d24dca664e476e62f1864d095416dfab70e4 
>   src/main/python/apache/aurora/client/factory.py 
> 4b31e8503938a3f2af2c2d2a9a7c812cd489fa65 
>   src/test/python/apache/aurora/admin/test_admin_sla.py 
> 225251baf54f4f181855014ae501d3d91a59a1ad 
>   src/test/python/apache/aurora/client/BUILD 
> 831a72d39b27ca2aca466a38914bbf40ff94 
>   src/test/python/apache/aurora/client/cli/BUILD 
> e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> 78f21d2f20cf71fa2dfe0614885d44d2948decd2 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> c15e142930c9474c7873dd931261b6ab4eb5967f 
>   src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> 38629b63c082cf81cb891dace2a70d9e8f418e18 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> e3a366bf67074e50787394cad58d5e01359b641e 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 88fb9aec4d1eae6ad05da01752a670f902bafb1b 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> 92aefe612dd59df75188fd7fc8cf080c9a878dde 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> a1a3d8161ba747aa23a5e614e9ae31473d2058c1 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 721d9764190bdc4b1c5b65e416a039803b7c507c 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> 2580664ec913003e518b44a0278b8951b69e0504 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 8b7d11202b35deb09a248cfe0a96458fb70c 
>   src/test/python/apache/aurora/client/cli/util.py 
> 95a2123e127c9811fd2305e71cfc5c7c4376f904 
>   src/test/python/apache/aurora/client/test_factory.py PRE-CREATION 
>   src/test/python/apache/aurora/client/util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32905/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest src/test/python/apache/aurora/client/cli::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 32559: Add Kerberos support to the scheduler

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review79468
---

Ship it!



src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java


Do you care about the return value here?


- Bill Farner


On April 6, 2015, 5:56 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> ---
> 
> (Updated April 6, 2015, 5:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support authenticating to the scheduler API with Kerberos.
> 
> 
> Diffs
> -
> 
>   config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15 
>   examples/vagrant/provision-dev-cluster.sh 
> 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
>  1f773cab5100e960867b886d58fde963041be535 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  58b559e96402ef282dc0e5ac2de0930906256487 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java
>  PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 74b22f6226cd9de0cac0879bfdb102b3f780bc6e 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32559/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 32990: Improving JobUpdateDetails fetch performance.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32990/#review79467
---


Actually - can you add a benchmark to ThriftApiBenchmarks and include results 
in the description?  Should be pretty easy to prove the improvement of this.

- Bill Farner


On April 8, 2015, 9:45 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32990/
> ---
> 
> (Updated April 8, 2015, 9:45 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1263
> https://issues.apache.org/jira/browse/AURORA-1263
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Using event collections with "select" avoids unnecessary row explosion and 
> provdes subsecond execution time for a large job update that used to take 
> half a minute.
> 
> 
> Diffs
> -
> 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  4536cd35ffc231a5d2f6c1b5bf2aaa084ce3ad1d 
> 
> Diff: https://reviews.apache.org/r/32990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Manual testing in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 32990: Improving JobUpdateDetails fetch performance.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32990/#review79466
---

Ship it!


Great work!

- Bill Farner


On April 8, 2015, 9:45 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32990/
> ---
> 
> (Updated April 8, 2015, 9:45 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1263
> https://issues.apache.org/jira/browse/AURORA-1263
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Using event collections with "select" avoids unnecessary row explosion and 
> provdes subsecond execution time for a large job update that used to take 
> half a minute.
> 
> 
> Diffs
> -
> 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  4536cd35ffc231a5d2f6c1b5bf2aaa084ce3ad1d 
> 
> Diff: https://reviews.apache.org/r/32990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Manual testing in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 32993: Revert "Bump pants version to 0.0.32."

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32993/#review79465
---


Can you please file a ticket with your findings?  As it stands, there's likely 
to be another fateful victim in the future.

- Bill Farner


On April 8, 2015, 11:02 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32993/
> ---
> 
> (Updated April 8, 2015, 11:02 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This reverts commit 35f3e8daea815facccd1f5e577fe5a682bd02516. This reverts 
> pants to 0.0.28. After some extensive testing I have found some flakyness in 
> how pants 0.0.32 handles pants.ini options and it is best to revert it here 
> before debugging.
> 
> 
> Diffs
> -
> 
>   .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd 
> 
> Diff: https://reviews.apache.org/r/32993/diff/
> 
> 
> Testing
> ---
> 
> ./pants --print-exception-stacktrace test.pytest --no-fast src/test/python/::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 32993: Revert "Bump pants version to 0.0.32."

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32993/#review79446
---

Ship it!


Ship It!

- Joshua Cohen


On April 8, 2015, 11:02 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32993/
> ---
> 
> (Updated April 8, 2015, 11:02 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This reverts commit 35f3e8daea815facccd1f5e577fe5a682bd02516. This reverts 
> pants to 0.0.28. After some extensive testing I have found some flakyness in 
> how pants 0.0.32 handles pants.ini options and it is best to revert it here 
> before debugging.
> 
> 
> Diffs
> -
> 
>   .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd 
> 
> Diff: https://reviews.apache.org/r/32993/diff/
> 
> 
> Testing
> ---
> 
> ./pants --print-exception-stacktrace test.pytest --no-fast src/test/python/::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Review Request 32993: Revert "Bump pants version to 0.0.32."

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32993/
---

Review request for Aurora and Joshua Cohen.


Repository: aurora


Description
---

This reverts commit 35f3e8daea815facccd1f5e577fe5a682bd02516. This reverts 
pants to 0.0.28. After some extensive testing I have found some flakyness in 
how pants 0.0.32 handles pants.ini options and it is best to revert it here 
before debugging.


Diffs
-

  .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd 

Diff: https://reviews.apache.org/r/32993/diff/


Testing
---

./pants --print-exception-stacktrace test.pytest --no-fast src/test/python/::


Thanks,

Zameer Manji

Re: Review Request 32990: Improving JobUpdateDetails fetch performance.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32990/#review79441
---


Master (35f3e8d) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 8, 2015, 9:45 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32990/
> ---
> 
> (Updated April 8, 2015, 9:45 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1263
> https://issues.apache.org/jira/browse/AURORA-1263
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Using event collections with "select" avoids unnecessary row explosion and 
> provdes subsecond execution time for a large job update that used to take 
> half a minute.
> 
> 
> Diffs
> -
> 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  4536cd35ffc231a5d2f6c1b5bf2aaa084ce3ad1d 
> 
> Diff: https://reviews.apache.org/r/32990/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Manual testing in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 32990: Improving JobUpdateDetails fetch performance.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32990/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-1263
https://issues.apache.org/jira/browse/AURORA-1263


Repository: aurora


Description
---

Using event collections with "select" avoids unnecessary row explosion and 
provdes subsecond execution time for a large job update that used to take half 
a minute.


Diffs
-

  
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
 4536cd35ffc231a5d2f6c1b5bf2aaa084ce3ad1d 

Diff: https://reviews.apache.org/r/32990/diff/


Testing
---

./gradlew -Pq build
Manual testing in vagrant.


Thanks,

Maxim Khutornenko

Re: Review Request 32541: Adding client Kerberos support.

[Kevin Sweeney]

> On April 1, 2015, 1:40 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/cli/BUILD, line 29
> > 
> >
> > How about "kaurora"
> 
> Maxim Khutornenko wrote:
> This is a joke, right? :) If not I am really struggling how it would be 
> more informative.
> 
> Kevin Sweeney wrote:
> Some Kerberized tools have a convention of being prefixed with a "k" (su 
> => ksu, rsh => krsh, passwd => kpasswd). I think the ergonomics are better 
> (no underscores in command names), but don't feel strongly about it.
> 
> Maxim Khutornenko wrote:
> Since this isn't a command line tool, I'd rather keep the current name as 
> more descriptive.

It isn't? A python_binary target creates a command-line tool.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32541/#review78573
---


On April 2, 2015, 10:33 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32541/
> ---
> 
> (Updated April 2, 2015, 10:33 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-813
> https://issues.apache.org/jira/browse/AURORA-813
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> First take on client kerberos support. The idea is to repurpose the existing 
> auth_module system to support both legacy and kerberos during the deprecation 
> period. This way the 0.8.0 client will be able to talk to pre-0.8.0 scheduler 
> and use SessionKey-based authorization. Later (in 0.9.0), the payload() will 
> be removed along with SessionKey (AURORA-1229). That will let us get rid of 
> SchedulerProxy (or reduce it substantially). The auth_module might stay 
> though to support other auth plugins (e.g. requests-ntlm or 
> requests-oauthlib).
> 
> TODO: integration e2e tests once scheduler side lands.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 11a307cdb476ebcc25ab5c6b555bed29241ea988 
>   src/main/python/apache/aurora/client/api/__init__.py 
> a81329f6f947bbea4001c3a521c1923410a51eab 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 95e553427492407743dcac31d70f392a7c1bbc02 
>   src/main/python/apache/aurora/client/cli/BUILD 
> c6b4e8a09d1315cf5defee2155a6e0c697892a30 
>   src/main/python/apache/aurora/client/cli/client.py 
> 24516d114db1743cdf600c542a27fcf5b68053a0 
>   src/main/python/apache/aurora/common/auth/BUILD 
> 966484627dab90e7606f1fc638cd0e159aee3317 
>   src/main/python/apache/aurora/common/auth/__init__.py 
> 3119fd63d3dfa28f93f219b23030059580fed098 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> 5f4116ef4cfbc407e0c50dc938870fb14e2299b4 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 73a8e5cd51edf694b971cd2c298ff406aff8c6d7 
>   src/main/python/apache/aurora/common/auth/kerberos.py PRE-CREATION 
>   src/main/python/apache/aurora/common/transport.py 
> 395f8a94d9a27aad00166a17f2528a8c0833ffdd 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 0a6194831c332a96eab62b869c4e05cfa9def058 
>   src/test/python/apache/aurora/common/test_transport.py 
> b78e0b3badfbbeecefff7b5954f3796cef4da9d8 
> 
> Diff: https://reviews.apache.org/r/32541/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python:all
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 32559: Add Kerberos support to the scheduler

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review79427
---


Ping, wfarner

- Kevin Sweeney


On April 6, 2015, 10:56 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> ---
> 
> (Updated April 6, 2015, 10:56 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support authenticating to the scheduler API with Kerberos.
> 
> 
> Diffs
> -
> 
>   config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15 
>   examples/vagrant/provision-dev-cluster.sh 
> 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
>  1f773cab5100e960867b886d58fde963041be535 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  58b559e96402ef282dc0e5ac2de0930906256487 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java
>  PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 74b22f6226cd9de0cac0879bfdb102b3f780bc6e 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32559/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/#review79398
---



src/test/python/apache/aurora/executor/test_thermos_task_runner.py


Is this really necessary? IMHO, from the perspective of the runner, you can 
assume that the HttpSignaler class is tested and functioning correctly. Mocking 
the HttpSignaler should therfore be sufficient.


- Stephan Erb


On April 8, 2015, 5:51 p.m., Brian Brazil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32973/
> ---
> 
> (Updated April 8, 2015, 5:51 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add unittests for /quitquitquit.
> Fix name of test for sigterm being ignored.
> 
> Based on 
> https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
>   src/main/python/apache/aurora/common/http_signaler.py 
> 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 505a1e69ebfe1bd2fa74623063cb923ecff8a021 
>   src/main/python/apache/thermos/config/schema_base.py 
> f9143cc1b83143d6147f59d90c79435d055d0518 
>   src/test/python/apache/aurora/common/test_http_signaler.py 
> c6a21708eb997f213f4cca038891a84f6c5218d4 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 6b24bbb2ab7ca16f97961aabeed945b61e5b5908 
> 
> Diff: https://reviews.apache.org/r/32973/diff/
> 
> 
> Testing
> ---
> 
> Unittests and manually in vagrant cluster.
> 
> 
> Thanks,
> 
> Brian Brazil
> 
>

Re: Review Request 32912: Bump pants version to 0.0.32.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32912/#review79393
---

Ship it!


Ship It!

- Bill Farner


On April 7, 2015, 12:56 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32912/
> ---
> 
> (Updated April 7, 2015, 12:56 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Bump pants version to 0.0.32. From the [release 
> notes](http://pantsbuild.github.io/changelog.html) we get PEX improvements 
> and a bunch of python related bug fixes.
> 
> 
> Diffs
> -
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
> 
> Diff: https://reviews.apache.org/r/32912/diff/
> 
> 
> Testing
> ---
> 
> build-support/jenkins/build.sh
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/#review79364
---

Ship it!


Master (e8e1caa) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 8, 2015, 3:51 p.m., Brian Brazil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32973/
> ---
> 
> (Updated April 8, 2015, 3:51 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add unittests for /quitquitquit.
> Fix name of test for sigterm being ignored.
> 
> Based on 
> https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
>   src/main/python/apache/aurora/common/http_signaler.py 
> 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 505a1e69ebfe1bd2fa74623063cb923ecff8a021 
>   src/main/python/apache/thermos/config/schema_base.py 
> f9143cc1b83143d6147f59d90c79435d055d0518 
>   src/test/python/apache/aurora/common/test_http_signaler.py 
> c6a21708eb997f213f4cca038891a84f6c5218d4 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 6b24bbb2ab7ca16f97961aabeed945b61e5b5908 
> 
> Diff: https://reviews.apache.org/r/32973/diff/
> 
> 
> Testing
> ---
> 
> Unittests and manually in vagrant cluster.
> 
> 
> Thanks,
> 
> Brian Brazil
> 
>

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

[Brian Brazil]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/
---

(Updated April 8, 2015, 3:51 p.m.)


Review request for Aurora.


Changes
---

Clarify what type of http request.


Repository: aurora


Description
---

Add unittests for /quitquitquit.
Fix name of test for sigterm being ignored.

Based on 
https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34


Diffs (updated)
-

  docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
  src/main/python/apache/aurora/common/http_signaler.py 
531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
505a1e69ebfe1bd2fa74623063cb923ecff8a021 
  src/main/python/apache/thermos/config/schema_base.py 
f9143cc1b83143d6147f59d90c79435d055d0518 
  src/test/python/apache/aurora/common/test_http_signaler.py 
c6a21708eb997f213f4cca038891a84f6c5218d4 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
6b24bbb2ab7ca16f97961aabeed945b61e5b5908 

Diff: https://reviews.apache.org/r/32973/diff/


Testing
---

Unittests and manually in vagrant cluster.


Thanks,

Brian Brazil

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

[Brian Brazil]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/
---

(Updated April 8, 2015, 3:50 p.m.)


Review request for Aurora.


Changes
---

Expand docs per review


Repository: aurora


Description
---

Add unittests for /quitquitquit.
Fix name of test for sigterm being ignored.

Based on 
https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34


Diffs (updated)
-

  docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
  src/main/python/apache/aurora/common/http_signaler.py 
531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
505a1e69ebfe1bd2fa74623063cb923ecff8a021 
  src/main/python/apache/thermos/config/schema_base.py 
f9143cc1b83143d6147f59d90c79435d055d0518 
  src/test/python/apache/aurora/common/test_http_signaler.py 
c6a21708eb997f213f4cca038891a84f6c5218d4 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
6b24bbb2ab7ca16f97961aabeed945b61e5b5908 

Diff: https://reviews.apache.org/r/32973/diff/


Testing
---

Unittests and manually in vagrant cluster.


Thanks,

Brian Brazil

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

[Jay Buffington]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/#review79359
---



docs/configuration-reference.md


Can you also document that this is always on localhost and which port it 
uses?


- Jay Buffington


On April 8, 2015, 2:34 p.m., Brian Brazil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32973/
> ---
> 
> (Updated April 8, 2015, 2:34 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add unittests for /quitquitquit.
> Fix name of test for sigterm being ignored.
> 
> Based on 
> https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
>   src/main/python/apache/aurora/common/http_signaler.py 
> 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 505a1e69ebfe1bd2fa74623063cb923ecff8a021 
>   src/main/python/apache/thermos/config/schema_base.py 
> f9143cc1b83143d6147f59d90c79435d055d0518 
>   src/test/python/apache/aurora/common/test_http_signaler.py 
> c6a21708eb997f213f4cca038891a84f6c5218d4 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 6b24bbb2ab7ca16f97961aabeed945b61e5b5908 
> 
> Diff: https://reviews.apache.org/r/32973/diff/
> 
> 
> Testing
> ---
> 
> Unittests and manually in vagrant cluster.
> 
> 
> Thanks,
> 
> Brian Brazil
> 
>

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/#review79349
---

Ship it!


Master (e8e1caa) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 8, 2015, 2:34 p.m., Brian Brazil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32973/
> ---
> 
> (Updated April 8, 2015, 2:34 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add unittests for /quitquitquit.
> Fix name of test for sigterm being ignored.
> 
> Based on 
> https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
>   src/main/python/apache/aurora/common/http_signaler.py 
> 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 505a1e69ebfe1bd2fa74623063cb923ecff8a021 
>   src/main/python/apache/thermos/config/schema_base.py 
> f9143cc1b83143d6147f59d90c79435d055d0518 
>   src/test/python/apache/aurora/common/test_http_signaler.py 
> c6a21708eb997f213f4cca038891a84f6c5218d4 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 6b24bbb2ab7ca16f97961aabeed945b61e5b5908 
> 
> Diff: https://reviews.apache.org/r/32973/diff/
> 
> 
> Testing
> ---
> 
> Unittests and manually in vagrant cluster.
> 
> 
> Thanks,
> 
> Brian Brazil
> 
>

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

[Brian Brazil]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/
---

(Updated April 8, 2015, 2:34 p.m.)


Review request for Aurora.


Changes
---

Fix docs for /aaa


Repository: aurora


Description
---

Add unittests for /quitquitquit.
Fix name of test for sigterm being ignored.

Based on 
https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34


Diffs (updated)
-

  docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
  src/main/python/apache/aurora/common/http_signaler.py 
531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
505a1e69ebfe1bd2fa74623063cb923ecff8a021 
  src/main/python/apache/thermos/config/schema_base.py 
f9143cc1b83143d6147f59d90c79435d055d0518 
  src/test/python/apache/aurora/common/test_http_signaler.py 
c6a21708eb997f213f4cca038891a84f6c5218d4 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
6b24bbb2ab7ca16f97961aabeed945b61e5b5908 

Diff: https://reviews.apache.org/r/32973/diff/


Testing
---

Unittests and manually in vagrant cluster.


Thanks,

Brian Brazil

Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

[Brian Brazil]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/
---

Review request for Aurora.


Repository: aurora


Description
---

Add unittests for /quitquitquit.
Fix name of test for sigterm being ignored.

Based on 
https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34


Diffs
-

  docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
  src/main/python/apache/aurora/common/http_signaler.py 
531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
505a1e69ebfe1bd2fa74623063cb923ecff8a021 
  src/main/python/apache/thermos/config/schema_base.py 
f9143cc1b83143d6147f59d90c79435d055d0518 
  src/test/python/apache/aurora/common/test_http_signaler.py 
c6a21708eb997f213f4cca038891a84f6c5218d4 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
6b24bbb2ab7ca16f97961aabeed945b61e5b5908 

Diff: https://reviews.apache.org/r/32973/diff/


Testing
---

Unittests and manually in vagrant cluster.


Thanks,

Brian Brazil