Re: Review Request 35672: DbTaskStore perf: optimize queries scoped to a task ID.

2015-06-19 Thread Bill Farner
> On June 19, 2015, 11:50 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java, line 127 > > > > > > Curious, why special treating whitespacing here and not in other place

Re: Review Request 35672: DbTaskStore perf: optimize queries scoped to a task ID.

2015-06-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35672/#review88605 --- src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java (l

Re: Review Request 35587: Suppress task reconciliation status update logging.

2015-06-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/#review88604 --- Ship it! Master (d240926) is green with this patch. ./build-suppo

Re: Review Request 35672: DbTaskStore perf: optimize queries scoped to a task ID.

2015-06-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35672/#review88600 --- Master (d240926) is green with this patch. ./build-support/jenkins

Review Request 35672: DbTaskStore perf: optimize queries scoped to a task ID.

2015-06-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35672/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1298 https://

Re: Review Request 35587: Suppress task reconciliation status update logging.

2015-06-19 Thread Maxim Khutornenko
> On June 18, 2015, 4:42 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java, > > line 314 > > > > > > What's being tested here? If i'm reading correctly, this tes

Re: Review Request 35587: Suppress task reconciliation status update logging.

2015-06-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/ --- (Updated June 19, 2015, 10:07 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35613: Fixing broken gradle dependency scanner.

2015-06-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/#review88565 --- Ship it! Master (589d901) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88562 --- Ship it! Master (589d901) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88552 --- Loogs great overall! Just a few nits/suggestions. src/main/java/or

Re: Review Request 35613: Fixing broken gradle dependency scanner.

2015-06-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/#review88550 --- @ReviewBot retry - Maxim Khutornenko On June 18, 2015, 10:12 p.m.

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 19, 2015, 5:23 p.m.) Review request for Aurora, Kevin Sweeney and