Re: Review Request 36392: Improve diff output of aurora cli.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/ --- (Updated July 14, 2015, 12:31 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Repository: aurora Description --- Use json.dumps to pretty print the executor config, and munge it to look right and not get messed with by the general pretty printer. Show newlines directly so that multi-line cmdlines look right. Make DIFF_VIEWER work for things like diff -u10 Diffs (updated) - src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37 src/test/python/apache/aurora/client/cli/test_diff.py da52105b5c77419ff64e15a30a04f997f9216a7e Diff: https://reviews.apache.org/r/36392/diff/ Testing --- Tested in vargant environment. Thanks, Brian Brazil
Re: Review Request 36392: Improve diff output of aurora cli.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/#review91611 --- Ship it! Master (1a01a5b) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On July 14, 2015, 12:51 p.m., Brian Brazil wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36392/ --- (Updated July 14, 2015, 12:51 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Repository: aurora Description --- Use json.dumps to pretty print the executor config, and munge it to look right and not get messed with by the general pretty printer. Show newlines directly so that multi-line cmdlines look right. Make DIFF_VIEWER work for things like diff -u10 Diffs - src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37 src/test/python/apache/aurora/client/cli/test_diff.py da52105b5c77419ff64e15a30a04f997f9216a7e Diff: https://reviews.apache.org/r/36392/diff/ Testing --- Tested in vargant environment. Thanks, Brian Brazil
Re: Review Request 36478: Client: when waiting for a job update, use helpful exit codes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36478/ --- (Updated July 14, 2015, 8:37 p.m.) Review request for Aurora and Zameer Manji. Changes --- Rebase. Bugs: AURORA-1399 https://issues.apache.org/jira/browse/AURORA-1399 Repository: aurora Description --- Client: when waiting for a job update, use helpful exit codes. Diffs (updated) - src/main/python/apache/aurora/client/cli/update.py 2dcc8f3c38dc7b9ea3cfe97d6066600a578f75bb src/test/python/apache/aurora/client/cli/test_supdate.py 2d7d49622592deef7392f2276b7eaebdd5e5e404 Diff: https://reviews.apache.org/r/36478/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 36478: Client: when waiting for a job update, use helpful exit codes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36478/#review91664 --- Ship it! Master (5c4c42c) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On July 14, 2015, 8:37 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36478/ --- (Updated July 14, 2015, 8:37 p.m.) Review request for Aurora and Zameer Manji. Bugs: AURORA-1399 https://issues.apache.org/jira/browse/AURORA-1399 Repository: aurora Description --- Client: when waiting for a job update, use helpful exit codes. Diffs - src/main/python/apache/aurora/client/cli/update.py 2dcc8f3c38dc7b9ea3cfe97d6066600a578f75bb src/test/python/apache/aurora/client/cli/test_supdate.py 2d7d49622592deef7392f2276b7eaebdd5e5e404 Diff: https://reviews.apache.org/r/36478/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 36490: Use ProviderOptionalSubject instead of optional injection for Shiro audit logging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36490/ --- (Updated July 14, 2015, 4:48 p.m.) Review request for Aurora and Bill Farner. Summary (updated) - Use ProviderOptionalSubject instead of optional injection for Shiro audit logging. Bugs: AURORA-1352 https://issues.apache.org/jira/browse/AURORA-1352 Repository: aurora Description (updated) --- Use injection of an optional value instead of optional injection. Diffs - src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java f547c4485eab97e4fe149eec9fa73af3ce807748 src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java a3b0a6bd573f04ff275a54b16f0ab5ebf139868e src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 63917363f392e6d970fb7e0cb91b840ca5db173e src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 Diff: https://reviews.apache.org/r/36490/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 36492: Use aurora.local as hostname.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36492/#review91691 --- Ship it! Master (d9dac92) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On July 14, 2015, 11:56 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36492/ --- (Updated July 14, 2015, 11:56 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Use aurora.local as hostname. Diffs - examples/vagrant/provision-dev-cluster.sh 853ccac35f2befa31716a9ed686df650cd913c90 examples/vagrant/upstart/aurora-scheduler-kerberos.conf 85052ac8e4dde85fbcd85ce839d0647f5632d74b examples/vagrant/upstart/aurora-scheduler.conf 1c2390f0248e91e65a548e67f6af1be8d2526b0a Diff: https://reviews.apache.org/r/36492/diff/ Testing --- end-to-end test gets past service discovery errors. Thanks, Kevin Sweeney
Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91701 --- Ship it! Master (d9dac92) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On July 15, 2015, 12:30 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 15, 2015, 12:30 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1096 https://issues.apache.org/jira/browse/AURORA-1096 Repository: aurora Description --- Prevent job updates from allowing unbounded instance events Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Review Request 36490: wip
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36490/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1352 https://issues.apache.org/jira/browse/AURORA-1352 Repository: aurora Description --- Use ProviderOptionalSubject instead of @Nullable ProviderSubject. Diffs - src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java f547c4485eab97e4fe149eec9fa73af3ce807748 src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java a3b0a6bd573f04ff275a54b16f0ab5ebf139868e src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 63917363f392e6d970fb7e0cb91b840ca5db173e src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 Diff: https://reviews.apache.org/r/36490/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 36492: Use aurora.local as hostname.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36492/#review91693 --- Ship it! Ship It! - Bill Farner On July 14, 2015, 11:56 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36492/ --- (Updated July 14, 2015, 11:56 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Use aurora.local as hostname. Diffs - examples/vagrant/provision-dev-cluster.sh 853ccac35f2befa31716a9ed686df650cd913c90 examples/vagrant/upstart/aurora-scheduler-kerberos.conf 85052ac8e4dde85fbcd85ce839d0647f5632d74b examples/vagrant/upstart/aurora-scheduler.conf 1c2390f0248e91e65a548e67f6af1be8d2526b0a Diff: https://reviews.apache.org/r/36492/diff/ Testing --- end-to-end test gets past service discovery errors. Thanks, Kevin Sweeney
Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
On July 14, 2015, 10:55 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, lines 168-177 https://reviews.apache.org/r/36436/diff/2/?file=1010206#file1010206line168 Have you considered a single arg for the upper bound of instance events that are allowed for a job update? I think this would be easier for the operator to reason about, and simpler to associate directly to DB impact. Good idea, and much simpler. Let me know what you think of the implementation. Thanks! - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91645 --- On July 13, 2015, 4:10 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 13, 2015, 4:10 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1096 https://issues.apache.org/jira/browse/AURORA-1096 Repository: aurora Description --- Prevent job updates from allowing unbounded instance events Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 14, 2015, 5:30 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1096 https://issues.apache.org/jira/browse/AURORA-1096 Repository: aurora Description --- Prevent job updates from allowing unbounded instance events Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 36490: Use ProviderOptionalSubject instead of optional injection for Shiro audit logging.
On July 14, 2015, 4:52 p.m., Aurora ReviewBot wrote:
Master (d9dac92) is red with this patch.
./build-support/jenkins/build.sh
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java:136:
error: incompatible types: no instance(s) of type variable(s) T exist so
that OptionalT conforms to ? extends OptionalSubject
bind(new TypeLiteralOptionalSubject()
{}).toProvider(Optional::empty);
^
where T is a type-variable:
T extends Object declared in method Tempty()
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java:143:
error: no suitable method found for toProvider(SecurityUt[...]bject)
bind(Subject.class).toProvider(SecurityUtils::getSubject).in(RequestScoped.class);
^
method LinkedBindingBuilder.toProvider(com.google.inject.Provider?
extends Subject) is not applicable
(argument mismatch; bad return type in method reference
Subject cannot be converted to ? extends Subject)
method LinkedBindingBuilder.toProvider(Class? extends
javax.inject.Provider? extends Subject) is not applicable
(argument mismatch; Class is not a functional interface)
method LinkedBindingBuilder.toProvider(TypeLiteral? extends
javax.inject.Provider? extends Subject) is not applicable
(argument mismatch; TypeLiteral is not a functional interface)
method LinkedBindingBuilder.toProvider(Key? extends
javax.inject.Provider? extends Subject) is not applicable
(argument mismatch; Key is not a functional interface)
Note: Some messages have been simplified; recompile with -Xdiags:verbose to
get full output
2 errors
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or
--debug option to get more log output.
BUILD FAILED
Total time: 1 mins 33.58 secs
I will refresh this build result if you post a review containing
@ReviewBot retry
This looks like: https://bugs.openjdk.java.net/browse/JDK-8051402
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/#review91683
---
On July 14, 2015, 4:48 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/
---
(Updated July 14, 2015, 4:48 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352
Repository: aurora
Description
---
Use injection of an optional value instead of optional injection.
Diffs
-
src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java
f547c4485eab97e4fe149eec9fa73af3ce807748
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
a3b0a6bd573f04ff275a54b16f0ab5ebf139868e
src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java
63917363f392e6d970fb7e0cb91b840ca5db173e
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh
6e4a294d6ca7ffd3a733498211e66ad674ef0b39
Diff: https://reviews.apache.org/r/36490/diff/
Testing
---
./gradlew build
Thanks,
Kevin Sweeney
Re: Review Request 36478: Client: when waiting for a job update, use helpful exit codes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36478/#review91640 --- Ship it! Master (1a01a5b) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On July 14, 2015, 5:27 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36478/ --- (Updated July 14, 2015, 5:27 p.m.) Review request for Aurora and Zameer Manji. Bugs: AURORA-1399 https://issues.apache.org/jira/browse/AURORA-1399 Repository: aurora Description --- Client: when waiting for a job update, use helpful exit codes. Diffs - src/main/python/apache/aurora/client/cli/update.py 70f6c69aa9226981c66c0f986fd53840c56d210f src/test/python/apache/aurora/client/cli/test_supdate.py c6b6ccc8570bac9c742e6458a9d09e24aa0a3bcc Diff: https://reviews.apache.org/r/36478/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91645 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (lines 168 - 177) https://reviews.apache.org/r/36436/#comment145170 Have you considered a single arg for the upper bound of instance events that are allowed for a job update? I think this would be easier for the operator to reason about, and simpler to associate directly to DB impact. - Bill Farner On July 13, 2015, 11:10 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 13, 2015, 11:10 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1096 https://issues.apache.org/jira/browse/AURORA-1096 Repository: aurora Description --- Prevent job updates from allowing unbounded instance events Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 36478: Client: when waiting for a job update, use helpful exit codes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36478/#review91653 --- Ship it! Ship It! - Zameer Manji On July 14, 2015, 10:27 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36478/ --- (Updated July 14, 2015, 10:27 a.m.) Review request for Aurora and Zameer Manji. Bugs: AURORA-1399 https://issues.apache.org/jira/browse/AURORA-1399 Repository: aurora Description --- Client: when waiting for a job update, use helpful exit codes. Diffs - src/main/python/apache/aurora/client/cli/update.py 70f6c69aa9226981c66c0f986fd53840c56d210f src/test/python/apache/aurora/client/cli/test_supdate.py c6b6ccc8570bac9c742e6458a9d09e24aa0a3bcc Diff: https://reviews.apache.org/r/36478/diff/ Testing --- Thanks, Bill Farner
Review Request 36478: Client: when waiting for a job update, use helpful exit codes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36478/ --- Review request for Aurora and Zameer Manji. Bugs: AURORA-1399 https://issues.apache.org/jira/browse/AURORA-1399 Repository: aurora Description --- Client: when waiting for a job update, use helpful exit codes. Diffs - src/main/python/apache/aurora/client/cli/update.py 70f6c69aa9226981c66c0f986fd53840c56d210f src/test/python/apache/aurora/client/cli/test_supdate.py c6b6ccc8570bac9c742e6458a9d09e24aa0a3bcc Diff: https://reviews.apache.org/r/36478/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 36063: Make e2e test fail when a command fails.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36063/#review91643 --- Kevin - is this ready to land? - Bill Farner On June 30, 2015, 8:10 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36063/ --- (Updated June 30, 2015, 8:10 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1378 https://issues.apache.org/jira/browse/AURORA-1378 Repository: aurora Description --- Make e2e test fail correctly. This doesn't fix the test (still investigating the root cause there), but causes it to be properly broken. Diffs - src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 79377c387232269094029314b677afeb21ee46ea Diff: https://reviews.apache.org/r/36063/diff/ Testing --- ``` + + grep -q 'shiro_audit_logging_enabled 1' + curl -s localhost:8081/vars + tear_down 1 + local retcode=1 + sudo cp /vagrant/examples/vagrant/clusters.json /etc/aurora/clusters.json + sudo stop aurora-scheduler-kerberos aurora-scheduler-kerberos stop/waiting + sudo rm -f /etc/init/aurora-scheduler-kerberos.conf + sudo start aurora-scheduler aurora-scheduler start/running, process 13559 + [[ 1 -ne 0 ]] + echo + echo '!!! FAILED' !!! FAILED + echo ``` Thanks, Kevin Sweeney
