---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/
---
(Updated July 15, 2015, 5:46 p.m.)
Review request for Aurora.
Bugs:
On July 15, 2015, 8:27 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java,
lines 143-155
https://reviews.apache.org/r/36490/diff/1/?file=1011891#file1011891line143
Is the `Subject` - `OptionalSubject` layering necessary?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/
---
(Updated July 15, 2015, 11:21 a.m.)
Review request for Aurora and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36436/#review91749
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/#review91755
---
Ship it!
Master (d9dac92) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/
---
(Updated July 15, 2015, 5:48 p.m.)
Review request for Aurora.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/
---
(Updated July 15, 2015, 11:34 a.m.)
Review request for Aurora and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/#review91788
---
Ship it!
Ship It!
- Zameer Manji
On July 15, 2015, 10:50 a.m.,
On July 15, 2015, 12:08 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, lines
87-115
https://reviews.apache.org/r/36289/diff/2/?file=1011920#file1011920line87
In this change, we cannot remove these arguments as it breaks
On Wed, Jul 15, 2015 at 12:13 PM, Kevin Sweeney kevi...@apache.org wrote:
On July 15, 2015, 12:08 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java,
lines 87-115
https://reviews.apache.org/r/36289/diff/2/?file=1011920#file1011920line87
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/#review91791
---
Ship it!
Master (e63c518) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36289/#review91793
---
Stopped at parsing code, since i belive it can be made quite a bit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36436/
---
(Updated July 15, 2015, 11:08 a.m.)
Review request for Aurora and Bill Farner.
On July 15, 2015, 9:50 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 169
https://reviews.apache.org/r/36436/diff/3/?file=1011900#file1011900line169
For better readability, how about `max_update_instance_failures`?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/#review91775
---
Ship it!
Thank you - I was not aware of the restriction against
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/#review91780
---
Ship it!
LGTM. I talked through this change with Andrew in IRC
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36436/#review91786
---
Ship it!
Master (d9dac92) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36436/
---
(Updated July 15, 2015, 1:23 p.m.)
Review request for Aurora and Bill Farner.
On July 15, 2015, 11:47 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
lines 168-169
https://reviews.apache.org/r/36436/diff/4/?file=1012829#file1012829line168
Sorry, i made that suggestion before i added the comment to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36526/
---
Review request for Aurora and Bill Farner.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36526/#review91825
---
Ship it!
Master (545e839) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/#review91745
---
Ship it!
LGTM once the bot reports a green build.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/#review91746
---
Master (d9dac92) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36392/#review91739
---
Ship it!
- Bill Farner
On July 14, 2015, 12:51 p.m., Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/#review91741
---
@ReviewBot retry
1.8_45 should now be on jenkins slaves, trying
25 matches
Mail list logo
