Re: Review Request 38039: Remove ExceptionalClosure interface.

2015-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38039/#review97397 --- Master (64c00f1) is red with this patch. ./build-support/jenkins/b

Re: Review Request 38039: Remove ExceptionalClosure interface.

2015-09-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38039/#review97392 --- Ship it! Ship It! - Bill Farner On Sept. 1, 2015, 8:38 p.m., Zam

Review Request 38039: Remove ExceptionalClosure interface.

2015-09-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38039/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 38038: Use guava replacement for ExecutorServiceShutdown.

2015-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38038/#review97391 --- Ship it! Master (07838c3) is green with this patch. ./build-suppo

Re: Review Request 38038: Use guava replacement for ExecutorServiceShutdown.

2015-09-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38038/#review97390 --- Ship it! I'm not on the people line but this change LGTM. - Zameer

Review Request 38038: Use guava replacement for ExecutorServiceShutdown.

2015-09-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38038/ --- Review request for Aurora. Repository: aurora Description --- Use guava

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/#review97389 --- Ship it! Master (07838c3) is green with this patch. ./build-suppo

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-01 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/ --- (Updated Sept. 2, 2015, 2:35 a.m.) Review request for Aurora. Changes ---

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Bill Farner
> On Aug. 31, 2015, 4:31 p.m., Bill Farner wrote: > > examples/vagrant/upstart/mesos-slave.conf, line 38 > > > > > > any reason for the verbosity? Why not just 'fixed_estimator' or > > something equally brief? > >

Re: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

2015-09-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38010/#review97384 --- Ship it! Ship It! - Bill Farner On Sept. 1, 2015, 10:29 a.m., Jo

Re: Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Bill Farner
> On Sept. 1, 2015, 12:10 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/GuavaUtils.java, lines 114-124 > > > > > > Rather than change the purpose of this class from a dumb adapter that > > makes `Se

Re: Review Request 38018: Fix link to update page for the update list.

2015-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38018/#review97342 --- Master (5a7bd34) is green with this patch. ./build-support/jenkins

Re: Review Request 38018: Fix link to update page for the update list.

2015-09-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38018/#review97340 --- Ship it! Ship It! - Zameer Manji On Sept. 1, 2015, 2:27 p.m., Jo

Review Request 38018: Fix link to update page for the update list.

2015-09-01 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38018/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --

Re: Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review97322 --- src/main/java/org/apache/aurora/GuavaUtils.java (lines 114 - 124) <

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97325 --- Ship it! Master (5a7bd34) is green with this patch. ./build-suppo

Re: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

2015-09-01 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38010/#review97323 --- Ship it! Ship It! - David McLaughlin On Sept. 1, 2015, 5:29 p.m.

Re: Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review97321 --- Ship it! Master (5a7bd34) is green with this patch. ./build-suppo

Re: Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 1, 2015, 11:59 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review97319 --- Reviewer notes commons/src/main/java/org/apache/aurora/common/appl

Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Repository: aurora

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97315 --- @ReviewBot retry - Maxim Khutornenko On Sept. 1, 2015, 5:15 p.m.,

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-01 Thread Renan DelValle
> On Sept. 1, 2015, 2:35 a.m., Bill Farner wrote: > > examples/vagrant/executors-config.json, line 1 > > > > > > Can you expand this example to include the command executor? That's > > likely to be the first non-defa

Re: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

2015-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38010/#review97310 --- Master (5a7bd34) is green with this patch. ./build-support/jenkins

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97308 --- Master (f285647) is red with this patch. ./build-support/jenkins/b

Re: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

2015-09-01 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38010/ --- (Updated Sept. 1, 2015, 5:29 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

2015-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38010/#review97307 --- Master (f285647) is red with this patch. ./build-support/jenkins/b

Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

2015-09-01 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38010/ --- Review request for Aurora, David McLaughlin and Bill Farner. Repository: aurora

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/ --- (Updated Sept. 1, 2015, 5:15 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 37926: Adding oversubscription e2e tests.

2015-09-01 Thread Maxim Khutornenko
> On Aug. 31, 2015, 11:31 p.m., Bill Farner wrote: > > examples/vagrant/upstart/mesos-slave.conf, line 38 > > > > > > any reason for the verbosity? Why not just 'fixed_estimator' or > > something equally brief? Thi