Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Aurora ReviewBot
: debug1: Entering interactive session. > 192.168.33.7: debug1: Sending environment. > 192.168.33.7: debug1: Sending env LANG = en_US.UTF-8 > 192.168.33.7: debug1: Sending env LC_CTYPE = en_US.UTF-8 > 192.168.33.7: debug1: Sending command: cd > /var/lib/mesos/slaves/*/fr

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Maxim Khutornenko
92.168.33.7: Authenticated to 192.168.33.7 ([192.168.33.7]:22). > 192.168.33.7: debug1: channel 0: new [client-session] > 192.168.33.7: debug1: Requesting no-more-sessi...@openssh.com > 192.168.33.7: debug1: Entering interactive session. > 192.168.33.7: de

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Bill Farner
penssh.com > 192.168.33.7: debug1: Entering interactive session. > 192.168.33.7: debug1: Sending environment. > 192.168.33.7: debug1: Sending env LANG = en_US.UTF-8 > 192.168.33.7: debug1: Sending env LC_CTYPE = en_US.UTF-8 > 192.168.33.7: debug1: Sending comma

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Maxim Khutornenko
environment. > 192.168.33.7: debug1: Sending env LANG = en_US.UTF-8 > 192.168.33.7: debug1: Sending env LC_CTYPE = en_US.UTF-8 > 192.168.33.7: debug1: Sending command: cd > /var/lib/mesos/slaves/*/frameworks/*/executors/thermos-1442013544190-www-data-prod-hello-0-fe7fa2f

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review98714 --- api/src/main/thrift/org/apache/aurora/gen/storage.thrift (lines 130

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-11 Thread Zeke Harris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review98712 --- Ship it! LGTM src/test/java/org/apache/aurora/scheduler/storage/b

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Bill Farner
sessi...@openssh.com > 192.168.33.7: debug1: Entering interactive session. > 192.168.33.7: debug1: Sending environment. > 192.168.33.7: debug1: Sending env LANG = en_US.UTF-8 > 192.168.33.7: debug1: Sending env LC_CTYPE = en_US.UTF-8 > 192.168.33.7: debug1: Sending command: cd > /

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Maxim Khutornenko
ring interactive session. > 192.168.33.7: debug1: Sending environment. > 192.168.33.7: debug1: Sending env LANG = en_US.UTF-8 > 192.168.33.7: debug1: Sending env LC_CTYPE = en_US.UTF-8 > 192.168.33.7: debug1: Sending command: cd > /var/lib/mesos/slaves/*/frameworks/*/ex

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Bill Farner
168.33.7: debug1: Sending environment. > 192.168.33.7: debug1: Sending env LANG = en_US.UTF-8 > 192.168.33.7: debug1: Sending env LC_CTYPE = en_US.UTF-8 > 192.168.33.7: debug1: Sending command: cd > /var/lib/mesos/slaves/*/frameworks/*/executors/thermos-144201354

Re: Review Request 38315: Change ZooKeeperTestServer to not rely on ShutdownRegistry.

2015-09-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38315/#review98707 --- Ship it! Master (ec02a49) is green with this patch. ./build-suppo

Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Maxim Khutornenko
192.168.33.7: checkpoints 192.168.33.7: __main__.log 192.168.33.7: sandbox 192.168.33.7: stderr 192.168.33.7: stdout 192.168.33.7: task.json 192.168.33.7: thermos_executor.pex 192.168.33.7: thermos_runner.aurora.root.log.DEBUG.20150911-231905.16314 192.168.33.7: thermos_runner.aurora.

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review98705 --- Ship it! Master (ec02a49) is green with this patch. ./build-suppo

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-11 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- (Updated Sept. 11, 2015, 4:06 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-11 Thread Joe Smith
> On Sept. 10, 2015, 5:50 p.m., Zameer Manji wrote: > > .gitignore, line 14 > > > > > > The gradle task seems to be writing `build.properties` to `dist/` is > > this needed? Totally correct, thanks! > On Sept. 10,

Re: Review Request 38315: Change ZooKeeperTestServer to not rely on ShutdownRegistry.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38315/ --- (Updated Sept. 11, 2015, 3:28 p.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 38315: Change ZooKeeperTestServer to not rely on ShutdownRegistry.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38315/ --- (Updated Sept. 11, 2015, 2:12 p.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 38315: Change ZooKeeperTestServer to not rely on ShutdownRegistry.

2015-09-11 Thread Bill Farner
> On Sept. 11, 2015, 1:52 p.m., Zameer Manji wrote: > > commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java, > > line 96 > > > > > > Shouldn't we log this instead of printing it? Doh, this sh

Re: Review Request 38315: Change ZooKeeperTestServer to not rely on ShutdownRegistry.

2015-09-11 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38315/#review98684 --- Ship it! commons/src/main/java/org/apache/aurora/common/applicatio

Re: Review Request 38316: Tweak README to make bug filing instructions easier to find. Also update JDK requirement to 1.8.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38316/#review98686 --- Ship it! Ship It! - Bill Farner On Sept. 11, 2015, 1:42 p.m., Jo

Review Request 38316: Tweak README to make bug filing instructions easier to find. Also update JDK requirement to 1.8.

2015-09-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38316/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1489 https://issues

Review Request 38315: Change ZooKeeperTestServer to not rely on ShutdownRegistry.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38315/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --

Re: Review Request 38313: Showing all resource consumption details in the UI

2015-09-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38313/#review98680 --- Ship it! Ship It! - Joshua Cohen On Sept. 11, 2015, 6:55 p.m., M

Re: Review Request 38313: Showing all resource consumption details in the UI

2015-09-11 Thread Maxim Khutornenko
> On Sept. 11, 2015, 6:59 p.m., Joshua Cohen wrote: > > File Attachment: resources.png - resources.png > > > > > > Couple of suggestions on this format: > > > > 1) what do you think about moving the unit into the header, rather than >

Re: Review Request 38313: Showing all resource consumption details in the UI

2015-09-11 Thread Joshua Cohen
> On Sept. 11, 2015, 6:59 p.m., Joshua Cohen wrote: > > File Attachment: resources.png - resources.png > > > > > > Couple of suggestions on this format: > > > > 1) what do you think about moving the unit into the header, rather than >

Re: Review Request 38313: Showing all resource consumption details in the UI

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38313/#review98666 --- Ship it! Ship It! - Bill Farner On Sept. 11, 2015, 11:55 a.m., M

Re: Review Request 38313: Showing all resource consumption details in the UI

2015-09-11 Thread Bill Farner
> On Sept. 11, 2015, 11:59 a.m., Joshua Cohen wrote: > > File Attachment: resources.png - resources.png > > > > > > Couple of suggestions on this format: > > > > 1) what do you think about moving the unit into the header, rather than

Re: Review Request 38313: Showing all resource consumption details in the UI

2015-09-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38313/#review98664 --- File Attachment: resources.png - resources.png

Review Request 38313: Showing all resource consumption details in the UI

2015-09-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38313/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora D

Re: Review Request 38302: Replace incorrect/misleading use of constraints with best practices doc.

2015-09-11 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38302/#review98648 --- Ship it! Ship It! - Zameer Manji On Sept. 11, 2015, 8:46 a.m., B

Re: Review Request 38277: Adjusting /utilization and client to show correct consumption.

2015-09-11 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38277/#review98649 --- Ship it! Ship It! - Zameer Manji On Sept. 10, 2015, 4:19 p.m., M

Re: Review Request 38302: Replace incorrect/misleading use of constraints with best practices doc.

2015-09-11 Thread Zameer Manji
> On Sept. 11, 2015, 10:54 a.m., Zameer Manji wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora, line 32 > > > > > > Why did you delete this? This is needed so the `stage_server` process >

Re: Review Request 38302: Replace incorrect/misleading use of constraints with best practices doc.

2015-09-11 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38302/#review98646 --- src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora

Re: Review Request 38277: Adjusting /utilization and client to show correct consumption.

2015-09-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38277/#review98635 --- Ship it! Ship It! - Joshua Cohen On Sept. 10, 2015, 11:19 p.m.,

Re: Review Request 38309: Properly hide the job dashboard link if no dashboard link is configured.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38309/#review98631 --- Ship it! Thanks! - Bill Farner On Sept. 11, 2015, 10:31 a.m., Jo

Review Request 38309: Properly hide the job dashboard link if no dashboard link is configured.

2015-09-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38309/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 38014: Remove StartupRegistry.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 11, 2015, 10:29 a.m.) Review request for Aurora, Kevin Sweeney a

Re: Review Request 38014: Remove StartupRegistry.

2015-09-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98627 --- This patch does not apply cleanly on master (1230029), do you need t

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-11 Thread Joshua Cohen
> On Sept. 11, 2015, 7:55 a.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/breadcrumb.html, line 35 > > > > > > The title is rather specific and might not match what people outside of > > Twitter use

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38270/ --- (Updated Sept. 11, 2015, 5:07 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 38288: Revert "Revert "Refer to shared task_configs table for job updates.""

2015-09-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38288/#review98624 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 11, 2015, 3:57 a.

Re: Review Request 38014: Remove StartupRegistry.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 11, 2015, 10:02 a.m.) Review request for Aurora, Kevin Sweeney a

Re: Review Request 38304: Remove JDK 1.8 warning.

2015-09-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38304/#review98625 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 11, 2015, 4:33 p.

Review Request 38304: Remove JDK 1.8 warning.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38304/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --

Re: Review Request 38302: Replace incorrect/misleading use of constraints with best practices doc.

2015-09-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38302/#review98620 --- Ship it! Master (4ee10b0) is green with this patch. ./build-suppo

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-11 Thread Bill Farner
> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java, > > line 87 > > > > > > This code will be easier to maintain long-term with 2

Review Request 38302: Replace incorrect/misleading use of constraints with best practices doc.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38302/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-11 Thread Stephan Erb
> On Sept. 11, 2015, 9:55 a.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/breadcrumb.html, line 35 > > > > > > The title is rather specific and might not match what people outside of > > Twitter use

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-11 Thread Joshua Cohen
> On Sept. 11, 2015, 7:55 a.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/breadcrumb.html, line 35 > > > > > > The title is rather specific and might not match what people outside of > > Twitter use

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-11 Thread Stephan Erb
> On Sept. 11, 2015, 9:55 a.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/breadcrumb.html, line 35 > > > > > > The title is rather specific and might not match what people outside of > > Twitter use

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-11 Thread Joshua Cohen
> On Sept. 11, 2015, 7:55 a.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/breadcrumb.html, line 35 > > > > > > The title is rather specific and might not match what people outside of > > Twitter use

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38270/#review98577 --- src/main/resources/scheduler/assets/breadcrumb.html (line 35)