Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-14 Thread Renan DelValle
> On Sept. 2, 2015, 4:45 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java, > > line 87 > > > > > > This code will be easier to maintain long-term with

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

2015-09-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98858 --- Ship it! Couple of nits, lgtm in general.

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-14 Thread Bill Farner
> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java, > > line 87 > > > > > > This code will be easier to maintain long-term with

Review Request 38390: Adding oversubscription summary.

2015-09-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38390/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1441

Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

2015-09-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38389/#review98979 --- The default value wasn't a hack, but moving it to the end of the

Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO

2015-09-14 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38389/ --- Review request for Aurora. Bugs: AURORA-1485

Re: Review Request 38390: Adding oversubscription summary.

2015-09-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38390/#review98977 --- docs/configuration-reference.md (line 332)

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-14 Thread Bill Farner
> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java, > > line 87 > > > > > > This code will be easier to maintain long-term with

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

2015-09-14 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38332/#review98877 --- Ship it!

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-14 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- (Updated Sept. 14, 2015, 11:46 a.m.) Review request for Aurora, Maxim

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-14 Thread Joe Smith
> On Sept. 11, 2015, 5:15 p.m., Bill Farner wrote: > > api/src/main/thrift/org/apache/aurora/gen/storage.thrift, lines 130-139 > > > > > > How about map for arbitrary metadata? then you don't > >