Re: Review Request 40201: Cleanup thermos_executor test pexes.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40201/#review106421
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 13, 2015, 3:32 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40201/
> ---
> 
> (Updated Nov. 13, 2015, 3:32 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Brian Wickman, and 
> Zameer Manji.
> 
> 
> Bugs: AURORA-547
> https://issues.apache.org/jira/browse/AURORA-547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Previously these were built to the standard `dist/` dir, now they are
> dumped to a tmp dir that's cleaned up.
> 
>  src/test/python/apache/aurora/executor/test_thermos_executor.py| 24 
> +++-
>  src/test/python/apache/aurora/executor/test_thermos_task_runner.py | 15 
> ++-
>  2 files changed, 29 insertions(+), 10 deletions(-)
> 
> 
> Diffs
> -
> 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> d24c61162e11bb4afef2902ebb031478fe3ed247 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> bb998c0b0ac87ba51ec13e490338b00e7f85e8cf 
> 
> Diff: https://reviews.apache.org/r/40201/diff/
> 
> 
> Testing
> ---
> 
> Green locally:
> ```
> $ rm -rf dist/ && \
>   ./pants test.pytest --no-fast src/test/python/apache/aurora/executor:
> ```
> 
> And no `dist/` created.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40197/#review106424
---



pants.ini (lines 27 - 29)


When I went to commit this change, I got a merge conflict applying the 
patch. According to git, these lines are not found in pants.ini on 
[master](https://github.com/apache/aurora/blob/master/pants.ini)? And just to 
be sure, this is not a github mirroring issue, Apache's git shows the [same 
thing](https://git-wip-us.apache.org/repos/asf?p=aurora.git;a=blob;f=pants.ini;h=22f6c59dd93c1a4a2ca78c216e1fd3f3f6c8b752;hb=HEAD).


- Joshua Cohen


On Nov. 11, 2015, 8:30 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40197/
> ---
> 
> (Updated Nov. 11, 2015, 8:30 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-547
> https://issues.apache.org/jira/browse/AURORA-547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The Aurora python tests cannot currently all be run together; so the ci
> script passes --no-fast and devs need to remember to do this too.
> Improve the dev experience by defaulting this option.
> 
>  build-support/jenkins/build.sh | 2 +-
>  pants.ini  | 7 +++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 5cd5242a2e4551e356e5ce5d15a0d27beb7e2d4e 
>   pants.ini 0bd8ec829ae65e2296a122166dea13f315323c9f 
> 
> Diff: https://reviews.apache.org/r/40197/diff/
> 
> 
> Testing
> ---
> 
> Ran into this working https://issues.apache.org/jira/browse/AURORA-547.
> After the fix, locally ran `./pants test src/test/python:: -- -v` green.
> Previously this would lead to test failures and CPU starvation.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

[Bill Farner]

> On Nov. 13, 2015, 8:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > 
> >
> > Seems worth a note this is only used by the vagrant provisioning ... or 
> > add this to `examples/vagrant/aurorabuild.sh`:
> > 
> > ```
> > export PANTS_CONFIG_OVERRIDE="['vagrant.ini']"
> > ```
> > 
> > Path to the override ini is whatever it needs to be, but it need only 
> > contain the entry you added here.
> 
> John Sirois wrote:
> Looks like the site doc is stale - option is singular valued and the name 
> is pluralized - but some doc here: 
> https://pantsbuild.github.io/invoking.html#overlay-ini-files-with-config-overrides
> But the correct option help is found via `./pants help-advanced`

That wouldn't really work, as it's needed any time 
`src/main/python/apache/aurora/executor:thermos_executor` is built (more 
specifically - when `3rdparty/python:mesos.native` is included as a dep.  Seems 
like a comment is the only sane path forward, right?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106438
---


On Nov. 13, 2015, 8:34 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40299/
> ---
> 
> (Updated Nov. 13, 2015, 8:34 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Bugs: AURORA-1538
> https://issues.apache.org/jira/browse/AURORA-1538
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Restore the third_party python repo, needed for mesos.native egg.
> 
> 
> Diffs
> -
> 
>   pants.ini b12248c4834fa172b80506b3872c75df666b85cf 
> 
> Diff: https://reviews.apache.org/r/40299/diff/
> 
> 
> Testing
> ---
> 
> I can now build the executor in vagrant.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40197/#review106422
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 11, 2015, 8:30 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40197/
> ---
> 
> (Updated Nov. 11, 2015, 8:30 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-547
> https://issues.apache.org/jira/browse/AURORA-547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The Aurora python tests cannot currently all be run together; so the ci
> script passes --no-fast and devs need to remember to do this too.
> Improve the dev experience by defaulting this option.
> 
>  build-support/jenkins/build.sh | 2 +-
>  pants.ini  | 7 +++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 5cd5242a2e4551e356e5ce5d15a0d27beb7e2d4e 
>   pants.ini 0bd8ec829ae65e2296a122166dea13f315323c9f 
> 
> Diff: https://reviews.apache.org/r/40197/diff/
> 
> 
> Testing
> ---
> 
> Ran into this working https://issues.apache.org/jira/browse/AURORA-547.
> After the fix, locally ran `./pants test src/test/python:: -- -v` green.
> Previously this would lead to test failures and CPU starvation.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

[John Sirois]

> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > 
> >
> > Seems worth a note this is only used by the vagrant provisioning ... or 
> > add this to `examples/vagrant/aurorabuild.sh`:
> > 
> > ```
> > export PANTS_CONFIG_OVERRIDE="['vagrant.ini']"
> > ```
> > 
> > Path to the override ini is whatever it needs to be, but it need only 
> > contain the entry you added here.

Looks like the site doc is stale - option is singular valued and the name is 
pluralized - but some doc here: 
https://pantsbuild.github.io/invoking.html#overlay-ini-files-with-config-overrides
But the correct option help is found via `./pants help-advanced`


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106438
---


On Nov. 13, 2015, 9:34 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40299/
> ---
> 
> (Updated Nov. 13, 2015, 9:34 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Bugs: AURORA-1538
> https://issues.apache.org/jira/browse/AURORA-1538
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Restore the third_party python repo, needed for mesos.native egg.
> 
> 
> Diffs
> -
> 
>   pants.ini b12248c4834fa172b80506b3872c75df666b85cf 
> 
> Diff: https://reviews.apache.org/r/40299/diff/
> 
> 
> Testing
> ---
> 
> I can now build the executor in vagrant.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

[John Sirois]

> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > 
> >
> > Seems worth a note this is only used by the vagrant provisioning ... or 
> > add this to `examples/vagrant/aurorabuild.sh`:
> > 
> > ```
> > export PANTS_CONFIG_OVERRIDE="['vagrant.ini']"
> > ```
> > 
> > Path to the override ini is whatever it needs to be, but it need only 
> > contain the entry you added here.
> 
> John Sirois wrote:
> Looks like the site doc is stale - option is singular valued and the name 
> is pluralized - but some doc here: 
> https://pantsbuild.github.io/invoking.html#overlay-ini-files-with-config-overrides
> But the correct option help is found via `./pants help-advanced`
> 
> Bill Farner wrote:
> That wouldn't really work, as it's needed any time 
> `src/main/python/apache/aurora/executor:thermos_executor` is built (more 
> specifically - when `3rdparty/python:mesos.native` is included as a dep.  
> Seems like a comment is the only sane path forward, right?

SGTM.  Looks like more cleanup could happen going forward though since - fwict 
- the only way to get that dep right now is:
```
examples/vagrant/provision-dev-cluster.sh:  wget -c 
https://svn.apache.org/repos/asf/aurora/3rdparty/ubuntu/trusty64/python/mesos.native-${MESOS_VERSION}-py2.7-linux-x86_64.egg
```


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106438
---


On Nov. 13, 2015, 9:34 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40299/
> ---
> 
> (Updated Nov. 13, 2015, 9:34 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Bugs: AURORA-1538
> https://issues.apache.org/jira/browse/AURORA-1538
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Restore the third_party python repo, needed for mesos.native egg.
> 
> 
> Diffs
> -
> 
>   pants.ini b12248c4834fa172b80506b3872c75df666b85cf 
> 
> Diff: https://reviews.apache.org/r/40299/diff/
> 
> 
> Testing
> ---
> 
> I can now build the executor in vagrant.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40220: Modernize the pex venv script.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40220/#review106419
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 12, 2015, 8:35 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40220/
> ---
> 
> (Updated Nov. 12, 2015, 8:35 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This converts from grabbing the old Twitter python pex to grabbing
> modern pex to match the version specified in 3rdparty to help keep the
> pex venv up to date with the codebase dependencies.
> 
>  build-support/pex | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 
> 
> Diff: https://reviews.apache.org/r/40220/diff/
> 
> 
> Testing
> ---
> 
> Locally ran this 2x and observed both the proper version (1.1.0) and
> proper use of the cached venv in the second run:
> `git clean -fdx build-support && ./build-support/pex --version`
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

[John Sirois]

> On Nov. 13, 2015, 8:42 a.m., Joshua Cohen wrote:
> > pants.ini, lines 27-29
> > 
> >
> > When I went to commit this change, I got a merge conflict applying the 
> > patch. According to git, these lines are not found in pants.ini on 
> > [master](https://github.com/apache/aurora/blob/master/pants.ini)? And just 
> > to be sure, this is not a github mirroring issue, Apache's git shows the 
> > [same 
> > thing](https://git-wip-us.apache.org/repos/asf?p=aurora.git;a=blob;f=pants.ini;h=22f6c59dd93c1a4a2ca78c216e1fd3f3f6c8b752;hb=HEAD).

Ah yes - makes sense.  Had a lot of changes in flight and this one nuked that: 
https://git1-us-west.apache.org/repos/asf?p=aurora.git;a=commit;h=b4102def

I'll rebase and post the new diff.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40197/#review106424
---


On Nov. 11, 2015, 1:30 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40197/
> ---
> 
> (Updated Nov. 11, 2015, 1:30 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-547
> https://issues.apache.org/jira/browse/AURORA-547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The Aurora python tests cannot currently all be run together; so the ci
> script passes --no-fast and devs need to remember to do this too.
> Improve the dev experience by defaulting this option.
> 
>  build-support/jenkins/build.sh | 2 +-
>  pants.ini  | 7 +++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 5cd5242a2e4551e356e5ce5d15a0d27beb7e2d4e 
>   pants.ini 0bd8ec829ae65e2296a122166dea13f315323c9f 
> 
> Diff: https://reviews.apache.org/r/40197/diff/
> 
> 
> Testing
> ---
> 
> Ran into this working https://issues.apache.org/jira/browse/AURORA-547.
> After the fix, locally ran `./pants test src/test/python:: -- -v` green.
> Previously this would lead to test failures and CPU starvation.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40197/
---

(Updated Nov. 13, 2015, 8:46 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Fix `./pants test src/test/python::` to work out of the box.

The Aurora python tests cannot currently all be run together; so the ci
script passes --no-fast and devs need to remember to do this too.
Improve the dev experience by defaulting this option.

 build-support/jenkins/build.sh | 2 +-
 pants.ini  | 7 +++
 2 files changed, 8 insertions(+), 1 deletion(-)


Bugs: AURORA-547
https://issues.apache.org/jira/browse/AURORA-547


Repository: aurora


Description
---

The Aurora python tests cannot currently all be run together; so the ci
script passes --no-fast and devs need to remember to do this too.
Improve the dev experience by defaulting this option.

 build-support/jenkins/build.sh | 2 +-
 pants.ini  | 7 +++
 2 files changed, 8 insertions(+), 1 deletion(-)


Diffs (updated)
-

  build-support/jenkins/build.sh 7277a64b0cbc2ad43e79a5b0cf3d3a1fae135042 
  pants.ini 22f6c59dd93c1a4a2ca78c216e1fd3f3f6c8b752 

Diff: https://reviews.apache.org/r/40197/diff/


Testing
---

Ran into this working https://issues.apache.org/jira/browse/AURORA-547.
After the fix, locally ran `./pants test src/test/python:: -- -v` green.
Previously this would lead to test failures and CPU starvation.


Thanks,

John Sirois

Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/
---

Review request for Aurora, Joshua Cohen and John Sirois.


Bugs: AURORA-1538
https://issues.apache.org/jira/browse/AURORA-1538


Repository: aurora


Description
---

Restore the third_party python repo, needed for mesos.native egg.


Diffs
-

  pants.ini b12248c4834fa172b80506b3872c75df666b85cf 

Diff: https://reviews.apache.org/r/40299/diff/


Testing
---

I can now build the executor in vagrant.


Thanks,

Bill Farner

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106438
---



pants.ini (line 33)


Seems worth a note this is only used by the vagrant provisioning ... or add 
this to `examples/vagrant/aurorabuild.sh`:

```
export PANTS_CONFIG_OVERRIDE="['vagrant.ini']"
```

Path to the override ini is whatever it needs to be, but it need only 
contain the entry you added here.


- John Sirois


On Nov. 13, 2015, 9:34 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40299/
> ---
> 
> (Updated Nov. 13, 2015, 9:34 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Bugs: AURORA-1538
> https://issues.apache.org/jira/browse/AURORA-1538
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Restore the third_party python repo, needed for mesos.native egg.
> 
> 
> Diffs
> -
> 
>   pants.ini b12248c4834fa172b80506b3872c75df666b85cf 
> 
> Diff: https://reviews.apache.org/r/40299/diff/
> 
> 
> Testing
> ---
> 
> I can now build the executor in vagrant.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106451
---

Ship it!


Ship It!

- John Sirois


On Nov. 13, 2015, 10:24 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40299/
> ---
> 
> (Updated Nov. 13, 2015, 10:24 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Bugs: AURORA-1538
> https://issues.apache.org/jira/browse/AURORA-1538
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Restore the third_party python repo, needed for mesos.native egg.
> 
> 
> Diffs
> -
> 
>   pants.ini b12248c4834fa172b80506b3872c75df666b85cf 
> 
> Diff: https://reviews.apache.org/r/40299/diff/
> 
> 
> Testing
> ---
> 
> I can now build the executor in vagrant.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106437
---

Ship it!


Master (cc7f5a1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 13, 2015, 4:34 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40299/
> ---
> 
> (Updated Nov. 13, 2015, 4:34 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Bugs: AURORA-1538
> https://issues.apache.org/jira/browse/AURORA-1538
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Restore the third_party python repo, needed for mesos.native egg.
> 
> 
> Diffs
> -
> 
>   pants.ini b12248c4834fa172b80506b3872c75df666b85cf 
> 
> Diff: https://reviews.apache.org/r/40299/diff/
> 
> 
> Testing
> ---
> 
> I can now build the executor in vagrant.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106448
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 13, 2015, 4:34 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40299/
> ---
> 
> (Updated Nov. 13, 2015, 4:34 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Bugs: AURORA-1538
> https://issues.apache.org/jira/browse/AURORA-1538
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Restore the third_party python repo, needed for mesos.native egg.
> 
> 
> Diffs
> -
> 
>   pants.ini b12248c4834fa172b80506b3872c75df666b85cf 
> 
> Diff: https://reviews.apache.org/r/40299/diff/
> 
> 
> Testing
> ---
> 
> I can now build the executor in vagrant.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106447
---

Ship it!


LGTM mod a pending comment

- John Sirois


On Nov. 13, 2015, 9:34 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40299/
> ---
> 
> (Updated Nov. 13, 2015, 9:34 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Bugs: AURORA-1538
> https://issues.apache.org/jira/browse/AURORA-1538
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Restore the third_party python repo, needed for mesos.native egg.
> 
> 
> Diffs
> -
> 
>   pants.ini b12248c4834fa172b80506b3872c75df666b85cf 
> 
> Diff: https://reviews.apache.org/r/40299/diff/
> 
> 
> Testing
> ---
> 
> I can now build the executor in vagrant.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40201: Cleanup thermos_executor test pexes.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40201/#review106467
---

Ship it!


Ship It!

- Zameer Manji


On Nov. 13, 2015, 7:32 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40201/
> ---
> 
> (Updated Nov. 13, 2015, 7:32 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Brian Wickman, and 
> Zameer Manji.
> 
> 
> Bugs: AURORA-547
> https://issues.apache.org/jira/browse/AURORA-547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Previously these were built to the standard `dist/` dir, now they are
> dumped to a tmp dir that's cleaned up.
> 
>  src/test/python/apache/aurora/executor/test_thermos_executor.py| 24 
> +++-
>  src/test/python/apache/aurora/executor/test_thermos_task_runner.py | 15 
> ++-
>  2 files changed, 29 insertions(+), 10 deletions(-)
> 
> 
> Diffs
> -
> 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> d24c61162e11bb4afef2902ebb031478fe3ed247 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> bb998c0b0ac87ba51ec13e490338b00e7f85e8cf 
> 
> Diff: https://reviews.apache.org/r/40201/diff/
> 
> 
> Testing
> ---
> 
> Green locally:
> ```
> $ rm -rf dist/ && \
>   ./pants test.pytest --no-fast src/test/python/apache/aurora/executor:
> ```
> 
> And no `dist/` created.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40304: Upgrade to checkstyle 6.12.1

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40304/#review106484
---

Ship it!


Master (ba9819e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 13, 2015, 6:39 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40304/
> ---
> 
> (Updated Nov. 13, 2015, 6:39 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Release notes: http://checkstyle.sourceforge.net/releasenotes.html
> 
> Context - i'm trying to keep up-to-date with checkstyle, pmd, and findbugs to 
> get past various issues related to use of lambdas and method references 
> without giving up code quality checks.  There is a significant update to PMD 
> that is nearly to ready for us - just one false positive issue i bumped into: 
> http://sourceforge.net/p/pmd/bugs/1422/
> 
> 
> Diffs
> -
> 
>   build.gradle ca18d6c3b998321bc64e3806ad885b1ceabc99a8 
> 
> Diff: https://reviews.apache.org/r/40304/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40304: Upgrade to checkstyle 6.12.1

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40304/#review106507
---

Ship it!


Ship It!

- Zameer Manji


On Nov. 13, 2015, 10:39 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40304/
> ---
> 
> (Updated Nov. 13, 2015, 10:39 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Release notes: http://checkstyle.sourceforge.net/releasenotes.html
> 
> Context - i'm trying to keep up-to-date with checkstyle, pmd, and findbugs to 
> get past various issues related to use of lambdas and method references 
> without giving up code quality checks.  There is a significant update to PMD 
> that is nearly to ready for us - just one false positive issue i bumped into: 
> http://sourceforge.net/p/pmd/bugs/1422/
> 
> 
> Diffs
> -
> 
>   build.gradle ca18d6c3b998321bc64e3806ad885b1ceabc99a8 
> 
> Diff: https://reviews.apache.org/r/40304/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/#review106505
---

Ship it!


Master (ba9819e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 13, 2015, 9:27 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40310/
> ---
> 
> (Updated Nov. 13, 2015, 9:27 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
> Zameer Manji.
> 
> 
> Bugs: AURORA-1532
> https://issues.apache.org/jira/browse/AURORA-1532
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This upgrades to pants 0.0.58 to pick up the newly split off pants
> python checks contrib plugin.  Release notes are here:
>   https://pypi.python.org/pypi/pantsbuild.pants/0.0.58
> 
> The plugin provides both python checkstyle (`compile.pythonstyle`), and
> a python eval task (`compile.python-eval`).  The `python-eval` is turned
> off since at least one of the Aurora python targets has files that have
> side-effects upon import (a repl is started).
> 
> Now style checks run before compile (and thus before tests) and they
> benefit from fingerprinting; ie: if you test your changes, those tests
> will run style checks and when you go to commit, those checks will not
> be re-run by the commit hook (although files you did not test will still
> need to be checked).
> 
> A few production files were fixes up according to style failures coming
> from no space after comment opening '#', unused variables, and
> mis-aligned hanging closing parens.
> 
>  build-support/hooks/pre-commit|  3 
> +--
>  build-support/jenkins/build.sh|  8 
> 
>  build-support/python/checkstyle   | 34 
> -
>  build-support/python/checkstyle-check |  6 
> +++---
>  pants.ini | 52 
> +-
>  src/main/python/apache/aurora/admin/maintenance.py|  2 +-
>  src/main/python/apache/aurora/client/api/__init__.py  |  4 
> ++--
>  src/main/python/apache/aurora/client/cli/client.py|  2 +-
>  src/main/python/apache/aurora/client/cli/cron.py  |  2 +-
>  src/main/python/apache/thermos/core/process.py|  6 
> +++---
>  src/main/python/apache/thermos/monitoring/process_collector_psutil.py |  1 -
>  src/test/python/apache/aurora/admin/test_admin.py |  6 
> --
>  src/test/python/apache/aurora/admin/util.py   |  2 +-
>  src/test/python/apache/aurora/client/cli/test_task.py |  3 
> +--
>  14 files changed, 69 insertions(+), 62 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
>   build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
>   build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
>   build-support/python/checkstyle-check 
> b2bfc5dd71193a8056828e9af05a4c16965f32a1 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
>   src/main/python/apache/aurora/admin/maintenance.py 
> 6d94c923ae37bf6b827519d3505b100af306296b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 6f07a3073a5d422373238619d459fbd09d8adf3d 
>   src/main/python/apache/aurora/client/cli/client.py 
> 297fb588808c1eebc32ac3374265ba986dab3436 
>   src/main/python/apache/aurora/client/cli/cron.py 
> 6376fd014f2a4da29442b5c2c7eb36578b503ba3 
>   src/main/python/apache/thermos/core/process.py 
> fe95cb3be01b47616596bd78cb9a919b2e8bd978 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> f1ec5a9050ac60700c4a8afa905bcf12a9bd8a44 
>   src/test/python/apache/aurora/admin/test_admin.py 
> 8e204ab43c6bf69867ea7c32b0a7ba7fb29c0766 
>   src/test/python/apache/aurora/admin/util.py 
> 3570407b51613d0a7b4fde8a4794d88b98e150b5 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> 5432a3d5f7e150b12bd75db0dac7a9018e1c6636 
> 
> Diff: https://reviews.apache.org/r/40310/diff/
> 
> 
> Testing
> ---
> 
> See the discarded https://reviews.apache.org/r/40219/ for the
> commit-hook check.  This version of that RB engages the same code
> and this RB commit was vetted by the same commit-hook.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/
---

(Updated Nov. 13, 2015, 4:27 p.m.)


Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
Zameer Manji.


Bugs: AURORA-1532
https://issues.apache.org/jira/browse/AURORA-1532


Repository: aurora


Description (updated)
---

This upgrades to pants 0.0.58 to pick up the newly split off pants
python checks contrib plugin.  Release notes are here:
  https://pypi.python.org/pypi/pantsbuild.pants/0.0.58

The plugin provides both python checkstyle (`compile.pythonstyle`), and
a python eval task (`compile.python-eval`).  The `python-eval` is turned
off since at least one of the Aurora python targets has files that have
side-effects upon import (a repl is started).

Now style checks run before compile (and thus before tests) and they
benefit from fingerprinting; ie: if you test your changes, those tests
will run style checks and when you go to commit, those checks will not
be re-run by the commit hook (although files you did not test will still
need to be checked).

A few production files were fixed up according to style failures coming
from:
+ no space after comment opening '#'
+ unused variables
+ mis-aligned hanging closing parens.


Diffs
-

  build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
  build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
  build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
  build-support/python/checkstyle-check 
b2bfc5dd71193a8056828e9af05a4c16965f32a1 
  pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
  src/main/python/apache/aurora/admin/maintenance.py 
6d94c923ae37bf6b827519d3505b100af306296b 
  src/main/python/apache/aurora/client/api/__init__.py 
6f07a3073a5d422373238619d459fbd09d8adf3d 
  src/main/python/apache/aurora/client/cli/client.py 
297fb588808c1eebc32ac3374265ba986dab3436 
  src/main/python/apache/aurora/client/cli/cron.py 
6376fd014f2a4da29442b5c2c7eb36578b503ba3 
  src/main/python/apache/thermos/core/process.py 
fe95cb3be01b47616596bd78cb9a919b2e8bd978 
  src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
f1ec5a9050ac60700c4a8afa905bcf12a9bd8a44 
  src/test/python/apache/aurora/admin/test_admin.py 
8e204ab43c6bf69867ea7c32b0a7ba7fb29c0766 
  src/test/python/apache/aurora/admin/util.py 
3570407b51613d0a7b4fde8a4794d88b98e150b5 
  src/test/python/apache/aurora/client/cli/test_task.py 
5432a3d5f7e150b12bd75db0dac7a9018e1c6636 

Diff: https://reviews.apache.org/r/40310/diff/


Testing
---

See the discarded https://reviews.apache.org/r/40219/ for the
commit-hook check.  This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.


Thanks,

John Sirois

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40219/#review106527
---


Replacement RB using official plugin is here: 
https://reviews.apache.org/r/40310/

- John Sirois


On Nov. 12, 2015, 1:54 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40219/
> ---
> 
> (Updated Nov. 12, 2015, 1:54 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
> Zameer Manji.
> 
> 
> Bugs: AURORA-1532
> https://issues.apache.org/jira/browse/AURORA-1532
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The built-in pants python checkstyle plugin is turned on by adding a
> small custom plugin that installs the checks in the compile goal.  Now
> style checks run before compile (and thus before tests) and they benefit
> from fingerprinting; ie: if you test your changes, those tests will run
> style checks and when you go to commit, those checks will not be re-run
> by the commit hook (although files you did not test will still need to
> be checked).
> 
> A few production files were fixes up according to style failures coming
> from no space after comment opening '#', unused variables, and
> mis-aligned hanging closing parens.
> 
>  build-support/hooks/pre-commit   
>|  3 +--
>  build-support/jenkins/build.sh   
>|  9 +
>  build-support/{python/checkstyle-check => plugins/3rdparty/python/BUILD} 
>| 13 ++---
>  build-support/{python/checkstyle-check => 
> plugins/src/main/python/apache/__init__.py}   | 12 
> +---
>  build-support/{python/checkstyle-check => 
> plugins/src/main/python/apache/aurora/__init__.py}| 12 
> +---
>  build-support/{python/checkstyle-check => 
> plugins/src/main/python/apache/aurora/pants/__init__.py}  | 12 
> +---
>  build-support/{python/checkstyle-check => 
> plugins/src/main/python/apache/aurora/pants/optional/BUILD}   | 18 
> +++---
>  build-support/{python/checkstyle-check => 
> plugins/src/main/python/apache/aurora/pants/optional/__init__.py} | 12 
> +---
>  
> build-support/plugins/src/main/python/apache/aurora/pants/optional/register.py
>   | 36 
>  build-support/python/checkstyle  
>| 34 --
>  build-support/python/checkstyle-check
>|  6 +++---
>  pants.ini
>| 43 
> +++
>  src/main/python/apache/aurora/admin/maintenance.py   
>|  2 +-
>  src/main/python/apache/aurora/client/api/__init__.py 
>|  4 ++--
>  src/main/python/apache/aurora/client/cli/client.py   
>|  2 +-
>  src/main/python/apache/aurora/client/cli/cron.py 
>|  2 +-
>  src/main/python/apache/thermos/core/process.py   
>|  6 +++---
>  src/main/python/apache/thermos/monitoring/process_collector_psutil.py
>|  1 -
>  src/test/python/apache/aurora/admin/test_admin.py
>|  6 --
>  src/test/python/apache/aurora/admin/util.py  
>|  2 +-
>  src/test/python/apache/aurora/client/cli/test_task.py
>|  3 +--
>  21 files changed, 111 insertions(+), 127 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
>   build-support/jenkins/build.sh 5cd5242a2e4551e356e5ce5d15a0d27beb7e2d4e 
>   build-support/plugins/3rdparty/python/BUILD PRE-CREATION 
>   build-support/plugins/src/main/python/apache/__init__.py PRE-CREATION 
>   build-support/plugins/src/main/python/apache/aurora/__init__.py 
> PRE-CREATION 
>   build-support/plugins/src/main/python/apache/aurora/pants/__init__.py 
> PRE-CREATION 
>   build-support/plugins/src/main/python/apache/aurora/pants/optional/BUILD 
> PRE-CREATION 
>   
>