Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 


> On Nov. 15, 2015, 10:57 p.m., Bill Farner wrote:
> > Heh, took a few rounds to understand what was going on 
> > here...case-insensitive file system strikes again!
> > ```
> > ...
> > Making install in lib
> > /Library/Developer/CommandLineTools/usr/bin/make  install-am
> > if test no = no; then \
> >   case 'darwin15.0.0' in \
> > darwin[56]*) \
> >   need_charset_alias=true ;; \
> > darwin* | cygwin* | mingw* | pw32* | cegcc*) \
> >   need_charset_alias=false ;; \
> > *) \
> >   need_charset_alias=true ;; \
> >   esac ; \
> > else \
> >   need_charset_alias=false ; \
> > fi ; \
> > if $need_charset_alias; then \
> >   /bin/sh 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/build-aux/install-sh
> >  -d /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib ; \
> > fi ; \
> > if test -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias;
> >  then \
> >   sed -f ref-add.sed 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  > 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> >   /usr/bin/install -c -m 644 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  ; \
> >   rm -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> > else \
> >   if $need_charset_alias; then \
> > sed -f ref-add.sed charset.alias > 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> > /usr/bin/install -c -m 644 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  ; \
> > rm -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> >   fi ; \
> > fi
> >  ../build-aux/install-sh -c -d 
> > '/Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib'
> > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install: 
> > File exists
> > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install: 
> > Not a directory
> > make[5]: *** [install-libLIBRARIES] Error 1
> > make[4]: *** [install-am] Error 2
> > make[3]: *** [install] Error 2
> > make[2]: *** [install-recursive] Error 1
> > make[1]: *** [install] Error 2
> > ```
> > 
> > bison includes an INSTALL file, and your `--prefix` is `$dist/install` :-P
> 
> John Sirois wrote:
> Hrm - serves me right for installing OSX on case-sensitive HFS+.
> Fixed; although the AuroraBot will continue to be red due to 
> https://reviews.apache.org/r/40334/

Alright - rebasing against https://reviews.apache.org/r/40334/ so AuroraBot can 
go green.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106597
---


On Nov. 16, 2015, 8:13 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 8:13 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

2015-11-16 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40334/#review106678
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 15, 2015, 11:36 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40334/
> ---
> 
> (Updated Nov. 15, 2015, 11:36 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The problem is described here:
>   https://github.com/pantsbuild/pants/issues/2566
> 
> Changelogs are here:
>   https://pypi.python.org/pypi/pantsbuild.pants/0.0.59
> 
>  pants.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
> 
> Diff: https://reviews.apache.org/r/40334/diff/
> 
> 
> Testing
> ---
> 
> Before the fix stumbled into this:
> ```
> $ ./build-support/jenkins/build.sh
> ...
> 11:22:51 00:00   [test]
> 11:22:51 00:00 [run_prep_command]
> 11:22:51 00:00 [test]
> 11:22:51 00:00 [pytest]
> 11:22:51 00:00   [run]
> 
> 11:23:04 00:13 [chroot]
> 11:23:11 00:20   [complete]
>FAILURE
> 
> Exception message: Could not satisfy all requirements for pytest>=2.6,<2.7:
> pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)
> ```
> 
> That triggered a bit of a pants release firefight leading
> to this RB and one for Medium's mono repo as well as patching
> of the fix in at Square. Now
> `./build-support/jenkins/build.sh` runs green as well.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

2015-11-16 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40324/#review106684
---


Master (7b494f4) is red with this patch.
  ./build-support/jenkins/build.sh

16:51:29 00:00 [ivy-imports]
16:51:29 00:00   [unpack-jars]
16:51:29 00:00 [unpack-jars]
16:51:29 00:00   [deferred-sources]
16:51:29 00:00 [deferred-sources]
16:51:29 00:00   [gen]
16:51:29 00:00 [thrift]
16:51:29 00:00 [protoc]
16:51:29 00:00 [antlr]
16:51:30 00:01 [ragel]
16:51:30 00:01 [jaxb]
16:51:30 00:01 [wire]
16:51:30 00:01   [jvm-platform-validate]
16:51:30 00:01 [jvm-platform-validate]
16:51:30 00:01   [resolve]
16:51:30 00:01 [ivy]
16:51:30 00:01   [bootstrap-nailgun-server]
16:51:30 00:01   [resources]
16:51:30 00:01 [prepare]
16:51:30 00:01 [services]
16:51:30 00:01   [compile]
16:51:30 00:01 [compile]
16:51:30 00:01 [jvm]
16:51:30 00:01   [jvm-compilers]
16:51:30 00:01 [zinc-pre]
16:51:30 00:01 [zinc-post]
16:51:30 00:01 [jvm-dep-check]
16:51:30 00:01   [test]
16:51:30 00:01 [run_prep_command]
16:51:30 00:01 [test]
16:51:30 00:01 [pytest]
16:51:30 00:01   [run]
 
16:51:33 00:04 [chroot]
16:51:36 00:07   [complete]
   FAILURE
Exception message: Could not satisfy all requirements for pytest>=2.6,<2.7:
pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)




I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 16, 2015, 4:48 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40324/
> ---
> 
> (Updated Nov. 16, 2015, 4:48 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1538
> https://issues.apache.org/jira/browse/AURORA-1538
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This lifts `mesos.interface` and `mesos.native` out of
> `requirements.txt`, ties their versions together and isolates the
> custom repository needed by `mesos.native` to its `python_requirement`.
> 
>  3rdparty/python/BUILD| 26 ++
>  3rdparty/python/requirements.txt |  2 --
>  pants.ini|  5 -
>  3 files changed, 26 insertions(+), 7 deletions(-)
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 
>   3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e 
>   examples/vagrant/provision-dev-cluster.sh 
> 4474543bac16ac5af0de1f199e36e8b981d52e04 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
> 
> Diff: https://reviews.apache.org/r/40324/diff/
> 
> 
> Testing
> ---
> 
> Successfully ran end-to-end with this change using a fresh vagrant
> image and clean repo via:
> ```
> vagrant destroy && \
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/#review106674
---



pants.ini (line 19)


nit: fix indent?



pants.ini (line 77)


or maybe this identation style is intentional/correct?



src/main/python/apache/aurora/client/api/__init__.py (lines 283 - 284)


alternately this should validate and save the interim var?

return Restarter(
job_key,
updater_config,
...
self._scheduler_proxy).restart(instances)



src/test/python/apache/aurora/admin/test_admin.py 


Why kill this? It seems like the intention was to ensure that set quota is 
called with the correct types, but the assert above still passes if we were to 
do `assert_called_with(role, 24, 4001.0, 6001.0)`, thus the explicit type 
checks were necessary?


- Joshua Cohen


On Nov. 16, 2015, 4:02 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40310/
> ---
> 
> (Updated Nov. 16, 2015, 4:02 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
> Zameer Manji.
> 
> 
> Bugs: AURORA-1532
> https://issues.apache.org/jira/browse/AURORA-1532
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This upgrades to pants 0.0.58 to pick up the newly split off pants
> python checks contrib plugin.  Release notes are here:
>   https://pypi.python.org/pypi/pantsbuild.pants/0.0.58
> 
> The plugin provides both python checkstyle (`compile.pythonstyle`), and
> a python eval task (`compile.python-eval`).  The `python-eval` is turned
> off since at least one of the Aurora python targets has files that have
> side-effects upon import (a repl is started).
> 
> Now style checks run before compile (and thus before tests) and they
> benefit from fingerprinting; ie: if you test your changes, those tests
> will run style checks and when you go to commit, those checks will not
> be re-run by the commit hook (although files you did not test will still
> need to be checked).
> 
> A few production files were fixed up according to style failures coming
> from:
> + no space after comment opening '#'
> + unused variables
> + mis-aligned hanging closing parens.
> 
> 
> Diffs
> -
> 
>   build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
>   build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
>   build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
>   build-support/python/checkstyle-check 
> b2bfc5dd71193a8056828e9af05a4c16965f32a1 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
>   src/main/python/apache/aurora/admin/maintenance.py 
> 6d94c923ae37bf6b827519d3505b100af306296b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 6f07a3073a5d422373238619d459fbd09d8adf3d 
>   src/main/python/apache/aurora/client/cli/client.py 
> 297fb588808c1eebc32ac3374265ba986dab3436 
>   src/main/python/apache/aurora/client/cli/cron.py 
> 6376fd014f2a4da29442b5c2c7eb36578b503ba3 
>   src/main/python/apache/thermos/core/process.py 
> fe95cb3be01b47616596bd78cb9a919b2e8bd978 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> f1ec5a9050ac60700c4a8afa905bcf12a9bd8a44 
>   src/test/python/apache/aurora/admin/test_admin.py 
> 8e204ab43c6bf69867ea7c32b0a7ba7fb29c0766 
>   src/test/python/apache/aurora/admin/util.py 
> 3570407b51613d0a7b4fde8a4794d88b98e150b5 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> 5432a3d5f7e150b12bd75db0dac7a9018e1c6636 
> 
> Diff: https://reviews.apache.org/r/40310/diff/
> 
> 
> Testing
> ---
> 
> See the discarded https://reviews.apache.org/r/40219/ for the
> commit-hook check.  This version of that RB engages the same code
> and this RB commit was vetted by the same commit-hook.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40324/
---

(Updated Nov. 16, 2015, 9:48 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Improve documentation of mesos.native gymnastics.

 3rdparty/python/requirements.txt  | 15 +++
 examples/vagrant/provision-dev-cluster.sh |  1 +
 2 files changed, 16 insertions(+)


Bugs: AURORA-1538
https://issues.apache.org/jira/browse/AURORA-1538


Repository: aurora


Description
---

This lifts `mesos.interface` and `mesos.native` out of
`requirements.txt`, ties their versions together and isolates the
custom repository needed by `mesos.native` to its `python_requirement`.

 3rdparty/python/BUILD| 26 ++
 3rdparty/python/requirements.txt |  2 --
 pants.ini|  5 -
 3 files changed, 26 insertions(+), 7 deletions(-)


Diffs (updated)
-

  3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 
  3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e 
  examples/vagrant/provision-dev-cluster.sh 
4474543bac16ac5af0de1f199e36e8b981d52e04 
  pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 

Diff: https://reviews.apache.org/r/40324/diff/


Testing
---

Successfully ran end-to-end with this change using a fresh vagrant
image and clean repo via:
```
vagrant destroy && \
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```


Thanks,

John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/
---

(Updated Nov. 16, 2015, 8:13 a.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Fixup BISON_PREFIX to use a unique (case aside) dirent name.

 build-support/thrift/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Repository: aurora


Description
---

This improves the isolation of the thrift build by building a local
pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
Linux, a rolling release that is otherwise too modern in its libs to
successfully build thrift 0.9.1.

Additionally, this change knocks out the checksumming TODO and now
checks all downloaded tarballs meet their expected hashes.  The
hashes were generated locally after checking the sha1's where
available.

 build-support/thrift/.gitignore |  7 ---
 build-support/thrift/Makefile   | 47 
++-
 2 files changed, 42 insertions(+), 12 deletions(-)


Diffs (updated)
-

  build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
  build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 

Diff: https://reviews.apache.org/r/40323/diff/


Testing
---

I can now run `./build-support/jenkins/build.sh` green locally.

I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.


Thanks,

John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 


> On Nov. 15, 2015, 10:57 p.m., Bill Farner wrote:
> > Heh, took a few rounds to understand what was going on 
> > here...case-insensitive file system strikes again!
> > ```
> > ...
> > Making install in lib
> > /Library/Developer/CommandLineTools/usr/bin/make  install-am
> > if test no = no; then \
> >   case 'darwin15.0.0' in \
> > darwin[56]*) \
> >   need_charset_alias=true ;; \
> > darwin* | cygwin* | mingw* | pw32* | cegcc*) \
> >   need_charset_alias=false ;; \
> > *) \
> >   need_charset_alias=true ;; \
> >   esac ; \
> > else \
> >   need_charset_alias=false ; \
> > fi ; \
> > if $need_charset_alias; then \
> >   /bin/sh 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/build-aux/install-sh
> >  -d /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib ; \
> > fi ; \
> > if test -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias;
> >  then \
> >   sed -f ref-add.sed 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  > 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> >   /usr/bin/install -c -m 644 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  ; \
> >   rm -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> > else \
> >   if $need_charset_alias; then \
> > sed -f ref-add.sed charset.alias > 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> > /usr/bin/install -c -m 644 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias
> >  ; \
> > rm -f 
> > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp
> >  ; \
> >   fi ; \
> > fi
> >  ../build-aux/install-sh -c -d 
> > '/Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib'
> > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install: 
> > File exists
> > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install: 
> > Not a directory
> > make[5]: *** [install-libLIBRARIES] Error 1
> > make[4]: *** [install-am] Error 2
> > make[3]: *** [install] Error 2
> > make[2]: *** [install-recursive] Error 1
> > make[1]: *** [install] Error 2
> > ```
> > 
> > bison includes an INSTALL file, and your `--prefix` is `$dist/install` :-P

Hrm - serves me right for installing OSX on case-sensitive HFS+.
Fixed; although the AuroraBot will continue to be red due to 
https://reviews.apache.org/r/40334/


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106597
---


On Nov. 15, 2015, 9:13 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 15, 2015, 9:13 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106668
---


Master (7b494f4) is red with this patch.
  ./build-support/jenkins/build.sh

15:29:04 00:00 [ivy-imports]
15:29:04 00:00   [unpack-jars]
15:29:04 00:00 [unpack-jars]
15:29:04 00:00   [deferred-sources]
15:29:04 00:00 [deferred-sources]
15:29:04 00:00   [gen]
15:29:04 00:00 [thrift]
15:29:04 00:00 [protoc]
15:29:04 00:00 [antlr]
15:29:04 00:00 [ragel]
15:29:04 00:00 [jaxb]
15:29:04 00:00 [wire]
15:29:04 00:00   [jvm-platform-validate]
15:29:04 00:00 [jvm-platform-validate]
15:29:04 00:00   [resolve]
15:29:04 00:00 [ivy]
15:29:04 00:00   [bootstrap-nailgun-server]
15:29:05 00:01   [compile]
15:29:05 00:01 [compile]
15:29:05 00:01 [jvm]
15:29:05 00:01   [jvm-compilers]
15:29:05 00:01 [zinc-pre]
15:29:05 00:01 [zinc-post]
15:29:05 00:01 [jvm-dep-check]
15:29:05 00:01   [resources]
15:29:05 00:01 [prepare]
15:29:05 00:01 [services]
15:29:05 00:01   [test]
15:29:05 00:01 [run_prep_command]
15:29:05 00:01 [test]
15:29:05 00:01 [pytest]
15:29:05 00:01   [run]
 
15:29:07 00:03 [chroot]
15:29:11 00:07   [complete]
   FAILURE
Exception message: Could not satisfy all requirements for pytest>=2.6,<2.7:
pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)




I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 16, 2015, 3:28 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 3:28 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ---
>  build-support/thrift/Makefile   | 47 
> ++-
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/
---

(Updated Nov. 16, 2015, 10:30 a.m.)


Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
Zameer Manji.


Changes
---

Restore test_admin.py type checks and re-format client/api.

 src/main/python/apache/aurora/client/api/__init__.py | 7 +--
 src/test/python/apache/aurora/admin/test_admin.py| 6 ++
 2 files changed, 11 insertions(+), 2 deletions(-)


Bugs: AURORA-1532
https://issues.apache.org/jira/browse/AURORA-1532


Repository: aurora


Description
---

This upgrades to pants 0.0.58 to pick up the newly split off pants
python checks contrib plugin.  Release notes are here:
  https://pypi.python.org/pypi/pantsbuild.pants/0.0.58

The plugin provides both python checkstyle (`compile.pythonstyle`), and
a python eval task (`compile.python-eval`).  The `python-eval` is turned
off since at least one of the Aurora python targets has files that have
side-effects upon import (a repl is started).

Now style checks run before compile (and thus before tests) and they
benefit from fingerprinting; ie: if you test your changes, those tests
will run style checks and when you go to commit, those checks will not
be re-run by the commit hook (although files you did not test will still
need to be checked).

A few production files were fixed up according to style failures coming
from:
+ no space after comment opening '#'
+ unused variables
+ mis-aligned hanging closing parens.


Diffs (updated)
-

  build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
  build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
  build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
  build-support/python/checkstyle-check 
b2bfc5dd71193a8056828e9af05a4c16965f32a1 
  pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
  src/main/python/apache/aurora/admin/maintenance.py 
6d94c923ae37bf6b827519d3505b100af306296b 
  src/main/python/apache/aurora/client/api/__init__.py 
6f07a3073a5d422373238619d459fbd09d8adf3d 
  src/main/python/apache/aurora/client/cli/client.py 
297fb588808c1eebc32ac3374265ba986dab3436 
  src/main/python/apache/aurora/client/cli/cron.py 
6376fd014f2a4da29442b5c2c7eb36578b503ba3 
  src/main/python/apache/thermos/core/process.py 
fe95cb3be01b47616596bd78cb9a919b2e8bd978 
  src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
f1ec5a9050ac60700c4a8afa905bcf12a9bd8a44 
  src/test/python/apache/aurora/admin/test_admin.py 
8e204ab43c6bf69867ea7c32b0a7ba7fb29c0766 
  src/test/python/apache/aurora/admin/util.py 
3570407b51613d0a7b4fde8a4794d88b98e150b5 
  src/test/python/apache/aurora/client/cli/test_task.py 
5432a3d5f7e150b12bd75db0dac7a9018e1c6636 

Diff: https://reviews.apache.org/r/40310/diff/


Testing
---

See the discarded https://reviews.apache.org/r/40219/ for the
commit-hook check.  This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.


Thanks,

John Sirois

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/#review106689
---

Ship it!


Master (7b494f4) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 16, 2015, 5:30 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40310/
> ---
> 
> (Updated Nov. 16, 2015, 5:30 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
> Zameer Manji.
> 
> 
> Bugs: AURORA-1532
> https://issues.apache.org/jira/browse/AURORA-1532
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This upgrades to pants 0.0.58 to pick up the newly split off pants
> python checks contrib plugin.  Release notes are here:
>   https://pypi.python.org/pypi/pantsbuild.pants/0.0.58
> 
> The plugin provides both python checkstyle (`compile.pythonstyle`), and
> a python eval task (`compile.python-eval`).  The `python-eval` is turned
> off since at least one of the Aurora python targets has files that have
> side-effects upon import (a repl is started).
> 
> Now style checks run before compile (and thus before tests) and they
> benefit from fingerprinting; ie: if you test your changes, those tests
> will run style checks and when you go to commit, those checks will not
> be re-run by the commit hook (although files you did not test will still
> need to be checked).
> 
> A few production files were fixed up according to style failures coming
> from:
> + no space after comment opening '#'
> + unused variables
> + mis-aligned hanging closing parens.
> 
> 
> Diffs
> -
> 
>   build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
>   build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
>   build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
>   build-support/python/checkstyle-check 
> b2bfc5dd71193a8056828e9af05a4c16965f32a1 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
>   src/main/python/apache/aurora/admin/maintenance.py 
> 6d94c923ae37bf6b827519d3505b100af306296b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 6f07a3073a5d422373238619d459fbd09d8adf3d 
>   src/main/python/apache/aurora/client/cli/client.py 
> 297fb588808c1eebc32ac3374265ba986dab3436 
>   src/main/python/apache/aurora/client/cli/cron.py 
> 6376fd014f2a4da29442b5c2c7eb36578b503ba3 
>   src/main/python/apache/thermos/core/process.py 
> fe95cb3be01b47616596bd78cb9a919b2e8bd978 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> f1ec5a9050ac60700c4a8afa905bcf12a9bd8a44 
>   src/test/python/apache/aurora/admin/test_admin.py 
> 8e204ab43c6bf69867ea7c32b0a7ba7fb29c0766 
>   src/test/python/apache/aurora/admin/util.py 
> 3570407b51613d0a7b4fde8a4794d88b98e150b5 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> 5432a3d5f7e150b12bd75db0dac7a9018e1c6636 
> 
> Diff: https://reviews.apache.org/r/40310/diff/
> 
> 
> Testing
> ---
> 
> See the discarded https://reviews.apache.org/r/40219/ for the
> commit-hook check.  This version of that RB engages the same code
> and this RB commit was vetted by the same commit-hook.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40324/
---

(Updated Nov. 16, 2015, 10:42 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Bugs: AURORA-1538
https://issues.apache.org/jira/browse/AURORA-1538


Repository: aurora


Description
---

This lifts `mesos.interface` and `mesos.native` out of
`requirements.txt`, ties their versions together and isolates the
custom repository needed by `mesos.native` to its `python_requirement`.

 3rdparty/python/BUILD| 26 ++
 3rdparty/python/requirements.txt |  2 --
 pants.ini|  5 -
 3 files changed, 26 insertions(+), 7 deletions(-)


Diffs
-

  3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 
  3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e 
  examples/vagrant/provision-dev-cluster.sh 
4474543bac16ac5af0de1f199e36e8b981d52e04 
  pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 

Diff: https://reviews.apache.org/r/40324/diff/


Testing
---

Successfully ran end-to-end with this change using a fresh vagrant
image and clean repo via:
```
vagrant destroy && \
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```


Thanks,

John Sirois

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/#review106694
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 16, 2015, 5:30 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40310/
> ---
> 
> (Updated Nov. 16, 2015, 5:30 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
> Zameer Manji.
> 
> 
> Bugs: AURORA-1532
> https://issues.apache.org/jira/browse/AURORA-1532
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This upgrades to pants 0.0.58 to pick up the newly split off pants
> python checks contrib plugin.  Release notes are here:
>   https://pypi.python.org/pypi/pantsbuild.pants/0.0.58
> 
> The plugin provides both python checkstyle (`compile.pythonstyle`), and
> a python eval task (`compile.python-eval`).  The `python-eval` is turned
> off since at least one of the Aurora python targets has files that have
> side-effects upon import (a repl is started).
> 
> Now style checks run before compile (and thus before tests) and they
> benefit from fingerprinting; ie: if you test your changes, those tests
> will run style checks and when you go to commit, those checks will not
> be re-run by the commit hook (although files you did not test will still
> need to be checked).
> 
> A few production files were fixed up according to style failures coming
> from:
> + no space after comment opening '#'
> + unused variables
> + mis-aligned hanging closing parens.
> 
> 
> Diffs
> -
> 
>   build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
>   build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
>   build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
>   build-support/python/checkstyle-check 
> b2bfc5dd71193a8056828e9af05a4c16965f32a1 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
>   src/main/python/apache/aurora/admin/maintenance.py 
> 6d94c923ae37bf6b827519d3505b100af306296b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 6f07a3073a5d422373238619d459fbd09d8adf3d 
>   src/main/python/apache/aurora/client/cli/client.py 
> 297fb588808c1eebc32ac3374265ba986dab3436 
>   src/main/python/apache/aurora/client/cli/cron.py 
> 6376fd014f2a4da29442b5c2c7eb36578b503ba3 
>   src/main/python/apache/thermos/core/process.py 
> fe95cb3be01b47616596bd78cb9a919b2e8bd978 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> f1ec5a9050ac60700c4a8afa905bcf12a9bd8a44 
>   src/test/python/apache/aurora/admin/test_admin.py 
> 8e204ab43c6bf69867ea7c32b0a7ba7fb29c0766 
>   src/test/python/apache/aurora/admin/util.py 
> 3570407b51613d0a7b4fde8a4794d88b98e150b5 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> 5432a3d5f7e150b12bd75db0dac7a9018e1c6636 
> 
> Diff: https://reviews.apache.org/r/40310/diff/
> 
> 
> Testing
> ---
> 
> See the discarded https://reviews.apache.org/r/40219/ for the
> commit-hook check.  This version of that RB engages the same code
> and this RB commit was vetted by the same commit-hook.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread John Sirois 


> On Nov. 16, 2015, 9:27 a.m., Joshua Cohen wrote:
> > src/test/python/apache/aurora/admin/test_admin.py, lines 158-160
> > 
> >
> > Why kill this? It seems like the intention was to ensure that set quota 
> > is called with the correct types, but the assert above still passes if we 
> > were to do `assert_called_with(role, 24, 4001.0, 6001.0)`, thus the 
> > explicit type checks were necessary?

Ah right - I was thinking this was a tautology but its not, `24.0 == 24` is 
`True`.
This action on my part was triggered by:
```
10:08:08 00:00   [compile]
10:08:08 00:00 [python-eval]
10:08:08 00:00 [pythonstyle]
   Invalidated 9 targets.
E721:ERROR   src/test/python/apache/aurora/admin/test_admin.py:158 do not 
compare types, use 'isinstance()'
 |  assert type(api.set_quota.call_args[0][1]) == type(float())
```

I've switched to isinstance which also checks what you want; ie: 
`isinstance(24.0, int)` fails, etc.


> On Nov. 16, 2015, 9:27 a.m., Joshua Cohen wrote:
> > pants.ini, line 19
> > 
> >
> > nit: fix indent?

You'll need to give me exact direction, -1 or +N or pull up onto the end of the 
prior line.  There must be some whitespace indent per ConfigParser rules to 
keep this as a single value.


> On Nov. 16, 2015, 9:27 a.m., Joshua Cohen wrote:
> > pants.ini, line 77
> > 
> >
> > or maybe this identation style is intentional/correct?

Ah - yes, the indent is intentional / required.  The indent is required as 
explained above, but the amount of indent is a style thing and your call.


> On Nov. 16, 2015, 9:27 a.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/api/__init__.py, lines 283-284
> > 
> >
> > alternately this should validate and save the interim var?
> > 
> > return Restarter(
> > job_key,
> > updater_config,
> > ...
> > self._scheduler_proxy).restart(instances)

I couldn't follow the comment, but did change the style to the one you 
demonstrated.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/#review106674
---


On Nov. 15, 2015, 9:02 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40310/
> ---
> 
> (Updated Nov. 15, 2015, 9:02 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
> Zameer Manji.
> 
> 
> Bugs: AURORA-1532
> https://issues.apache.org/jira/browse/AURORA-1532
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This upgrades to pants 0.0.58 to pick up the newly split off pants
> python checks contrib plugin.  Release notes are here:
>   https://pypi.python.org/pypi/pantsbuild.pants/0.0.58
> 
> The plugin provides both python checkstyle (`compile.pythonstyle`), and
> a python eval task (`compile.python-eval`).  The `python-eval` is turned
> off since at least one of the Aurora python targets has files that have
> side-effects upon import (a repl is started).
> 
> Now style checks run before compile (and thus before tests) and they
> benefit from fingerprinting; ie: if you test your changes, those tests
> will run style checks and when you go to commit, those checks will not
> be re-run by the commit hook (although files you did not test will still
> need to be checked).
> 
> A few production files were fixed up according to style failures coming
> from:
> + no space after comment opening '#'
> + unused variables
> + mis-aligned hanging closing parens.
> 
> 
> Diffs
> -
> 
>   build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
>   build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
>   build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
>   build-support/python/checkstyle-check 
> b2bfc5dd71193a8056828e9af05a4c16965f32a1 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
>   src/main/python/apache/aurora/admin/maintenance.py 
> 6d94c923ae37bf6b827519d3505b100af306296b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 6f07a3073a5d422373238619d459fbd09d8adf3d 
>   src/main/python/apache/aurora/client/cli/client.py 
> 297fb588808c1eebc32ac3374265ba986dab3436 
>   src/main/python/apache/aurora/client/cli/cron.py 
> 6376fd014f2a4da29442b5c2c7eb36578b503ba3 
>   src/main/python/apache/thermos/core/process.py 
> fe95cb3be01b47616596bd78cb9a919b2e8bd978 
>

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

2015-11-16 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40324/#review106693
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 16, 2015, 5:42 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40324/
> ---
> 
> (Updated Nov. 16, 2015, 5:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1538
> https://issues.apache.org/jira/browse/AURORA-1538
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This lifts `mesos.interface` and `mesos.native` out of
> `requirements.txt`, ties their versions together and isolates the
> custom repository needed by `mesos.native` to its `python_requirement`.
> 
>  3rdparty/python/BUILD| 26 ++
>  3rdparty/python/requirements.txt |  2 --
>  pants.ini|  5 -
>  3 files changed, 26 insertions(+), 7 deletions(-)
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 
>   3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e 
>   examples/vagrant/provision-dev-cluster.sh 
> 4474543bac16ac5af0de1f199e36e8b981d52e04 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
> 
> Diff: https://reviews.apache.org/r/40324/diff/
> 
> 
> Testing
> ---
> 
> Successfully ran end-to-end with this change using a fresh vagrant
> image and clean repo via:
> ```
> vagrant destroy && \
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

2015-11-16 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40334/#review106712
---

Ship it!


Ship It!

- Zameer Manji


On Nov. 15, 2015, 3:36 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40334/
> ---
> 
> (Updated Nov. 15, 2015, 3:36 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The problem is described here:
>   https://github.com/pantsbuild/pants/issues/2566
> 
> Changelogs are here:
>   https://pypi.python.org/pypi/pantsbuild.pants/0.0.59
> 
>  pants.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
> 
> Diff: https://reviews.apache.org/r/40334/diff/
> 
> 
> Testing
> ---
> 
> Before the fix stumbled into this:
> ```
> $ ./build-support/jenkins/build.sh
> ...
> 11:22:51 00:00   [test]
> 11:22:51 00:00 [run_prep_command]
> 11:22:51 00:00 [test]
> 11:22:51 00:00 [pytest]
> 11:22:51 00:00   [run]
> 
> 11:23:04 00:13 [chroot]
> 11:23:11 00:20   [complete]
>FAILURE
> 
> Exception message: Could not satisfy all requirements for pytest>=2.6,<2.7:
> pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)
> ```
> 
> That triggered a bit of a pants release firefight leading
> to this RB and one for Medium's mono repo as well as patching
> of the fix in at Square. Now
> `./build-support/jenkins/build.sh` runs green as well.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/
---

(Updated Nov. 16, 2015, 1:05 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Fixup BISON_PREFIX to use a unique (case aside) dirent name.

 build-support/thrift/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Repository: aurora


Description
---

This improves the isolation of the thrift build by building a local
pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
Linux, a rolling release that is otherwise too modern in its libs to
successfully build thrift 0.9.1.

Additionally, this change knocks out the checksumming TODO and now
checks all downloaded tarballs meet their expected hashes.  The
hashes were generated locally after checking the sha1's where
available.

 build-support/thrift/.gitignore |  7 ---
 build-support/thrift/Makefile   | 47 
++-
 2 files changed, 42 insertions(+), 12 deletions(-)


Diffs (updated)
-

  build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
  build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 

Diff: https://reviews.apache.org/r/40323/diff/


Testing
---

I can now run `./build-support/jenkins/build.sh` green locally.

I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.


Thanks,

John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 


> On Nov. 16, 2015, 3:18 p.m., Zameer Manji wrote:
> > build-support/thrift/Makefile, line 28
> > 
> >
> > The ticket says this patch was committed in 0.9.2. Would it be more 
> > productive to upgrade to 0.9.2+ before complicating our thrift build?
> > 
> > Not a blocker to landing this but I think it would be nice if we didn't 
> > have to download a patch for our vendored thrit.

Sadly 0.9.2 and 0.9.3 are not useable in python, details here: 
https://issues.apache.org/jira/browse/THRIFT-3388
In short, thrift folks accepted a patch they never should have that poisened 
python use for any but the vey simplest structs and service methods.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106749
---


On Nov. 16, 2015, 1:11 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 1:11 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 


> On Nov. 16, 2015, 3:18 p.m., Zameer Manji wrote:
> > build-support/thrift/Makefile, line 28
> > 
> >
> > The ticket says this patch was committed in 0.9.2. Would it be more 
> > productive to upgrade to 0.9.2+ before complicating our thrift build?
> > 
> > Not a blocker to landing this but I think it would be nice if we didn't 
> > have to download a patch for our vendored thrit.
> 
> John Sirois wrote:
> Sadly 0.9.2 and 0.9.3 are not useable in python, details here: 
> https://issues.apache.org/jira/browse/THRIFT-3388
> In short, thrift folks accepted a patch they never should have that 
> poisened python use for any but the vey simplest structs and service methods.

More info on this from the Aurora point of view is here: 
https://issues.apache.org/jira/browse/AURORA-1083


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106749
---


On Nov. 16, 2015, 1:11 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 1:11 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/
---

(Updated Nov. 16, 2015, 1:09 p.m.)


Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
Zameer Manji.


Changes
---

Restore test_admin.py type checks and re-format client/api.

 src/main/python/apache/aurora/client/api/__init__.py | 7 +--
 src/test/python/apache/aurora/admin/test_admin.py| 6 ++
 2 files changed, 11 insertions(+), 2 deletions(-)


Bugs: AURORA-1532
https://issues.apache.org/jira/browse/AURORA-1532


Repository: aurora


Description
---

This upgrades to pants 0.0.58 to pick up the newly split off pants
python checks contrib plugin.  Release notes are here:
  https://pypi.python.org/pypi/pantsbuild.pants/0.0.58

The plugin provides both python checkstyle (`compile.pythonstyle`), and
a python eval task (`compile.python-eval`).  The `python-eval` is turned
off since at least one of the Aurora python targets has files that have
side-effects upon import (a repl is started).

Now style checks run before compile (and thus before tests) and they
benefit from fingerprinting; ie: if you test your changes, those tests
will run style checks and when you go to commit, those checks will not
be re-run by the commit hook (although files you did not test will still
need to be checked).

A few production files were fixed up according to style failures coming
from:
+ no space after comment opening '#'
+ unused variables
+ mis-aligned hanging closing parens.


Diffs (updated)
-

  build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
  build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
  build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
  build-support/python/checkstyle-check 
b2bfc5dd71193a8056828e9af05a4c16965f32a1 
  pants.ini d58908ca8356e53c5317fc8fd7531d5285e21fa7 
  src/main/python/apache/aurora/admin/maintenance.py 
6d94c923ae37bf6b827519d3505b100af306296b 
  src/main/python/apache/aurora/client/api/__init__.py 
6f07a3073a5d422373238619d459fbd09d8adf3d 
  src/main/python/apache/aurora/client/cli/client.py 
297fb588808c1eebc32ac3374265ba986dab3436 
  src/main/python/apache/aurora/client/cli/cron.py 
6376fd014f2a4da29442b5c2c7eb36578b503ba3 
  src/main/python/apache/thermos/core/process.py 
fe95cb3be01b47616596bd78cb9a919b2e8bd978 
  src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
f1ec5a9050ac60700c4a8afa905bcf12a9bd8a44 
  src/test/python/apache/aurora/admin/test_admin.py 
8e204ab43c6bf69867ea7c32b0a7ba7fb29c0766 
  src/test/python/apache/aurora/admin/util.py 
3570407b51613d0a7b4fde8a4794d88b98e150b5 
  src/test/python/apache/aurora/client/cli/test_task.py 
5432a3d5f7e150b12bd75db0dac7a9018e1c6636 

Diff: https://reviews.apache.org/r/40310/diff/


Testing
---

See the discarded https://reviews.apache.org/r/40219/ for the
commit-hook check.  This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.


Thanks,

John Sirois

Re: Review Request 40220: Modernize the pex venv script.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40220/
---

(Updated Nov. 16, 2015, 1:12 p.m.)


Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.


Repository: aurora


Description (updated)
---

This converts from grabbing the old Twitter python pex to grabbing
modern pex to match the version specified in 3rdparty to help keep the
pex venv up to date with the codebase dependencies.


Diffs
-

  build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 

Diff: https://reviews.apache.org/r/40220/diff/


Testing
---

Locally ran this 2x and observed both the proper version (1.1.0) and
proper use of the cached venv in the second run:
`git clean -fdx build-support && ./build-support/pex --version`


Thanks,

John Sirois

Re: Review Request 40320: Organize executor-related code into a package.

2015-11-16 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40320/#review106709
---

Ship it!


Ship It!

- Zameer Manji


On Nov. 14, 2015, 9 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40320/
> ---
> 
> (Updated Nov. 14, 2015, 9 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is pure code shuffle, the interesting bits coming out of `SchedulerMain` 
> and into `ExecutorModule`.
> 
> Probably should have done this in https://reviews.apache.org/r/40149/, but 
> another follow-up change made it more obvious that this organization was 
> needed.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt aac822b6e2c022625432e09ad8d4097790429257 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> b4ca01b0ae751bdc8fa2d6fb7c667fe3c08ca726 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 6236a531b2bb1c9ba09840911ec6d4846cdb9393 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> fb4f0a031d3976cbd225fc050487b4002e64ae0c 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> 52776c9cb70127cb88a40f98e2c7cce192b3b5b1 
>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorConfig.java 
> b6aa2e1567c79156e1ad7270d430a6fcb282822d 
>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 
> b7f30231329fe2cf5bc72d11b1f929f394c21c6b 
>   src/main/java/org/apache/aurora/scheduler/mesos/Executors.java 
> 21152f575ed6b0cafe5739df718ef735837b19ac 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> f1c2059045624ed2486982614f9df14829a00ebc 
>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
> ad5927c9d67749a1a83640ee94d76919640a7949 
>   
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java
>  b14ab68017b0c66141f6a8bae4b0eacde841a3a2 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> da7d1e0dfb6aa8ddf452de79db8bd23491822c89 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 50853cfffab832d75f5106742d38a1864d9c6c30 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 
> a258d06cb12b2962d47dbb74a2af29281e255662 
> 
> Diff: https://reviews.apache.org/r/40320/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread John Sirois 


> On Nov. 16, 2015, 12:43 p.m., Zameer Manji wrote:
> > pants.ini, line 49
> > 
> >
> > Out of curiosity, could we replace isort with this functionality? I 
> > like the idea of collapsing all of that functionality into pants.

You could, but right now the checker is not flexible enough to match the 
current style.  So either a style thrash or else work in pants to make the 
sorting more flexible (or replaceable with isort rules internally).


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/#review106710
---


On Nov. 16, 2015, 10:30 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40310/
> ---
> 
> (Updated Nov. 16, 2015, 10:30 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
> Zameer Manji.
> 
> 
> Bugs: AURORA-1532
> https://issues.apache.org/jira/browse/AURORA-1532
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This upgrades to pants 0.0.58 to pick up the newly split off pants
> python checks contrib plugin.  Release notes are here:
>   https://pypi.python.org/pypi/pantsbuild.pants/0.0.58
> 
> The plugin provides both python checkstyle (`compile.pythonstyle`), and
> a python eval task (`compile.python-eval`).  The `python-eval` is turned
> off since at least one of the Aurora python targets has files that have
> side-effects upon import (a repl is started).
> 
> Now style checks run before compile (and thus before tests) and they
> benefit from fingerprinting; ie: if you test your changes, those tests
> will run style checks and when you go to commit, those checks will not
> be re-run by the commit hook (although files you did not test will still
> need to be checked).
> 
> A few production files were fixed up according to style failures coming
> from:
> + no space after comment opening '#'
> + unused variables
> + mis-aligned hanging closing parens.
> 
> 
> Diffs
> -
> 
>   build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
>   build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
>   build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
>   build-support/python/checkstyle-check 
> b2bfc5dd71193a8056828e9af05a4c16965f32a1 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
>   src/main/python/apache/aurora/admin/maintenance.py 
> 6d94c923ae37bf6b827519d3505b100af306296b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 6f07a3073a5d422373238619d459fbd09d8adf3d 
>   src/main/python/apache/aurora/client/cli/client.py 
> 297fb588808c1eebc32ac3374265ba986dab3436 
>   src/main/python/apache/aurora/client/cli/cron.py 
> 6376fd014f2a4da29442b5c2c7eb36578b503ba3 
>   src/main/python/apache/thermos/core/process.py 
> fe95cb3be01b47616596bd78cb9a919b2e8bd978 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> f1ec5a9050ac60700c4a8afa905bcf12a9bd8a44 
>   src/test/python/apache/aurora/admin/test_admin.py 
> 8e204ab43c6bf69867ea7c32b0a7ba7fb29c0766 
>   src/test/python/apache/aurora/admin/util.py 
> 3570407b51613d0a7b4fde8a4794d88b98e150b5 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> 5432a3d5f7e150b12bd75db0dac7a9018e1c6636 
> 
> Diff: https://reviews.apache.org/r/40310/diff/
> 
> 
> Testing
> ---
> 
> See the discarded https://reviews.apache.org/r/40219/ for the
> commit-hook check.  This version of that RB engages the same code
> and this RB commit was vetted by the same commit-hook.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/
---

(Updated Nov. 16, 2015, 1:11 p.m.)


Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
Zameer Manji.


Bugs: AURORA-1532
https://issues.apache.org/jira/browse/AURORA-1532


Repository: aurora


Description (updated)
---

This installs the ~newly split off pants python checks contrib plugin.
Release notes for that were here:
  https://pypi.python.org/pypi/pantsbuild.pants/0.0.58

The plugin provides both python checkstyle (`compile.pythonstyle`), and
a python eval task (`compile.python-eval`).  The `python-eval` is turned
off since at least one of the Aurora python targets has files that have
side-effects upon import (a repl is started).

Now style checks run before compile (and thus before tests) and they
benefit from fingerprinting; ie: if you test your changes, those tests
will run style checks and when you go to commit, those checks will not
be re-run by the commit hook (although files you did not test will still
need to be checked).

A few production files were fixed up according to style failures coming
from:
+ no space after comment opening '#'
+ unused variables
+ mis-aligned hanging closing parens.


Diffs
-

  build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
  build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
  build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
  build-support/python/checkstyle-check 
b2bfc5dd71193a8056828e9af05a4c16965f32a1 
  pants.ini d58908ca8356e53c5317fc8fd7531d5285e21fa7 
  src/main/python/apache/aurora/admin/maintenance.py 
6d94c923ae37bf6b827519d3505b100af306296b 
  src/main/python/apache/aurora/client/api/__init__.py 
6f07a3073a5d422373238619d459fbd09d8adf3d 
  src/main/python/apache/aurora/client/cli/client.py 
297fb588808c1eebc32ac3374265ba986dab3436 
  src/main/python/apache/aurora/client/cli/cron.py 
6376fd014f2a4da29442b5c2c7eb36578b503ba3 
  src/main/python/apache/thermos/core/process.py 
fe95cb3be01b47616596bd78cb9a919b2e8bd978 
  src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
f1ec5a9050ac60700c4a8afa905bcf12a9bd8a44 
  src/test/python/apache/aurora/admin/test_admin.py 
8e204ab43c6bf69867ea7c32b0a7ba7fb29c0766 
  src/test/python/apache/aurora/admin/util.py 
3570407b51613d0a7b4fde8a4794d88b98e150b5 
  src/test/python/apache/aurora/client/cli/test_task.py 
5432a3d5f7e150b12bd75db0dac7a9018e1c6636 

Diff: https://reviews.apache.org/r/40310/diff/


Testing
---

See the discarded https://reviews.apache.org/r/40219/ for the
commit-hook check.  This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.


Thanks,

John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/
---

(Updated Nov. 16, 2015, 1:11 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Repository: aurora


Description (updated)
---

This improves the isolation of the thrift build by building a local
pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
Linux, a rolling release that is otherwise too modern in its libs to
successfully build thrift 0.9.1.

Additionally, this change knocks out the checksumming TODO and now
checks all downloaded tarballs meet their expected hashes.  The
hashes were generated locally after checking the sha1's where
available.


Diffs
-

  build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
  build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 

Diff: https://reviews.apache.org/r/40323/diff/


Testing
---

I can now run `./build-support/jenkins/build.sh` green locally.

I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.


Thanks,

John Sirois

Re: Review Request 40201: Cleanup thermos_executor test pexes.

2015-11-16 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40201/
---

(Updated Nov. 16, 2015, 1:12 p.m.)


Review request for Aurora, Joshua Cohen, Kevin Sweeney, Brian Wickman, and 
Zameer Manji.


Bugs: AURORA-547
https://issues.apache.org/jira/browse/AURORA-547


Repository: aurora


Description (updated)
---

Previously these were built to the standard `dist/` dir, now they are
dumped to a tmp dir that's cleaned up.


Diffs
-

  src/test/python/apache/aurora/executor/test_thermos_executor.py 
d24c61162e11bb4afef2902ebb031478fe3ed247 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
bb998c0b0ac87ba51ec13e490338b00e7f85e8cf 

Diff: https://reviews.apache.org/r/40201/diff/


Testing
---

Green locally:
```
$ rm -rf dist/ && \
  ./pants test.pytest --no-fast src/test/python/apache/aurora/executor:
```

And no `dist/` created.


Thanks,

John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106726
---

Ship it!


Master (86761e8) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 16, 2015, 8:11 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> ---
> 
> (Updated Nov. 16, 2015, 8:11 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
> 
> Diffs
> -
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> ---
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/#review106710
---

Ship it!


LGTM.


pants.ini (line 49)


Out of curiosity, could we replace isort with this functionality? I like 
the idea of collapsing all of that functionality into pants.


- Zameer Manji


On Nov. 16, 2015, 9:30 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40310/
> ---
> 
> (Updated Nov. 16, 2015, 9:30 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, Maxim Khutornenko, and 
> Zameer Manji.
> 
> 
> Bugs: AURORA-1532
> https://issues.apache.org/jira/browse/AURORA-1532
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This upgrades to pants 0.0.58 to pick up the newly split off pants
> python checks contrib plugin.  Release notes are here:
>   https://pypi.python.org/pypi/pantsbuild.pants/0.0.58
> 
> The plugin provides both python checkstyle (`compile.pythonstyle`), and
> a python eval task (`compile.python-eval`).  The `python-eval` is turned
> off since at least one of the Aurora python targets has files that have
> side-effects upon import (a repl is started).
> 
> Now style checks run before compile (and thus before tests) and they
> benefit from fingerprinting; ie: if you test your changes, those tests
> will run style checks and when you go to commit, those checks will not
> be re-run by the commit hook (although files you did not test will still
> need to be checked).
> 
> A few production files were fixed up according to style failures coming
> from:
> + no space after comment opening '#'
> + unused variables
> + mis-aligned hanging closing parens.
> 
> 
> Diffs
> -
> 
>   build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
>   build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
>   build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
>   build-support/python/checkstyle-check 
> b2bfc5dd71193a8056828e9af05a4c16965f32a1 
>   pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
>   src/main/python/apache/aurora/admin/maintenance.py 
> 6d94c923ae37bf6b827519d3505b100af306296b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 6f07a3073a5d422373238619d459fbd09d8adf3d 
>   src/main/python/apache/aurora/client/cli/client.py 
> 297fb588808c1eebc32ac3374265ba986dab3436 
>   src/main/python/apache/aurora/client/cli/cron.py 
> 6376fd014f2a4da29442b5c2c7eb36578b503ba3 
>   src/main/python/apache/thermos/core/process.py 
> fe95cb3be01b47616596bd78cb9a919b2e8bd978 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> f1ec5a9050ac60700c4a8afa905bcf12a9bd8a44 
>   src/test/python/apache/aurora/admin/test_admin.py 
> 8e204ab43c6bf69867ea7c32b0a7ba7fb29c0766 
>   src/test/python/apache/aurora/admin/util.py 
> 3570407b51613d0a7b4fde8a4794d88b98e150b5 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> 5432a3d5f7e150b12bd75db0dac7a9018e1c6636 
> 
> Diff: https://reviews.apache.org/r/40310/diff/
> 
> 
> Testing
> ---
> 
> See the discarded https://reviews.apache.org/r/40219/ for the
> commit-hook check.  This version of that RB engages the same code
> and this RB commit was vetted by the same commit-hook.
> 
> 
> Thanks,
> 
> John Sirois
> 
>