Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41528/#review57
---

Ship it!


Thanks for looking into this!

- Stephan Erb


On Dec. 17, 2015, 10:27 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41528/
> ---
> 
> (Updated Dec. 17, 2015, 10:27 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1385
> https://issues.apache.org/jira/browse/AURORA-1385
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Previously,  the fact `null` could be returned by Quartz when
> calculating the next run was not taken into account.  Now The
> CronPredictor interface makes this possibility manifest with an
> Optional result.
> 
> Code that uses the CronPredictor is adjusted and tests are added.
> 
> NB: This code is as first proposed here by Brice Arnould with small
> changes: https://reviews.apache.org/r/39170/
> 
>  src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java
> | 10 --
>  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java 
> |  8 +---
>  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java  
> | 13 -
>  
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImplTest.java
>  | 23 +++
>  
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>   | 35 ---
>  5 files changed, 72 insertions(+), 17 deletions(-)
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java 
> 043ba7e6858db28001dfb07ea0c2ddf274a1c755 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java 
> 1ddc4e1946910de798f7f423dd1b19ed56dece15 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> c0e8a201400338a8cb6bc24b2c21d0abb0d01e41 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImplTest.java
>  b85f4abd59ef64264fb089527ad42b9ceee7f8d6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  6efe03fe4841cf1275e2ee0c7cc1b9576540f34e 
> 
> Diff: https://reviews.apache.org/r/41528/diff/
> 
> 
> Testing
> ---
> 
> Green locally: `./gradlew -Pq build`
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 41559: Fix the ZK URI in the rpm.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41559/#review111226
---


1 more - README needs updating:
```
$ git grep "zk:"
specs/debian/aurora-scheduler.default:MESOS_MASTER="zk://${ZK_ENDPOINTS}/mesos"
specs/rpm/SOURCES/aurora.sysconfig:  
-mesos_master_address='zk://127.0.0.1:2181/mesos/master'
test/rpm/centos-7/README.md:sudo sed -i 
's|zk://127.0.0.1:2181/mesos/master|zk://127.0.0.1:2181/mesos|g' 
/etc/sysconfig/aurora
```

- John Sirois


On Dec. 18, 2015, 11:35 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41559/
> ---
> 
> (Updated Dec. 18, 2015, 11:35 a.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> ```
> $ grep -R 'zk://' .
> ./specs/debian/aurora-scheduler.default:MESOS_MASTER="zk://${ZK_ENDPOINTS}/mesos"
> ./specs/rpm/SOURCES/aurora.sysconfig:  
> -mesos_master_address='zk://127.0.0.1:2181/mesos'
> ```
> 
> 
> Diffs
> -
> 
>   specs/rpm/SOURCES/aurora.sysconfig cef427a411e310454b809fe6046d4522bd8015a7 
>   test/rpm/centos-7/README.md cd3ce52f8d78bcb1f11f3388140040aeb29a62a7 
> 
> Diff: https://reviews.apache.org/r/41559/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[Maxim Khutornenko]

> On Dec. 18, 2015, 8:11 p.m., Maxim Khutornenko wrote:
> > docs/installing.md, line 58
> > 
> >
> > This is very important part of our infrastructure. I'd add a bit more 
> > details here highlighting its importance (including scheduler->master 
> > discovery).
> 
> Bill Farner wrote:
> I don't think explaining the importance of a component is valuable or 
> objective detail in this document.  IMHO this document is best as a recipe 
> for getting something working.

Wasn't suggesting an elaborate explanation, just a bit of additional info 
around discovery and leader election, e.g.: "...used for discovering Mesos 
master and scheduler leader election".


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111253
---


On Dec. 18, 2015, 7:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 18, 2015, 7:58 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/
---

(Updated Dec. 18, 2015, 12:38 p.m.)


Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.


Repository: aurora


Description
---

Add a guide for installing Aurora.


Diffs (updated)
-

  README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
  docs/installing.md PRE-CREATION 

Diff: https://reviews.apache.org/r/41564/diff/


Testing
---

Rendered here: 
https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md

I could use more eyes and independent trials on the installation steps.


Thanks,

Bill Farner

Re: Review Request 41564: Add a guide for installing Aurora.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111253
---



docs/installing.md (line 58)


This is very important part of our infrastructure. I'd add a bit more 
details here highlighting its importance (including scheduler->master 
discovery).


- Maxim Khutornenko


On Dec. 18, 2015, 7:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 18, 2015, 7:58 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 41565: Improve review_feedback.py testability.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41565/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Support host-or-base-url for easier local non-https testing.
Don't require a defaulted arg and don't require --git-clean-excludes.

 build-support/jenkins/review_feedback.py | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)


Diffs
-

  build-support/jenkins/review_feedback.py 
fcf574ab508e87992440b873e80744040658181e 

Diff: https://reviews.apache.org/r/41565/diff/


Testing
---

Locally against a local RB install:
```
$ ./build-support/jenkins/review_feedback.py --server http://localhost: 
--repository aurora --reviewboard-credentials-file ~/.aurorabot.creds --command 
true
Request: http://localhost:/api/repositories/?name=aurora
Request: http://localhost:/api/review-requests/?status=pending=1
Found 1 review requests to inspect
Inspecting review 2: Support host-or-base-url for easier local non-https 
testing.
Request: http://localhost:/api/review-requests/2/reviews/
Request: http://localhost:/api/review-requests/2/diffs/
Latest feedback was given at2015-12-16T18:50:13Z
Latest build request from a user at 2015-12-16T18:50:13Z
Latest diff was posted at   2015-12-16T18:49:55Z
```


Thanks,

John Sirois

Re: Review Request 41565: Improve review_feedback.py testability.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41565/#review111257
---

Ship it!


Master (1c73438) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 18, 2015, 8 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41565/
> ---
> 
> (Updated Dec. 18, 2015, 8 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support host-or-base-url for easier local non-https testing.
> Don't require a defaulted arg and don't require --git-clean-excludes.
> 
>  build-support/jenkins/review_feedback.py | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> fcf574ab508e87992440b873e80744040658181e 
> 
> Diff: https://reviews.apache.org/r/41565/diff/
> 
> 
> Testing
> ---
> 
> Locally against a local RB install:
> ```
> $ ./build-support/jenkins/review_feedback.py --server http://localhost: 
> --repository aurora --reviewboard-credentials-file ~/.aurorabot.creds 
> --command true
> Request: http://localhost:/api/repositories/?name=aurora
> Request: 
> http://localhost:/api/review-requests/?status=pending=1
> Found 1 review requests to inspect
> Inspecting review 2: Support host-or-base-url for easier local non-https 
> testing.
> Request: http://localhost:/api/review-requests/2/reviews/
> Request: http://localhost:/api/review-requests/2/diffs/
> Latest feedback was given at2015-12-16T18:50:13Z
> Latest build request from a user at 2015-12-16T18:50:13Z
> Latest diff was posted at   2015-12-16T18:49:55Z
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111251
---



docs/installing.md (line 155)


believing



docs/installing.md (line 157)


Should there be a service stop issued 1st?
Also Ubuntu 14.04 uses upstart, so you might either suggest the below is a 
Centos 7 example and the start command may need to be adjusted - or else give 
and example for each OS.


- John Sirois


On Dec. 18, 2015, 12:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 18, 2015, 12:58 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41565: Improve review_feedback.py testability.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41565/#review111259
---

Ship it!


- Bill Farner


On Dec. 18, 2015, noon, John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41565/
> ---
> 
> (Updated Dec. 18, 2015, noon)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support host-or-base-url for easier local non-https testing.
> Don't require a defaulted arg and don't require --git-clean-excludes.
> 
>  build-support/jenkins/review_feedback.py | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> fcf574ab508e87992440b873e80744040658181e 
> 
> Diff: https://reviews.apache.org/r/41565/diff/
> 
> 
> Testing
> ---
> 
> Locally against a local RB install:
> ```
> $ ./build-support/jenkins/review_feedback.py --server http://localhost: 
> --repository aurora --reviewboard-credentials-file ~/.aurorabot.creds 
> --command true
> Request: http://localhost:/api/repositories/?name=aurora
> Request: 
> http://localhost:/api/review-requests/?status=pending=1
> Found 1 review requests to inspect
> Inspecting review 2: Support host-or-base-url for easier local non-https 
> testing.
> Request: http://localhost:/api/review-requests/2/reviews/
> Request: http://localhost:/api/review-requests/2/diffs/
> Latest feedback was given at2015-12-16T18:50:13Z
> Latest build request from a user at 2015-12-16T18:50:13Z
> Latest diff was posted at   2015-12-16T18:49:55Z
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[Bill Farner]

> On Dec. 18, 2015, 12:11 p.m., Maxim Khutornenko wrote:
> > docs/installing.md, line 58
> > 
> >
> > This is very important part of our infrastructure. I'd add a bit more 
> > details here highlighting its importance (including scheduler->master 
> > discovery).

I don't think explaining the importance of a component is valuable or objective 
detail in this document.  IMHO this document is best as a recipe for getting 
something working.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111253
---


On Dec. 18, 2015, 11:58 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 18, 2015, 11:58 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[Bill Farner]

> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 29
> > 
> >
> > You are happily mixing the terms jobs and services here. Other sections 
> > of this document also use the word task. It is obvious for us that these 
> > are basically the same thing. However, for people new to Aurora this might 
> > be confusing.

Thanks, reworded.


> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 35
> > 
> >
> > Have you thought about adding an additional section regarding the 
> > aurora config files? Even a simple guideline can be quite helpful for 
> > starters,  like you have one config file per service/job and that these 
> > files are commonly tracked in a git repository.

I see what you mean.  I'd like to avoid a slippery slope wherein this becomes 
encyclopedic, but how about a brief mention and a link to the configuration 
guide? (Added in latest draft.)


> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 44
> > 
> >
> > I think we should extend this section slightly: 
> > 
> > * it should somehow contain the word `thermos` as it is used in the 
> > rest of the Aurora documentation quite often
> > * it could stress a little bit more that this executes the user 
> > processes

Great suggestions, done.


> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 66
> > 
> >
> > A common confusion for Mesos adopters seems to be the relation between 
> > the agent and an executor. We could state here that the agent spaws 
> > executors which in turn runs the user code (either on the physical host or 
> > within a docker container).

Done.


> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 77
> > 
> >
> > When getting started, it is quite difficult to decide whether to 
> > co-locate all those services for simplicity or to keep them seperated for 
> > isolation, security, performance reasons etc. Is there any further advice 
> > we could give here?

Done.


> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 146
> > 
> >
> > Isn't that outdated?
> 
> John Sirois wrote:
> I think so - I used `sudo yum install -y mesos-0.23` for this step.

I left this at 0.22.0 because that's what the 0.9.0 rpm currently relies on:

```
Error: Package: aurora-0.9.0-1.el7.centos.aurora.x86_64 (apache-aurora-wfarner)
   Requires: mesos = 0.22.0
```


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111273
---


On Dec. 18, 2015, 12:39 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 18, 2015, 12:39 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111322
---


Not as thorough a check of Ubuntu, but so far:


docs/installing.md (line 126)


Had to s/ mesos// and then:
```
wget -c 
http://downloads.mesosphere.io/master/ubuntu/14.04/mesos_0.23.0-1.0.ubuntu1404_amd64.deb
sudo dpkg -i mesos_0.23.0-1.0.ubuntu1404_amd64.deb
sudo start mesos-master
```



docs/installing.md (line 130)


This looks fine although I used:
```
wget -c http://apache.bintray.com/aurora/aurora-scheduler_0.10.0-1_amd64.deb
sudo dpkg -i aurora-scheduler_0.10.0-1_amd64.deb
```



docs/installing.md (line 189)


Missing equivalent using 
https://apache.bintray.com/aurora/:aurora-executor_0.10.0-1_amd64.deb for 
Ubuntu.



docs/installing.md (line 200)


Looks fine although I used:
```
wget -c https://apache.bintray.com/aurora/aurora-tools_0.10.0-1_amd64.deb
sudo dpkg -i aurora-tools_0.10.0-1_amd64.deb
```


- John Sirois


On Dec. 18, 2015, 1:39 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 18, 2015, 1:39 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111296
---


The comments below are from a test of CentOS 7 instructions - using the aurora 
0.10.0-1 packages.


docs/installing.md (line 111)


Invalid URL - I updated to 
http://people.apache.org/~wfarner/aurora/distributions/0.10.0-1/rpm/centos-7/ 
to get things working



docs/installing.md (line 141)


s/zookeeper-serve/zookeeper-server/ - also this requires java (8 for aurora 
later).  It would be good to call out the need to have java 8 installed or else 
just re-order the steps since the aurora package properly depends on java (8) 
and the zk package does not properly depend on java.

I used this fwiw:
```
sudo yum install -y java-1.8.0-openjdk
```



docs/installing.md (line 150)


s/aurora/aurora-scheduler/



docs/installing.md (line 189)


s/aurora-thermos/aurora-executor/


- John Sirois


On Dec. 18, 2015, 1:39 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 18, 2015, 1:39 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[John Sirois]

> On Dec. 18, 2015, 3:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 146
> > 
> >
> > Isn't that outdated?

I think so - I used `sudo yum install -y mesos-0.23` for this step.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111273
---


On Dec. 18, 2015, 1:39 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 18, 2015, 1:39 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111270
---

Ship it!


Master (5183fe0) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 18, 2015, 8:39 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 18, 2015, 8:39 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[Stephan Erb]

> On Dez. 18, 2015, 9:12 nachm., John Sirois wrote:
> >
> 
> John Sirois wrote:
> I won't be able to get to trials until later this evening.  Ideally 
> though this doc could be tied to the test/ provision.sh's somehow for more 
> assured working-ness.  I have no useful suggestion though atm of how to do 
> that reasonably.

That would be ideal. The install instructions might get outdated rather easily.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111251
---


On Dez. 18, 2015, 9:39 nachm., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dez. 18, 2015, 9:39 nachm.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[Bill Farner]

> On Dec. 18, 2015, 4:43 p.m., John Sirois wrote:
> > docs/installing.md, line 126
> > 
> >
> > Had to s/ mesos// and then:
> > ```
> > wget -c 
> > http://downloads.mesosphere.io/master/ubuntu/14.04/mesos_0.23.0-1.0.ubuntu1404_amd64.deb
> > sudo dpkg -i mesos_0.23.0-1.0.ubuntu1404_amd64.deb
> > sudo start mesos-master
> > ```

Wow, yeah...i must have stopped mid-thought here.  Thanks.


> On Dec. 18, 2015, 4:43 p.m., John Sirois wrote:
> > docs/installing.md, line 130
> > 
> >
> > This looks fine although I used:
> > ```
> > wget -c 
> > http://apache.bintray.com/aurora/aurora-scheduler_0.10.0-1_amd64.deb
> > sudo dpkg -i aurora-scheduler_0.10.0-1_amd64.deb
> > ```

Heh, thanks.  Hot off the presses :-)

Didn't realize bintray had those shorter URLs, sweet!

Updated.


> On Dec. 18, 2015, 4:43 p.m., John Sirois wrote:
> > docs/installing.md, line 189
> > 
> >
> > Missing equivalent using 
> > https://apache.bintray.com/aurora/:aurora-executor_0.10.0-1_amd64.deb for 
> > Ubuntu.

Thanks, fixed.


> On Dec. 18, 2015, 4:43 p.m., John Sirois wrote:
> > docs/installing.md, line 200
> > 
> >
> > Looks fine although I used:
> > ```
> > wget -c 
> > https://apache.bintray.com/aurora/aurora-tools_0.10.0-1_amd64.deb
> > sudo dpkg -i aurora-tools_0.10.0-1_amd64.deb
> > ```

Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111322
---


On Dec. 18, 2015, 12:39 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 18, 2015, 12:39 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111354
---

Ship it!


Master (5183fe0) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 19, 2015, 3:03 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 19, 2015, 3:03 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[Bill Farner]

> On Dec. 18, 2015, 3:45 p.m., John Sirois wrote:
> > docs/installing.md, line 111
> > 
> >
> > Invalid URL - I updated to 
> > http://people.apache.org/~wfarner/aurora/distributions/0.10.0-1/rpm/centos-7/
> >  to get things working

Doh, thanks.  This was a bad find/replace.


> On Dec. 18, 2015, 3:45 p.m., John Sirois wrote:
> > docs/installing.md, line 141
> > 
> >
> > s/zookeeper-serve/zookeeper-server/ - also this requires java (8 for 
> > aurora later).  It would be good to call out the need to have java 8 
> > installed or else just re-order the steps since the aurora package properly 
> > depends on java (8) and the zk package does not properly depend on java.
> > 
> > I used this fwiw:
> > ```
> > sudo yum install -y java-1.8.0-openjdk
> > ```

Thanks, done.  Went with `java-1.8.0-openjdk-headless`.


> On Dec. 18, 2015, 3:45 p.m., John Sirois wrote:
> > docs/installing.md, line 150
> > 
> >
> > s/aurora/aurora-scheduler/

Done.  Since the 0.9.0 RPM mentioned earlier uses the `aurora` name, i've left 
a note so people don't get tripped up.


> On Dec. 18, 2015, 3:45 p.m., John Sirois wrote:
> > docs/installing.md, line 189
> > 
> >
> > s/aurora-thermos/aurora-executor/

Thanks.  Ditto re: naming.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111296
---


On Dec. 18, 2015, 12:39 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> ---
> 
> (Updated Dec. 18, 2015, 12:39 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41564: Add a guide for installing Aurora.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/
---

(Updated Dec. 18, 2015, 7:03 p.m.)


Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.


Changes
---

Addressed Stephan and John's comments.

I'm pretty sure i still don't have the deps correct for the worker machine at 
least, will revisit before submitting unless somebody beats me to it.


Repository: aurora


Description
---

Add a guide for installing Aurora.


Diffs (updated)
-

  README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
  docs/installing.md PRE-CREATION 

Diff: https://reviews.apache.org/r/41564/diff/


Testing
---

Rendered here: 
https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md

I could use more eyes and independent trials on the installation steps.


Thanks,

Bill Farner