Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/#review119409 --- Ship it! Master (9d642dc) is green with this patch. ./build-s

Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/ --- (Updated Feb. 16, 2016, 7:42 p.m.) Review request for Aurora, John Sirois and M

Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/ --- Review request for Aurora, John Sirois and Maxim Khutornenko. Repository: auror

Re: Review Request 43622: Updating scheduler backup restore instructions.

2016-02-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43622/#review119384 --- Ship it! Master (9d642dc) is green with this patch. ./build-s

Re: Review Request 43622: Updating scheduler backup restore instructions.

2016-02-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43622/ --- (Updated Feb. 16, 2016, 11:10 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 43622: Updating scheduler backup restore instructions.

2016-02-16 Thread Maxim Khutornenko
> On Feb. 16, 2016, 10:38 p.m., Stephan Erb wrote: > > docs/storage-config.md, line 137 > > > > > > What are the expected values for leader and non-leaders? This is a binary flag, so only the leader will have it as

Re: Review Request 43622: Updating scheduler backup restore instructions.

2016-02-16 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43622/#review119368 --- LGTM overall. Still, I want to test this on a real cluster. Might

Re: Review Request 43622: Updating scheduler backup restore instructions.

2016-02-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43622/#review119359 --- Ship it! Master (9d642dc) is green with this patch. ./build-s

Re: Review Request 43622: Updating scheduler backup restore instructions.

2016-02-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43622/ --- (Updated Feb. 16, 2016, 9:13 p.m.) Review request for Aurora, John Sirois and S

Review Request 43622: Updating scheduler backup restore instructions.

2016-02-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43622/ --- Review request for Aurora, John Sirois and Stephan Erb. Bugs: AURORA-1605 h

Re: Review Request 42656: Don't destroy session between requests with TRequestsTransport

2016-02-16 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42656/#review119328 --- Fix it, then Ship it! I ran some tests. I have dropped the open