Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

2016-03-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44871/#review123815 --- Ship it! 2:44 for a destroy/up after the initial image pull

Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

2016-03-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44871/#review123821 --- Ship it! Master (6537581) is green with this patch.

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review123775 --- Fix it, then Ship it! Patch looks good, thanks for your

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-15 Thread John Sirois
On March 13, 2016, 6:04 a.m., John Sirois wrote: > > While your patch is rather easy, I am not sure it is the best way to move > > forward. It feels like it is crossing streams with > > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought > > into this might be helpful in

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-15 Thread John Sirois
On March 13, 2016, 6:04 a.m., John Sirois wrote: > > While your patch is rather easy, I am not sure it is the best way to move > > forward. It feels like it is crossing streams with > > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought > > into this might be helpful in

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-15 Thread Joshua Cohen
On March 13, 2016, 12:04 p.m., John Sirois wrote: > > While your patch is rather easy, I am not sure it is the best way to move > > forward. It feels like it is crossing streams with > > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought > > into this might be helpful in

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-15 Thread John Sirois
On March 13, 2016, 6:04 a.m., John Sirois wrote: > > While your patch is rather easy, I am not sure it is the best way to move > > forward. It feels like it is crossing streams with > > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought > > into this might be helpful in

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-15 Thread Joshua Cohen
On March 13, 2016, 12:04 p.m., John Sirois wrote: > > While your patch is rather easy, I am not sure it is the best way to move > > forward. It feels like it is crossing streams with > > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought > > into this might be helpful in

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-15 Thread John Sirois
On March 13, 2016, 6:04 a.m., John Sirois wrote: > > While your patch is rather easy, I am not sure it is the best way to move > > forward. It feels like it is crossing streams with > > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought > > into this might be helpful in

Re: Review Request 44827: Do not split the shell command string passed into shell health check script

2016-03-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44827/#review123744 --- Ship it! Ship It! - John Sirois On March 14, 2016, 9:49

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-15 Thread Joshua Cohen
On March 13, 2016, 12:04 p.m., John Sirois wrote: > > While your patch is rather easy, I am not sure it is the best way to move > > forward. It feels like it is crossing streams with > > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought > > into this might be helpful in

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-15 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- (Updated March 15, 2016, 6:31 p.m.) Review request for Aurora, John Sirois,

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-15 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- (Updated March 15, 2016, 6:29 p.m.) Review request for Aurora. Changes

Re: Review Request 44745: Allow for a pure docker executor.

2016-03-15 Thread Maxim Khutornenko
On March 13, 2016, 12:04 p.m., John Sirois wrote: > > While your patch is rather easy, I am not sure it is the best way to move > > forward. It feels like it is crossing streams with > > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought > > into this might be helpful in