Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133496 --- Master (3cbff41) is red with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-16 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated May 17, 2016, 5:49 a.m.) Review request for Aurora. Bugs:

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-16 Thread Dmitriy Shirchenko
> On May 17, 2016, 2:51 a.m., George Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 86 > > > > > > Should this be dispatched on another thread or added to a queue for > >

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-16 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133482 --- Exciting to see progress on this functionality!

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133479 --- Master (3cbff41) is red with this patch.

Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-16 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- Review request for Aurora. Bugs: AURORA-1683

Re: Review Request 47325: Removing Resources and ResourceSlot classes.

2016-05-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47325/ --- (Updated May 16, 2016, 7:21 p.m.) Review request for Aurora and Joshua Cohen.

Re: Review Request 47373: Batching explicit task reconciliation calls

2016-05-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47373/#review133387 --- Master (485da81) is red with this patch.

Re: Review Request 47373: Batching explicit task reconciliation calls

2016-05-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47373/ --- (Updated May 16, 2016, 5:13 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47373: Batching explicit task reconciliation calls

2016-05-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47373/#review133359 --- Ship it! Ship It! - Joshua Cohen On May 13, 2016, 11:23

Re: Review Request 47261: Generalizing AcceptedOffer resource management.

2016-05-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47261/#review133358 --- Ship it! Ship It! - Joshua Cohen On May 13, 2016, 10:58

Re: Review Request 47261: Generalizing AcceptedOffer resource management.

2016-05-16 Thread Joshua Cohen
> On May 13, 2016, 7:17 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java, > > line 52 > > > > > > Instead of having this be `Supplier` can we change the