Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147617 --- Master (bd11b1c) is red with this patch.

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147600 --- Ship it! Master (bd11b1c) is green with this patch.

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147598 --- Can you set the depends on field of this review to be `51536`? So

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

2016-09-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147597 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 467)

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-01 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/ --- (Updated Sept. 1, 2016, 7:37 p.m.) Review request for Aurora, Joshua Cohen,

Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-01 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/ --- Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread Zhitao Li
> On Aug. 31, 2016, 10:17 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > > > > > This changes seems to come with a severe security risk. As an normal > > user, I

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread John Sirois
> On Aug. 31, 2016, 4:17 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > > > > > This changes seems to come with a severe security risk. As an normal > > user, I

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread Stephan Erb
> On Sept. 1, 2016, 12:17 a.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > > > > > This changes seems to come with a severe security risk. As an normal > > user, I

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread John Sirois
> On Aug. 31, 2016, 4:17 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > > > > > This changes seems to come with a severe security risk. As an normal > > user, I

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread John Sirois
> On Aug. 31, 2016, 4:17 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > > > > > This changes seems to come with a severe security risk. As an normal > > user, I

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51384/#review147544 --- Ship it! Master (bd11b1c) is green with this patch.