Re: Review Request 51929: Scheduling multiple tasks per round.

2016-09-15 Thread Maxim Khutornenko
> On Sept. 16, 2016, 1:20 a.m., Aurora ReviewBot wrote: > > Master (783baae) is red with this patch. > > ./build-support/jenkins/build.sh > > > > # Create file stdout for capturing output. > > We can't use StringIO mock > > 

Re: Review Request 51929: Scheduling multiple tasks per round.

2016-09-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149162 --- Master (783baae) is red with this patch. ./build-support/jenkins

Review Request 51929: Scheduling multiple tasks per round.

2016-09-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. Reposit

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-15 Thread Stephan Erb
> On Sept. 15, 2016, 12:48 vorm., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 82 > > > > > > Did you try to rollback to pre 0.15 schedul

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/#review149115 --- Ship it! Master (783baae) is green with this patch. ./build-s

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-15 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51874/ --- (Updated Sept. 15, 2016, 12:02 p.m.) Review request for Aurora, Joshua Cohen an

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-15 Thread Santhosh Kumar Shanmugham
> On Sept. 14, 2016, 3:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 82 > > > > > > Did you try to rollback to pre 0.15 scheduler

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/ --- (Updated Sept. 15, 2016, 6:46 p.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 51924: Remove --release-threshold option from aurora job restart.

2016-09-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51924/#review149107 --- Master (5069f93) is red with this patch. ./build-support/jenkins

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-15 Thread Zameer Manji
> On Sept. 14, 2016, 3:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 82 > > > > > > Did you try to rollback to pre 0.15 scheduler

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

2016-09-15 Thread Santhosh Kumar Shanmugham
> On Sept. 14, 2016, 3:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 82 > > > > > > Did you try to rollback to pre 0.15 scheduler

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

2016-09-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/#review149093 --- Fix it, then Ship it! LGTM, the changes are fairly straight for

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/#review149099 --- Ship it! Ship It! src/main/python/apache/aurora/executor/comm

Re: Review Request 51924: Remove --release-threshold option from aurora job restart.

2016-09-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51924/#review149097 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 15, 2016, 6:1

Review Request 51924: Remove --release-threshold option from aurora job restart.

2016-09-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51924/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1681 https://

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/#review149066 --- Ship it! Patch LGTM. In general, I don't like the trend that T

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/#review149065 --- Ship it! Master (5069f93) is green with this patch. ./build-s

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/ --- (Updated Sept. 15, 2016, 3:15 p.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Joshua Cohen
> On Sept. 15, 2016, 1:23 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/common/health_check/shell.py, line 73 > > > > > > You pass in `_cmd` and `_isolator_fn` into the `ShellHealthCheck`. Have > > you c

Re: Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

2016-09-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51899/#review149056 --- src/main/python/apache/aurora/common/health_check/shell.py (line

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

2016-09-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51759/#review149044 --- Ship it! Overall lgtm. Agree w/ Zameer that we should ship all

Re: Review Request 51893: Allow cookie based authentication

2016-09-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review149031 --- Master (5069f93) is red with this patch. ./build-support/jenkins

Re: Review Request 51893: Allow cookie based authentication

2016-09-15 Thread Giulio Eulisse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Sept. 15, 2016, 7:17 a.m.) Review request for Aurora, Joshua Cohen and