Re: Review Request 52588: Enable per task volume mounts via scheduler API

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52588/#review151755
---


Ship it!




lgtm modulo style issues from review bot and updating the docs for the new 
scheduler flag.

- Joshua Cohen


On Oct. 7, 2016, 1:21 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52588/
> ---
> 
> (Updated Oct. 7, 2016, 1:21 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and 
> Stephan Erb.
> 
> 
> Bugs: AURORA-1107
> https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This allows users to specify volume mounts for tasks using the unified
> containerizer if the operator permits them. This is analogous to enabling 
> docker
> parameters per task and using the `--volume` parameter.
> 
> This does not include the needed DSL changes or an e2e test which will be in a
> subsequent diff.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md f3dd8bb0f983c560f29ac39824e517c9f145d69e 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 0c74665f750571ccfdeda5a0b71cccbe169716a7 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> c6c2a6d4ec48681378210d1fcb7909fd088d2afb 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 3bd22a0d47cf0793c749b008ccbdf58033c75a11 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  701f79c900e1d5794741475333805d1c12af58dd 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 9038c36e4ae05ade273a1c218b7a7e8af218ae39 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> acb44984b4aa38bbe1cac8f805754d55dbe39f3a 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> e137e57a0b111b9320e6902aa586d7f24e0d5c58 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 151306a567448c45223e90c8a29ac6ecbc9f6653 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V009_CreateContainerVolumesTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
>  e30c387239e868daedf496dd886df4d8c00f1fc3 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java 
> 8d4d7eca3a17a3b96bbbdec9271503e7e71b3aff 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  3fce25f5e6d180a20dc3ace83f666d47bf32c0c5 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> e943c647af4d0bdb1c733813d019d91942fbbc95 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  db9f276c1ad26b33ff66f679787ee798bbb69c80 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> bd052abd65109544be92d3e292f1c2b238c86135 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 3d07292c83c229cc85d3ad624a7a7a65ef0dcd51 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> 95b371627d23f7ed3472561f17880bf3c4259b96 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> e578f5a3076b8f1aad86247b815d05c8244dddc8 
> 
> Diff: https://reviews.apache.org/r/52588/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 52588: Enable per task volume mounts via scheduler API

[Joshua Cohen]

> On Oct. 6, 2016, 2:52 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/app/AppModule.java, line 102
> > 
> >
> > Update `scheduler-configuration.md` to pick up this new flag?
> 
> Zameer Manji wrote:
> I would but I have no idea on how to generate this file.

vagrant@aurora:~/aurora/dist/install/aurora-scheduler$ pwd
/home/vagrant/aurora/dist/install/aurora-scheduler
vagrant@aurora:~/aurora/dist/install/aurora-scheduler$ ./bin/aurora-scheduler 
-help


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52588/#review151615
---


On Oct. 7, 2016, 1:21 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52588/
> ---
> 
> (Updated Oct. 7, 2016, 1:21 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and 
> Stephan Erb.
> 
> 
> Bugs: AURORA-1107
> https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This allows users to specify volume mounts for tasks using the unified
> containerizer if the operator permits them. This is analogous to enabling 
> docker
> parameters per task and using the `--volume` parameter.
> 
> This does not include the needed DSL changes or an e2e test which will be in a
> subsequent diff.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md f3dd8bb0f983c560f29ac39824e517c9f145d69e 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 0c74665f750571ccfdeda5a0b71cccbe169716a7 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> c6c2a6d4ec48681378210d1fcb7909fd088d2afb 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 3bd22a0d47cf0793c749b008ccbdf58033c75a11 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  701f79c900e1d5794741475333805d1c12af58dd 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 9038c36e4ae05ade273a1c218b7a7e8af218ae39 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> acb44984b4aa38bbe1cac8f805754d55dbe39f3a 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> e137e57a0b111b9320e6902aa586d7f24e0d5c58 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 151306a567448c45223e90c8a29ac6ecbc9f6653 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V009_CreateContainerVolumesTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
>  e30c387239e868daedf496dd886df4d8c00f1fc3 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java 
> 8d4d7eca3a17a3b96bbbdec9271503e7e71b3aff 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  3fce25f5e6d180a20dc3ace83f666d47bf32c0c5 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> e943c647af4d0bdb1c733813d019d91942fbbc95 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  db9f276c1ad26b33ff66f679787ee798bbb69c80 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> bd052abd65109544be92d3e292f1c2b238c86135 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 3d07292c83c229cc85d3ad624a7a7a65ef0dcd51 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> 95b371627d23f7ed3472561f17880bf3c4259b96 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> e578f5a3076b8f1aad86247b815d05c8244dddc8 
> 
> Diff: https://reviews.apache.org/r/52588/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 52588: Enable per task volume mounts via scheduler API

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52588/#review151750
---



Master (09b8e58) is red with this patch.
  ./build-support/jenkins/build.sh

:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74:
 Note: Wrote forwarder 
org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor

:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java:401:
 error: File contains a sequence of empty lines.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 3 mins 25.75 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 7, 2016, 1:21 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52588/
> ---
> 
> (Updated Oct. 7, 2016, 1:21 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and 
> Stephan Erb.
> 
> 
> Bugs: AURORA-1107
> https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This allows users to specify volume mounts for tasks using the unified
> containerizer if the operator permits them. This is analogous to enabling 
> docker
> parameters per task and using the `--volume` parameter.
> 
> This does not include the needed DSL changes or an e2e test which will be in a
> subsequent diff.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md f3dd8bb0f983c560f29ac39824e517c9f145d69e 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 0c74665f750571ccfdeda5a0b71cccbe169716a7 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> c6c2a6d4ec48681378210d1fcb7909fd088d2afb 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 3bd22a0d47cf0793c749b008ccbdf58033c75a11 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  701f79c900e1d5794741475333805d1c12af58dd 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 9038c36e4ae05ade273a1c218b7a7e8af218ae39 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> acb44984b4aa38bbe1cac8f805754d55dbe39f3a 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> e137e57a0b111b9320e6902aa586d7f24e0d5c58 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 151306a567448c45223e90c8a29ac6ecbc9f6653 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V009_CreateContainerVolumesTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
>  e30c387239e868daedf496dd886df4d8c00f1fc3 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java 
> 8d4d7eca3a17a3b96bbbdec9271503e7e71b3aff 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  3fce25f5e6d180a20dc3ace83f666d47bf32c0c5 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> e943c647af4d0bdb1c733813d019d91942fbbc95 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  db9f276c1ad26b33ff66f679787ee798bbb69c80 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 

Re: Review Request 52588: Enable per task volume mounts via scheduler API

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52588/
---

(Updated Oct. 6, 2016, 6:21 p.m.)


Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and Stephan 
Erb.


Changes
---

jcohen's feedback.


Bugs: AURORA-1107
https://issues.apache.org/jira/browse/AURORA-1107


Repository: aurora


Description
---

This allows users to specify volume mounts for tasks using the unified
containerizer if the operator permits them. This is analogous to enabling docker
parameters per task and using the `--volume` parameter.

This does not include the needed DSL changes or an e2e test which will be in a
subsequent diff.


Diffs (updated)
-

  RELEASE-NOTES.md f3dd8bb0f983c560f29ac39824e517c9f145d69e 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
0c74665f750571ccfdeda5a0b71cccbe169716a7 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
c6c2a6d4ec48681378210d1fcb7909fd088d2afb 
  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
3bd22a0d47cf0793c749b008ccbdf58033c75a11 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 701f79c900e1d5794741475333805d1c12af58dd 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
9038c36e4ae05ade273a1c218b7a7e8af218ae39 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
acb44984b4aa38bbe1cac8f805754d55dbe39f3a 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
e137e57a0b111b9320e6902aa586d7f24e0d5c58 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
151306a567448c45223e90c8a29ac6ecbc9f6653 
  
src/main/java/org/apache/aurora/scheduler/storage/db/migration/V009_CreateContainerVolumesTable.java
 PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
 e30c387239e868daedf496dd886df4d8c00f1fc3 
  
src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java 
8d4d7eca3a17a3b96bbbdec9271503e7e71b3aff 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 
3fce25f5e6d180a20dc3ace83f666d47bf32c0c5 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
e943c647af4d0bdb1c733813d019d91942fbbc95 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 db9f276c1ad26b33ff66f679787ee798bbb69c80 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
bd052abd65109544be92d3e292f1c2b238c86135 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
3d07292c83c229cc85d3ad624a7a7a65ef0dcd51 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
95b371627d23f7ed3472561f17880bf3c4259b96 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
e578f5a3076b8f1aad86247b815d05c8244dddc8 

Diff: https://reviews.apache.org/r/52588/diff/


Testing
---


Thanks,

Zameer Manji

Re: Review Request 52588: Enable per task volume mounts via scheduler API

[Zameer Manji]

> On Oct. 5, 2016, 7:52 p.m., Joshua Cohen wrote:
> > Overall looks good to me. One question: the executor currently only 
> > supports RO volumes (everything is a bind mount). This is because [Mesos 
> > itself only supports RO 
> > mounts](https://github.com/apache/mesos/blob/b70a22bad22e5e8668f9af62c575902dec7b0125/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp#L569).
> >  Given that limitation, how do you think we should proceed with regards to 
> > Aurora support for arbitrary mounts? I can see the case for plumbing it 
> > through from the start (avoid the need to backfill the db if/when we 
> > support mode, maintain parity w/ Docker mount specification, etc.), but 
> > it's also inevitabily going to lead to confusion when someone tries to 
> > configure a RW mount and it doesn't work.
> > 
> > Perhaps until Mesos has support for RW volumes in the unified containerizer 
> > we should add validation to ConfigurationManager that rejects tasks that 
> > specify a RW volumes?

Sounds like a good idea. Done.


> On Oct. 5, 2016, 7:52 p.m., Joshua Cohen wrote:
> > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java,
> >  line 337
> > 
> >
> > `@Test` on its own line.

Done.


> On Oct. 5, 2016, 7:52 p.m., Joshua Cohen wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 206
> > 
> >
> > s/volume/volumes
> > s/task/task.

Done.


> On Oct. 5, 2016, 7:52 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/app/AppModule.java, lines 103-104
> > 
> >
> > need a space between privilege and escalation

Done.


> On Oct. 5, 2016, 7:52 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/app/AppModule.java, line 102
> > 
> >
> > Update `scheduler-configuration.md` to pick up this new flag?

I would but I have no idea on how to generate this file.


> On Oct. 5, 2016, 7:52 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java, line 
> > 243
> > 
> >
> > s/:/ :

Done.


> On Oct. 5, 2016, 7:52 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/migration/V009_CreateContainerVolumesTable.java,
> >  line 38
> > 
> >
> > s/task_config_if/task_config_volumes

Good catch, that would have been bad.


> On Oct. 5, 2016, 7:52 p.m., Joshua Cohen wrote:
> > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml,
> >  lines 137-138
> > 
> >
> > nit: indentation should be the same here as we do for other sources 
> > (i.e. 4 space indents for continuations, one attribute per line).

Done.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52588/#review151615
---


On Oct. 5, 2016, 6:23 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52588/
> ---
> 
> (Updated Oct. 5, 2016, 6:23 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and 
> Stephan Erb.
> 
> 
> Bugs: AURORA-1107
> https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This allows users to specify volume mounts for tasks using the unified
> containerizer if the operator permits them. This is analogous to enabling 
> docker
> parameters per task and using the `--volume` parameter.
> 
> This does not include the needed DSL changes or an e2e test which will be in a
> subsequent diff.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 0c74665f750571ccfdeda5a0b71cccbe169716a7 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> c6c2a6d4ec48681378210d1fcb7909fd088d2afb 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 3bd22a0d47cf0793c749b008ccbdf58033c75a11 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  701f79c900e1d5794741475333805d1c12af58dd 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 9038c36e4ae05ade273a1c218b7a7e8af218ae39 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> 

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

[Zameer Manji]

Just make them public and add a `@VisibleForTesting` annotation.

We do this in many places to make the code testable.

On Thu, Oct 6, 2016 at 2:55 PM, Pradyumna Kaushik 
wrote:

> Correction,
>
> I need to create mocks of TaskGroups.java and TaskGroup.java and not
> PendingTasks.java.
>
> On Thu, Oct 6, 2016 at 5:54 PM, Pradyumna Kaushik  > wrote:
>
>> Hi,
>>
>> I was writing the test file for PendingTasks.java and have a question.
>> The constructors for TaskGroups.java and TaskGroup.java are package scoped
>> and hence, are not accessible in test/java/org/apache/aurora/scheduler/http.
>> I need to be able to create mocks of pending tasks and hence, I don't think
>> I can use createMock(...) for the same. I currently have thought of 2 ways
>> to get around this.
>> 1. Make the constructors of TaskGroups.java and TaskGroup.java public.
>> 2. Use reflection and create instances, like shown below,
>> Constructor taskGroupsConstructor =
>> (Constructor) TaskGroups.class.getConstructors()[0];
>> taskGroupsConstructor.setAccessible(true);
>> taskGroupsConstructor.newInstance(...);
>>
>> Please let me know which method would be appropriate.
>>
>> On Wed, Oct 5, 2016 at 3:50 PM, Pradyumna Kaushik <
>> pkaus...@binghamton.edu> wrote:
>>
>>> Thank you. This clarifies things for me. I will get back to you in case
>>> anything pops up.
>>>
>>> On Wed, Oct 5, 2016 at 3:47 PM, Joshua Cohen  wrote:
>>>
 Well, I guess to be specific, the perfect place would be:
 src/test/java/org/apache/aurora/scheduler/http ;).

 On Wed, Oct 5, 2016 at 2:46 PM, Joshua Cohen  wrote:

> That would be the perfect place for the test, thanks for adding it!
>
> On Wed, Oct 5, 2016 at 2:43 PM, Pradyumna Kaushik <
> pkaus...@binghamton.edu> wrote:
>
>> Zameer,
>>
>> Alright. I will start making changes to incorporate Stephan's idea.
>> Also, I didn't seem to find an existing test for PendingTasks. Please
>> let me know whether I can go ahead and create PendingTasksTest.java in
>> src/test/java/scheduler/http. If not, then please let me know where I can
>> plug in the JUnit tests for /pendingTasks api.
>>
>> On Wed, Oct 5, 2016 at 3:21 PM, Zameer Manji 
>> wrote:
>>
>>> If you don't think it's too much work, I think Stephan's idea is
>>> ideal.
>>>
>>> The mutability of `reason` can result in bugs later.
>>>
>>> On Wed, Oct 5, 2016 at 11:31 AM, Pradyumna Kaushik <
>>> pkaus...@binghamton.edu> wrote:
>>>
 Hi,

 Should I go ahead and work on Stephan's idea of returning a
 Map  or should I hold it for now until the idea is a
 little more clear?

 On Tue, Oct 4, 2016 at 5:18 PM, Zameer Manji 
 wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51993/
>
> On October 4th, 2016, 2:10 p.m. PDT, *Stephan Erb* wrote:
>
> This change will be backwards incompatible. For example, it will 
> break the Prometheus Aurora exporter: 
> https://github.com/tommyulfsparre/aurora_exporter/blob/master/main.go#L101
>
> So the question: Do we consider this endpoint to be part of our 
> public API? If yes, how can we remain backwards compatible?
>
> I'm not sure if we do make this endpoint apart of our public API, but 
> I think we can make a backwards compatible change here.
>
> The current schema of the endpoint is list of objects where each 
> object has the keys:
> - penaltyMs (string)
> - taskIds (list of strings)
> - name (string)
>
> Surely we can add "reason" there as a list of strings.
>
>
> - Zameer
>
> On October 4th, 2016, 11:25 a.m. PDT, Pradyumna Kaushik wrote:
> Review request for Aurora and Joshua Cohen.
> By Pradyumna Kaushik.
>
> *Updated Oct. 4, 2016, 11:25 a.m.*
> *Repository: * aurora
> Description
>
> Added the 'reason' to the /pendingTasks endpoint
>
> Testing
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
> Diffs
>
>- src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java
>(c80e0c8adf80e12082a6952ae79b7d9cc960c5b6)
>- 
> src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java
>(f783e7ff220573915524a1efc27141193d19fa6c)
>- 
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java
>(5d319557057e27fd5fc6d3e553e9ca9139399c50)
>
> View Diff 

Re: Review Request 52609: Manually configure the private network interface in Vagrant

[John Sirois]

> On Oct. 6, 2016, 1:10 p.m., John Sirois wrote:
> > I added myself as a reviewer since I'm running Vagrant 1.8.6.  I'll have 
> > time to confirm your issue and fix later today and have some feedback for 
> > you by tomorrow latest.

I can confirm both the failure to autoprovision under 1.8.6 and the old 
Vagrantfile and the fix. Thanks for addressing this Andrew!


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/#review151705
---


On Oct. 6, 2016, 12:14 p.m., Andrew Jorgensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52609/
> ---
> 
> (Updated Oct. 6, 2016, 12:14 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
> network interface does not come up correctly and the private_network is 
> attached to the `eth0` nat interface rather than the host-only interface. I 
> tried a number of different parameters but none of them were able to 
> configure the network appropriately. This change manually configures the 
> static ip so that it is connected to the correct adapter. Without this change 
> I could not access the aurora web interface.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 
> 
> Diff: https://reviews.apache.org/r/52609/diff/
> 
> 
> Testing
> ---
> 
> Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the 
> steps here: 
> http://aurora.apache.org/documentation/latest/getting-started/vagrant/
> 
> 
> Thanks,
> 
> Andrew Jorgensen
> 
>

Re: Review Request 52609: Manually configure the private network interface in Vagrant

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/#review151714
---


Ship it!




Ship It!

- John Sirois


On Oct. 6, 2016, 12:14 p.m., Andrew Jorgensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52609/
> ---
> 
> (Updated Oct. 6, 2016, 12:14 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
> network interface does not come up correctly and the private_network is 
> attached to the `eth0` nat interface rather than the host-only interface. I 
> tried a number of different parameters but none of them were able to 
> configure the network appropriately. This change manually configures the 
> static ip so that it is connected to the correct adapter. Without this change 
> I could not access the aurora web interface.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 
> 
> Diff: https://reviews.apache.org/r/52609/diff/
> 
> 
> Testing
> ---
> 
> Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the 
> steps here: 
> http://aurora.apache.org/documentation/latest/getting-started/vagrant/
> 
> 
> Thanks,
> 
> Andrew Jorgensen
> 
>

Re: Review Request 52610: Use the Thrift binary protocol in the Aurora client.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52610/#review151707
---


Ship it!




Ship It!

- John Sirois


On Oct. 6, 2016, 12:14 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52610/
> ---
> 
> (Updated Oct. 6, 2016, 12:14 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Now that Aurora 0.16 has been released, we can assume all schedulers are
> supporting the binary protocol.
> 
> Switching the protocol comes with a slight performance boost: Given
> the example job `devcluster/www-data/prod/hello` with 500 instances
> we can reduce the average request time by about 40%.
> 
> Using the TJSONProtocol:
> 
> $ time aurora job status devcluster > /dev/null
> real0m0.906s
> user0m0.759s
> sys 0m0.078s
> 
> Using the new TBinaryProtocol:
> 
> $ time aurora job status devcluster > /dev/null
> real0m0.524s
> user0m0.410s
> sys 0m0.079s
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 6968bb538a57c2583316175f74683dcf3de2b297 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> cbdb50ae409b70a35a03405f969d02a6145c9c53 
>   src/main/python/apache/aurora/common/transport.py 
> 2e38847c1bfe24961cc2ee1619a223481d1646a7 
>   src/test/python/apache/aurora/common/test_transport.py 
> 0a587f00a6a00106d6f6b756aaa3078fb042e3b3 
> 
> Diff: https://reviews.apache.org/r/52610/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 52609: Manually configure the private network interface in Vagrant

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/#review151705
---



I added myself as a reviewer since I'm running Vagrant 1.8.6.  I'll have time 
to confirm your issue and fix later today and have some feedback for you by 
tomorrow latest.

- John Sirois


On Oct. 6, 2016, 12:14 p.m., Andrew Jorgensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52609/
> ---
> 
> (Updated Oct. 6, 2016, 12:14 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
> network interface does not come up correctly and the private_network is 
> attached to the `eth0` nat interface rather than the host-only interface. I 
> tried a number of different parameters but none of them were able to 
> configure the network appropriately. This change manually configures the 
> static ip so that it is connected to the correct adapter. Without this change 
> I could not access the aurora web interface.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 
> 
> Diff: https://reviews.apache.org/r/52609/diff/
> 
> 
> Testing
> ---
> 
> Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the 
> steps here: 
> http://aurora.apache.org/documentation/latest/getting-started/vagrant/
> 
> 
> Thanks,
> 
> Andrew Jorgensen
> 
>

Re: Review Request 52610: Use the Thrift binary protocol in the Aurora client.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52610/#review151698
---


Ship it!




Thanks for doing this.

I'm glad to see that my change has enabled the client to be much faster with 
large jobs.

- Zameer Manji


On Oct. 6, 2016, 11:14 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52610/
> ---
> 
> (Updated Oct. 6, 2016, 11:14 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Now that Aurora 0.16 has been released, we can assume all schedulers are
> supporting the binary protocol.
> 
> Switching the protocol comes with a slight performance boost: Given
> the example job `devcluster/www-data/prod/hello` with 500 instances
> we can reduce the average request time by about 40%.
> 
> Using the TJSONProtocol:
> 
> $ time aurora job status devcluster > /dev/null
> real0m0.906s
> user0m0.759s
> sys 0m0.078s
> 
> Using the new TBinaryProtocol:
> 
> $ time aurora job status devcluster > /dev/null
> real0m0.524s
> user0m0.410s
> sys 0m0.079s
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 6968bb538a57c2583316175f74683dcf3de2b297 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> cbdb50ae409b70a35a03405f969d02a6145c9c53 
>   src/main/python/apache/aurora/common/transport.py 
> 2e38847c1bfe24961cc2ee1619a223481d1646a7 
>   src/test/python/apache/aurora/common/test_transport.py 
> 0a587f00a6a00106d6f6b756aaa3078fb042e3b3 
> 
> Diff: https://reviews.apache.org/r/52610/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 52610: Use the Thrift binary protocol in the Aurora client.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52610/#review151694
---


Ship it!




Master (b417be3) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 6:14 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52610/
> ---
> 
> (Updated Oct. 6, 2016, 6:14 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Now that Aurora 0.16 has been released, we can assume all schedulers are
> supporting the binary protocol.
> 
> Switching the protocol comes with a slight performance boost: Given
> the example job `devcluster/www-data/prod/hello` with 500 instances
> we can reduce the average request time by about 40%.
> 
> Using the TJSONProtocol:
> 
> $ time aurora job status devcluster > /dev/null
> real0m0.906s
> user0m0.759s
> sys 0m0.078s
> 
> Using the new TBinaryProtocol:
> 
> $ time aurora job status devcluster > /dev/null
> real0m0.524s
> user0m0.410s
> sys 0m0.079s
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 6968bb538a57c2583316175f74683dcf3de2b297 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> cbdb50ae409b70a35a03405f969d02a6145c9c53 
>   src/main/python/apache/aurora/common/transport.py 
> 2e38847c1bfe24961cc2ee1619a223481d1646a7 
>   src/test/python/apache/aurora/common/test_transport.py 
> 0a587f00a6a00106d6f6b756aaa3078fb042e3b3 
> 
> Diff: https://reviews.apache.org/r/52610/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 52609: Manually configure the private network interface in Vagrant

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/#review151692
---


Ship it!




Master (b417be3) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 6:14 p.m., Andrew Jorgensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52609/
> ---
> 
> (Updated Oct. 6, 2016, 6:14 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
> network interface does not come up correctly and the private_network is 
> attached to the `eth0` nat interface rather than the host-only interface. I 
> tried a number of different parameters but none of them were able to 
> configure the network appropriately. This change manually configures the 
> static ip so that it is connected to the correct adapter. Without this change 
> I could not access the aurora web interface.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 
> 
> Diff: https://reviews.apache.org/r/52609/diff/
> 
> 
> Testing
> ---
> 
> Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the 
> steps here: 
> http://aurora.apache.org/documentation/latest/getting-started/vagrant/
> 
> 
> Thanks,
> 
> Andrew Jorgensen
> 
>

Review Request 52610: Use the Thrift binary protocol in the Aurora client.

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52610/
---

Review request for Aurora, John Sirois and Zameer Manji.


Repository: aurora


Description
---

Now that Aurora 0.16 has been released, we can assume all schedulers are
supporting the binary protocol.

Switching the protocol comes with a slight performance boost: Given
the example job `devcluster/www-data/prod/hello` with 500 instances
we can reduce the average request time by about 40%.

Using the TJSONProtocol:

$ time aurora job status devcluster > /dev/null
real0m0.906s
user0m0.759s
sys 0m0.078s

Using the new TBinaryProtocol:

$ time aurora job status devcluster > /dev/null
real0m0.524s
user0m0.410s
sys 0m0.079s


Diffs
-

  RELEASE-NOTES.md 6968bb538a57c2583316175f74683dcf3de2b297 
  src/main/python/apache/aurora/client/api/scheduler_client.py 
cbdb50ae409b70a35a03405f969d02a6145c9c53 
  src/main/python/apache/aurora/common/transport.py 
2e38847c1bfe24961cc2ee1619a223481d1646a7 
  src/test/python/apache/aurora/common/test_transport.py 
0a587f00a6a00106d6f6b756aaa3078fb042e3b3 

Diff: https://reviews.apache.org/r/52610/diff/


Testing
---

./pants test.pytest src/{main,test}/python:: -- -v
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Stephan Erb

Re: Review Request 52609: Manually configure the private network interface in Vagrant

[Andrew Jorgensen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/
---

(Updated Oct. 6, 2016, 6:09 p.m.)


Review request for Aurora.


Summary (updated)
-

Manually configure the private network interface in Vagrant


Repository: aurora


Description
---

I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
network interface does not come up correctly and the private_network is 
attached to the `eth0` nat interface rather than the host-only interface. I 
tried a number of different parameters but none of them were able to configure 
the network appropriately. This change manually configures the static ip so 
that it is connected to the correct adapter. Without this change I could not 
access the aurora web interface.


Diffs
-

  Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 

Diff: https://reviews.apache.org/r/52609/diff/


Testing
---

Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the 
steps here: 
http://aurora.apache.org/documentation/latest/getting-started/vagrant/


Thanks,

Andrew Jorgensen

Re: Review Request 52609: Manually configure the private network interface

[Andrew Jorgensen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/
---

(Updated Oct. 6, 2016, 6:05 p.m.)


Review request for Aurora.


Repository: aurora


Description
---

I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
network interface does not come up correctly and the private_network is 
attached to the `eth0` nat interface rather than the host-only interface. I 
tried a number of different parameters but none of them were able to configure 
the network appropriately. This change manually configures the static ip so 
that it is connected to the correct adapter. Without this change I could not 
access the aurora web interface.


Diffs
-

  Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 

Diff: https://reviews.apache.org/r/52609/diff/


Testing (updated)
---

Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the 
steps here: 
http://aurora.apache.org/documentation/latest/getting-started/vagrant/


Thanks,

Andrew Jorgensen

Review Request 52609: Manually configure the private network interface

[Andrew Jorgensen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/
---

Review request for Aurora.


Repository: aurora


Description
---

I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
network interface does not come up correctly and the private_network is 
attached to the `eth0` nat interface rather than the host-only interface. I 
tried a number of different parameters but none of them were able to configure 
the network appropriately. This change manually configures the static ip so 
that it is connected to the correct adapter. Without this change I could not 
access the aurora web interface.


Diffs
-

  Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 

Diff: https://reviews.apache.org/r/52609/diff/


Testing
---


Thanks,

Andrew Jorgensen

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

[John Sirois]

> On Oct. 3, 2016, 12:22 p.m., Joshua Cohen wrote:
> > I don't think that the registry to resolve against should be an argument to 
> > the docker helper, as this should likely be controlled by Aurora operators, 
> > not by Aurora users. When we originally discussed this, we talked about 
> > having the docker registry to use by a trait of the cluster, was that not 
> > feasible?
> 
> Santhosh Kumar Shanmugham wrote:
> I totally agree. Unfortunately I could not find a way to make pystachio 
> work that way. There are two stages in the parsing of a pystachio config. The 
> first one is where all the context is built and the second stage where the 
> context is used to bind any Ref to concrete values. Due to the restrictions 
> pystachio puts on the names for Ref address (alphanumeric only), resolving 
> tags during the binding stage, limits the values that can be used for 'name' 
> and 'tag'. (For example: 'name' cannot have '/' in them and 'tag' cannot have 
> '.' in them, which is obviously a serious shortcoming). 
> 
> The side-effect, however is that at this stage we are unaware of the 
> 'cluster' value to look up any details from 'CLUSTERS'. Hence I have opted to 
> do the resolution in the first stage by explicitly passing in the registry 
> address. The only way I see around this problem involves modifying pystachio 
> to allow more values for Ref objects. Please share your thoughts.
> 
> See 
> https://github.com/wickman/pystachio/blob/master/pystachio/naming.py#L60
> 
> Santhosh Kumar Shanmugham wrote:
> Another solution is to encode these special characters using the only 
> special character that is allowed '-'. Hence the mapping would look like,
> \ => -pys-slash-
> . => -pys-dot-
> and so on. 
> 
> I vote for expanding the character limit for Ref.
> 
> Zameer Manji wrote:
> Can you elaborate on what you mean by unware of the 'cluster' value? I 
> don't understand why you can't do from apache.aurora.common.clusters import 
> CLUSTERS and get the registry from that. That way we don't need to specify 
> the registry value in the helper.
> 
> I think expanding Ref would be nice but it doesn't seem feasible because 
> the structured binding of pystachio invovles `.`.
> 
> I think we should tread carefully here and consider a better solution.
> 
> Santhosh Kumar Shanmugham wrote:
> 'CLUSTERS' can potentially contain multiple cluster definitions. Which of 
> these do we pick is determined by the value of the 'MesosJob.cluster' 
> variable inside the AuroraConfig. But since the AuroraConfig is not yet 
> built, there is no way to know which one to pick. That is what I mean by 
> 'unaware of cluster'. Hence pystachio has the concept of binding to allow for 
> manipoulating the variables post-parsing. Unfortunately, the Ref object is 
> too restrictive.
> 
> +1 on expanding Ref.
> 
> I am open to suggestions here.
> 
> Zameer Manji wrote:
> If you want to expand Ref, I suggest putting this review on hold, and 
> filing a bug report on the github repo. I believe wickman and jsirois have 
> the keys to the repo so they can figure out if this solution is viable or not.
> 
> Santhosh Kumar Shanmugham wrote:
> Opened a new issue for Pystachio - 
> https://github.com/wickman/pystachio/issues/26
> 
> Santhosh Kumar Shanmugham wrote:
> Pull request: https://github.com/wickman/pystachio/pull/27

Merged and released here: https://pypi.python.org/pypi/pystachio/0.8.3


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52479/#review151205
---


On Oct. 4, 2016, 10:55 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52479/
> ---
> 
> (Updated Oct. 4, 2016, 10:55 p.m.)
> 
> 
> Review request for Aurora, George Sirois, Joshua Cohen, John Sirois, and 
> Brian Wickman.
> 
> 
> Bugs: AURORA-1014
> https://issues.apache.org/jira/browse/AURORA-1014
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Resolve docker tags to concrete identifiers for DockerContainerizer
> 
> Docker tags are mutable and can point to different different images
> at different points in time. This makes a job launched with a Docker
> image to be mutable across restarts of the job. This breaks Aurora's
> guarantee of job immutability (except via job updates).
> 
> This change introduces a binding helper, that resolves docker name:tag
> to a concrete registry/name@digest identifier. Identifying
> docker images via a content-addressable digest is available via the
> Docker Registry v2, that is a prerequisite for this feature.
> 
> 
> Diffs
> -
> 
>   

Re: Review Request 51893: Allow cookie based authentication

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/#review151685
---



Can you add some tests for `CookieAuthModule`? I suspect this will not be a 
widely exercised codepath, so having good coverage is the only way to ensure 
this doesn't break in the future.


src/main/python/apache/aurora/client/cli/client.py (line 85)


I think we can move this import to the top with the rest of the imports? 
The only reason the Kerberos import is done here is so we can degrade 
gracefully if Kerberos is not available.


- Joshua Cohen


On Oct. 6, 2016, 11:14 a.m., Giulio Eulisse wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51893/
> ---
> 
> (Updated Oct. 6, 2016, 11:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow cookie based authentication
> 
> This allows aurora client to connect to servers which are behind a frontend 
> which expects some sort of cookie to autheticate and authorize users. The 
> cookie should be stored in MozillanCookieJar format in a file named 
> `~/.aurora-token`.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> fbebbab8c827b5695042d18770d850e31fc38122 
>   src/main/python/apache/aurora/client/cli/client.py 
> fa0c2648c5ff7ea6c9d949cf8cd9b9795d452e98 
>   src/main/python/apache/aurora/common/cookie_auth_module.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51893/diff/
> 
> 
> Testing
> ---
> 
> $ cat ~/aurora/clusters.json
> [
> {
>   "name": "build",
>   "scheduler_uri": "https://aliaurora.cern.ch;,
>   "auth_mechanism": "COOKIE"
> }
> ]
> $ dist/aurora.pex quota get build/root
> 
> 
> Thanks,
> 
> Giulio Eulisse
> 
>

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151684
---


Ship it!




Ship It!

- Joshua Cohen


On Oct. 6, 2016, 4:26 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 6, 2016, 4:26 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java   
>   

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151677
---



Master (fdb536a) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 4:26 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 6, 2016, 4:26 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
>  

Re: Review Request 51893: Allow cookie based authentication

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/#review151674
---



Code looks much better now. Thanks for your effort.


docs/operations/security.md (line 181)


Does this require modifications of the scheduler? How does it pick up the 
necessary information in your implementation?



src/main/python/apache/aurora/common/cookie_auth_module.py (line 27)


Please re-use the default search paths as defined in common/clusters.py


- Stephan Erb


On Okt. 6, 2016, 1:14 nachm., Giulio Eulisse wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51893/
> ---
> 
> (Updated Okt. 6, 2016, 1:14 nachm.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow cookie based authentication
> 
> This allows aurora client to connect to servers which are behind a frontend 
> which expects some sort of cookie to autheticate and authorize users. The 
> cookie should be stored in MozillanCookieJar format in a file named 
> `~/.aurora-token`.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> fbebbab8c827b5695042d18770d850e31fc38122 
>   src/main/python/apache/aurora/client/cli/client.py 
> fa0c2648c5ff7ea6c9d949cf8cd9b9795d452e98 
>   src/main/python/apache/aurora/common/cookie_auth_module.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51893/diff/
> 
> 
> Testing
> ---
> 
> $ cat ~/aurora/clusters.json
> [
> {
>   "name": "build",
>   "scheduler_uri": "https://aliaurora.cern.ch;,
>   "auth_mechanism": "COOKIE"
> }
> ]
> $ dist/aurora.pex quota get build/root
> 
> 
> Thanks,
> 
> Giulio Eulisse
> 
>

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/
---

(Updated Oct. 6, 2016, 10:26 a.m.)


Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.


Changes
---

Fix comment typos.

 config/findbugs/excludeFilter.xml   | 2 +-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


Bugs: AURORA-1669
https://issues.apache.org/jira/browse/AURORA-1669


Repository: aurora


Description
---

Remove unused code and restrict visibility where possible. Also fix up
various warnings.

 build.gradle   
   |  13 +-
 commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java  
   | 372 
--
 commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java   
   | 167 
--
 
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
 | 140 ---
 
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
 | 210 

 
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
  | 139 
---
 config/findbugs/excludeFilter.xml  
   |   8 ++
 docs/features/service-discovery.md 
   |   2 +-
 src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java  
   |   6 +-
 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java   
   |   4 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java   
 |  30 ++--
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
|   6 +-
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
   |   1 -
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
  |   1 -
 
src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java 
  |   8 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java 
 |   8 +-
 
src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java 
  |   7 +-
 src/main/java/org/apache/aurora/scheduler/{app => 
discovery}/ServiceGroupMonitor.java 
|   4 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java  
 |  10 +-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java   
   |   9 +-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java
   |  51 +++
 .../src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
   |   9 +-
 .../src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
 |  22 +--
 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java  
   |   2 +-
 src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
   |   4 +-
 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java  
   |   4 +-
 src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java  

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151670
---



Master (fdb536a) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 4:01 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 6, 2016, 4:01 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
>  

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151668
---


Ship it!




Ship It!

- Stephan Erb


On Okt. 6, 2016, 6:01 nachm., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Okt. 6, 2016, 6:01 nachm.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java   
>

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/
---

(Updated Oct. 6, 2016, 10:01 a.m.)


Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.


Changes
---

Fixup missing logback dep and kill obsolete Twitter verbiage.

 build.gradle| 4 
+++-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)


Bugs: AURORA-1669
https://issues.apache.org/jira/browse/AURORA-1669


Repository: aurora


Description
---

Remove unused code and restrict visibility where possible. Also fix up
various warnings.

 build.gradle   
   |  13 +-
 commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java  
   | 372 
--
 commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java   
   | 167 
--
 
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
 | 140 ---
 
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
 | 210 

 
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
  | 139 
---
 config/findbugs/excludeFilter.xml  
   |   8 ++
 docs/features/service-discovery.md 
   |   2 +-
 src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java  
   |   6 +-
 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java   
   |   4 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java   
 |  30 ++--
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
|   6 +-
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
   |   1 -
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
  |   1 -
 
src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java 
  |   8 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java 
 |   8 +-
 
src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java 
  |   7 +-
 src/main/java/org/apache/aurora/scheduler/{app => 
discovery}/ServiceGroupMonitor.java 
|   4 +-
 {commons/src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java  
 |  10 +-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java   
   |   9 +-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java
   |  51 +++
 .../src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
   |   9 +-
 .../src/main/java/org/apache/aurora/common/zookeeper => 
src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
 |  22 +--
 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java  
   |   2 +-
 src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
   |   4 +-
 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java  
   |   4 +-
 

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

[John Sirois]

> On Oct. 5, 2016, 10:52 p.m., Aurora ReviewBot wrote:
> > Master (e91130e) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > 
> > org.apache.aurora.common.stats.RateTest > testZeroDelta FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testInputsRegistered FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:69
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testVariableRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testRateOfRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:166
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testFixedRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testNegativeRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > 141 tests completed, 77 failed
> > :commons:test FAILED
> > 
> > FAILURE: Build failed with an exception.
> > 
> > * What went wrong:
> > Execution failed for task ':commons:test'.
> > > There were failing tests. See the report at: 
> > > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/reports/tests/index.html
> > 
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or 
> > --debug option to get more log output.
> > 
> > BUILD FAILED
> > 
> > Total time: 9 mins 5.824 secs
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"
> 
> John Sirois wrote:
> Aha - this failure only happens under gradle 3.x... digging, but likely a 
> dependency scope issue.

Not sure exactly how my change triggered this, but it was in fact an old 
missing dep in :commons combined with new stricter gradle isolation.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151627
---


On Oct. 5, 2016, 9:29 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 5, 2016, 9:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> 

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

[John Sirois]

> On Oct. 5, 2016, 10:07 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java, 
> > line 29
> > 
> >
> > Maybe we can remove the 'Twitter' reference here?

Removed.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151626
---


On Oct. 5, 2016, 9:29 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 5, 2016, 9:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>|   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>   |   1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>|   8 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java   
>|   8 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java
>|   7 +-
>  src/main/java/org/apache/aurora/scheduler/{app => 
> discovery}/ServiceGroupMonitor.java   
>   |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java
>|  10 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
>  |   9 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java  
>  |  51 +++
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java
>|   9 +-
>  .../src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java
>  |  22 +--
>  

Re: Review Request 52591: Remove untested classes that no longer exist.

[John Sirois]

> On Oct. 5, 2016, 9:51 p.m., Zameer Manji wrote:
> > How did you determine this?

Like so:
```
$ sed -r -e 's|\$.*||' -e 's|$|.java|' config/legacy_untested_classes.txt | 
sort -u | while read file; do test -f src/main/java/$file || echo "DNE: $file"; 
done
DNE: org/apache/aurora/auth/CapabilityValidator.java
DNE: org/apache/aurora/auth/UnsecureAuthModule.java
DNE: org/apache/aurora/scheduler/async/OfferQueue.java
```


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52591/#review151625
---


On Oct. 6, 2016, 9:30 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52591/
> ---
> 
> (Updated Oct. 6, 2016, 9:30 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> config/legacy_untested_classes.txt | 6 --
>  1 file changed, 6 deletions(-)
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt ee4d3d7e537356ae99ba3a90a3631749067662f3 
> 
> Diff: https://reviews.apache.org/r/52591/diff/
> 
> 
> Testing
> ---
> 
> Locally green: `./gradlew -Pq build`
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

[John Sirois]

> On Oct. 5, 2016, 10:52 p.m., Aurora ReviewBot wrote:
> > Master (e91130e) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > 
> > org.apache.aurora.common.stats.RateTest > testZeroDelta FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testInputsRegistered FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:69
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testVariableRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testRateOfRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:166
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testFixedRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > org.apache.aurora.common.stats.RateTest > testNegativeRate FAILED
> > java.lang.NoClassDefFoundError at RateTest.java:229
> > java.lang.NoClassDefFoundError at RateTest.java:58
> > 
> > 141 tests completed, 77 failed
> > :commons:test FAILED
> > 
> > FAILURE: Build failed with an exception.
> > 
> > * What went wrong:
> > Execution failed for task ':commons:test'.
> > > There were failing tests. See the report at: 
> > > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/reports/tests/index.html
> > 
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or 
> > --debug option to get more log output.
> > 
> > BUILD FAILED
> > 
> > Total time: 9 mins 5.824 secs
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

Aha - this failure only happens under gradle 3.x... digging, but likely a 
dependency scope issue.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151627
---


On Oct. 5, 2016, 9:29 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52594/
> ---
> 
> (Updated Oct. 5, 2016, 9:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove unused code and restrict visibility where possible. Also fix up
> various warnings.
> 
>  build.gradle 
>  |  13 +-
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
> | 372 
> --
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
>  | 167 
> --
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
>  | 140 ---
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
>  | 210 
> 
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
>   | 139 
> ---
>  config/findbugs/excludeFilter.xml
>  |   8 ++
>  docs/features/service-discovery.md   
>  |   2 +-
>  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
>  |   6 +-
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
>  |   4 +-
>  {commons/src/main/java/org/apache/aurora/common/zookeeper => 
> src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java 
>|  30 ++--
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> |   6 +-
>  
> 

Re: Review Request 51893: Allow cookie based authentication

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/#review151640
---



Master (5fc633c) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 11:14 a.m., Giulio Eulisse wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51893/
> ---
> 
> (Updated Oct. 6, 2016, 11:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow cookie based authentication
> 
> This allows aurora client to connect to servers which are behind a frontend 
> which expects some sort of cookie to autheticate and authorize users. The 
> cookie should be stored in MozillanCookieJar format in a file named 
> `~/.aurora-token`.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> fbebbab8c827b5695042d18770d850e31fc38122 
>   src/main/python/apache/aurora/client/cli/client.py 
> fa0c2648c5ff7ea6c9d949cf8cd9b9795d452e98 
>   src/main/python/apache/aurora/common/cookie_auth_module.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51893/diff/
> 
> 
> Testing
> ---
> 
> $ cat ~/aurora/clusters.json
> [
> {
>   "name": "build",
>   "scheduler_uri": "https://aliaurora.cern.ch;,
>   "auth_mechanism": "COOKIE"
> }
> ]
> $ dist/aurora.pex quota get build/root
> 
> 
> Thanks,
> 
> Giulio Eulisse
> 
>

Re: Review Request 51893: Allow cookie based authentication

[Giulio Eulisse]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/
---

(Updated Oct. 6, 2016, 11:14 a.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Repository: aurora


Description
---

Allow cookie based authentication

This allows aurora client to connect to servers which are behind a frontend 
which expects some sort of cookie to autheticate and authorize users. The 
cookie should be stored in MozillanCookieJar format in a file named 
`~/.aurora-token`.


Diffs (updated)
-

  RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
  docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec 
  src/main/python/apache/aurora/admin/aurora_admin.py 
fbebbab8c827b5695042d18770d850e31fc38122 
  src/main/python/apache/aurora/client/cli/client.py 
fa0c2648c5ff7ea6c9d949cf8cd9b9795d452e98 
  src/main/python/apache/aurora/common/cookie_auth_module.py PRE-CREATION 

Diff: https://reviews.apache.org/r/51893/diff/


Testing
---

$ cat ~/aurora/clusters.json
[
{
  "name": "build",
  "scheduler_uri": "https://aliaurora.cern.ch;,
  "auth_mechanism": "COOKIE"
}
]
$ dist/aurora.pex quota get build/root


Thanks,

Giulio Eulisse

Re: Review Request 51893: Allow cookie based authentication

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/#review151639
---



This patch does not apply cleanly against master (5fc633c), do you need to 
rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 9:16 a.m., Giulio Eulisse wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51893/
> ---
> 
> (Updated Oct. 6, 2016, 9:16 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow cookie based authentication
> 
> This allows aurora client to connect to servers which are behind a frontend 
> which expects some sort of cookie to autheticate and authorize users. The 
> cookie should be stored in MozillanCookieJar format in a file named 
> `~/.aurora-token`.
> 
> 
> Diffs
> -
> 
>   .auroraversion e466c4e4b04ba39269cd00b8eb32872df5e82063 
>   3rdparty/python/requirements.txt 5cc3cb1edf7dcf30e44ff094e90286df48fa445e 
>   CHANGELOG b1dce5882bbda8d3217a8dcc1509c2a25ae55a21 
>   CONTRIBUTING.md 13ebbe4be281f869d276ebe97bfae75123899cfb 
>   KEYS d9e5ec932aea33dc5c2cb69e64bbefd1a155cced 
>   LICENSE 775eaed2d116089179ef78c74631cb1ee7ac3d29 
>   NOTICE 94ea47dd39856da3b337f40bdca736293794c6f2 
>   README.md 77fb77063eb96da9574794f989641c7746d2c35c 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   Vagrantfile 88613bfdcabd6ec305efdbc5d21511ad28710aef 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   build-support/packer/build.sh 7aed38f6345c18ff6d83bb3028acb88bf2935dc7 
>   build-support/python/make-mesos-native-egg 
> 93874964b6e25ab419ca04c0fae674c3c2ce5e15 
>   build.gradle d5a3a7a3bdb8349de6fc01d4a6271b32d942e531 
>   buildSrc/gradle.properties 8cfb32885c90aa006cad1aa00a1adac36356eac3 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
>  e906f9458970bc01cc840ebbefeac384fe4d4cf3 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> 538e8077ba762ec9a8f14f759740bb82144a5dc4 
>   commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
> 6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> 8e73dd9ebc43e06f696bbdac4d658e4b225e7df7 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
> 75c1b1493eb178ea035a0e60f20df694626c7f50 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
> 98b5ee4690482683526f2e8ce4c965ed052b0232 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
> 2720dd13a3cc5e39f7242664fbe98f00fb75eb08 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java 
> 9d316088ffd51b2dce816e6cc18d8e2a4a23cfd5 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 
> aeea02d81faa3c8841edb9002498515dd0b52242 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
> ace4980d3e15dc830fea48b83f0688347c71d900 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 
> 01a54a5718388df7f02992388653d7b049422787 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java
>  d9978a926e05e4303a168c7c51ee226a7dc94336 
>   
> commons/src/test/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParamsTest.java
>  f1479bfea90bd78cd07d451fc62ca2b4d341d654 
>   commons/src/test/java/org/apache/aurora/common/util/BackoffHelperTest.java 
> bc30990d57f444f7d64805ed85c363f1302736d0 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java
>  9c0cebe888d966fd64d17778c354136df0e13c7e 
>   commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 
> 97a42d1bd6c60598d7936a2c065e163c1505ef3d 
>   commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java 
> 2166123e9acd701e55e10b450a9eb89054c7afdd 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java
>  f0c0cb4491c7b5c34103864ee244a27db3972a94 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 
> 0e6719154ee5195111db51d323fa35c3bc56ec2b 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
>  5f6cdd83ca6c6338f8c7a0a3c93b960c036cb05e 
>   docs/README.md 7cea18f6a62a8dc51b593243709d841b32d3238b 
>   docs/development/committers-guide.md 
> 14f3b52ed39f0e066986237d262ce4488491b3dc 
>   docs/development/design-documents.md 
> 

Re: Review Request 51893: Allow cookie based authentication

[Giulio Eulisse]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/
---

(Updated Oct. 6, 2016, 9:16 a.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Repository: aurora


Description
---

Allow cookie based authentication

This allows aurora client to connect to servers which are behind a frontend 
which expects some sort of cookie to autheticate and authorize users. The 
cookie should be stored in MozillanCookieJar format in a file named 
`~/.aurora-token`.


Diffs (updated)
-

  .auroraversion e466c4e4b04ba39269cd00b8eb32872df5e82063 
  3rdparty/python/requirements.txt 5cc3cb1edf7dcf30e44ff094e90286df48fa445e 
  CHANGELOG b1dce5882bbda8d3217a8dcc1509c2a25ae55a21 
  CONTRIBUTING.md 13ebbe4be281f869d276ebe97bfae75123899cfb 
  KEYS d9e5ec932aea33dc5c2cb69e64bbefd1a155cced 
  LICENSE 775eaed2d116089179ef78c74631cb1ee7ac3d29 
  NOTICE 94ea47dd39856da3b337f40bdca736293794c6f2 
  README.md 77fb77063eb96da9574794f989641c7746d2c35c 
  RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
  Vagrantfile 88613bfdcabd6ec305efdbc5d21511ad28710aef 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
c5765b70501c101f0535b4eed94e9948c36808f9 
  build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
  build-support/packer/build.sh 7aed38f6345c18ff6d83bb3028acb88bf2935dc7 
  build-support/python/make-mesos-native-egg 
93874964b6e25ab419ca04c0fae674c3c2ce5e15 
  build.gradle d5a3a7a3bdb8349de6fc01d4a6271b32d942e531 
  buildSrc/gradle.properties 8cfb32885c90aa006cad1aa00a1adac36356eac3 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
 e906f9458970bc01cc840ebbefeac384fe4d4cf3 
  commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
538e8077ba762ec9a8f14f759740bb82144a5dc4 
  commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
  commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
8e73dd9ebc43e06f696bbdac4d658e4b225e7df7 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
75c1b1493eb178ea035a0e60f20df694626c7f50 
  commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
98b5ee4690482683526f2e8ce4c965ed052b0232 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
2720dd13a3cc5e39f7242664fbe98f00fb75eb08 
  commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java 
9d316088ffd51b2dce816e6cc18d8e2a4a23cfd5 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 
aeea02d81faa3c8841edb9002498515dd0b52242 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
ace4980d3e15dc830fea48b83f0688347c71d900 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 
01a54a5718388df7f02992388653d7b049422787 
  
commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java
 d9978a926e05e4303a168c7c51ee226a7dc94336 
  
commons/src/test/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParamsTest.java
 f1479bfea90bd78cd07d451fc62ca2b4d341d654 
  commons/src/test/java/org/apache/aurora/common/util/BackoffHelperTest.java 
bc30990d57f444f7d64805ed85c363f1302736d0 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java 
9c0cebe888d966fd64d17778c354136df0e13c7e 
  commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 
97a42d1bd6c60598d7936a2c065e163c1505ef3d 
  commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java 
2166123e9acd701e55e10b450a9eb89054c7afdd 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 
f0c0cb4491c7b5c34103864ee244a27db3972a94 
  commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 
0e6719154ee5195111db51d323fa35c3bc56ec2b 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
 5f6cdd83ca6c6338f8c7a0a3c93b960c036cb05e 
  docs/README.md 7cea18f6a62a8dc51b593243709d841b32d3238b 
  docs/development/committers-guide.md 14f3b52ed39f0e066986237d262ce4488491b3dc 
  docs/development/design-documents.md 50aeafbc5f96a8c443c90269730cd8b4c4bfd6d7 
  docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
  docs/features/custom-executors.md 7438938d29901e0d69389288ac592f06c3c698c0 
  docs/features/job-updates.md 792f2ae5fd14b1ea9af8be000629ce5a7fc2fe8f 
  docs/features/multitenancy.md cb45beb213eb74296194f8cad9e1aefbde07af02 
  docs/features/resource-isolation.md 59da8231a3e25e64b4be8c30a44c1043188aff2c 
  docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
  docs/operations/configuration.md 15ec042ff4035abc07e1a73fe52f418695ff56f0 
  docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec 
  docs/reference/configuration.md 

Re: Review Request 51893: Allow cookie based authentication

[Giulio Eulisse]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/
---

(Updated Oct. 6, 2016, 9:10 a.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Repository: aurora


Description
---

Allow cookie based authentication

This allows aurora client to connect to servers which are behind a frontend 
which expects some sort of cookie to autheticate and authorize users. The 
cookie should be stored in MozillanCookieJar format in a file named 
`~/.aurora-token`.


Diffs
-

  .auroraversion e466c4e4b04ba39269cd00b8eb32872df5e82063 
  3rdparty/python/requirements.txt 5cc3cb1edf7dcf30e44ff094e90286df48fa445e 
  CHANGELOG b1dce5882bbda8d3217a8dcc1509c2a25ae55a21 
  CONTRIBUTING.md 13ebbe4be281f869d276ebe97bfae75123899cfb 
  KEYS d9e5ec932aea33dc5c2cb69e64bbefd1a155cced 
  LICENSE 775eaed2d116089179ef78c74631cb1ee7ac3d29 
  NOTICE 94ea47dd39856da3b337f40bdca736293794c6f2 
  README.md 77fb77063eb96da9574794f989641c7746d2c35c 
  RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
  Vagrantfile 88613bfdcabd6ec305efdbc5d21511ad28710aef 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
c5765b70501c101f0535b4eed94e9948c36808f9 
  build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
  build-support/packer/build.sh 7aed38f6345c18ff6d83bb3028acb88bf2935dc7 
  build-support/python/make-mesos-native-egg 
93874964b6e25ab419ca04c0fae674c3c2ce5e15 
  build.gradle d5a3a7a3bdb8349de6fc01d4a6271b32d942e531 
  buildSrc/gradle.properties 8cfb32885c90aa006cad1aa00a1adac36356eac3 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
 e906f9458970bc01cc840ebbefeac384fe4d4cf3 
  commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
538e8077ba762ec9a8f14f759740bb82144a5dc4 
  commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
  commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
8e73dd9ebc43e06f696bbdac4d658e4b225e7df7 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
75c1b1493eb178ea035a0e60f20df694626c7f50 
  commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
98b5ee4690482683526f2e8ce4c965ed052b0232 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
2720dd13a3cc5e39f7242664fbe98f00fb75eb08 
  commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java 
9d316088ffd51b2dce816e6cc18d8e2a4a23cfd5 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 
aeea02d81faa3c8841edb9002498515dd0b52242 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
ace4980d3e15dc830fea48b83f0688347c71d900 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 
01a54a5718388df7f02992388653d7b049422787 
  
commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java
 d9978a926e05e4303a168c7c51ee226a7dc94336 
  
commons/src/test/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParamsTest.java
 f1479bfea90bd78cd07d451fc62ca2b4d341d654 
  commons/src/test/java/org/apache/aurora/common/util/BackoffHelperTest.java 
bc30990d57f444f7d64805ed85c363f1302736d0 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java 
9c0cebe888d966fd64d17778c354136df0e13c7e 
  commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 
97a42d1bd6c60598d7936a2c065e163c1505ef3d 
  commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java 
2166123e9acd701e55e10b450a9eb89054c7afdd 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 
f0c0cb4491c7b5c34103864ee244a27db3972a94 
  commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 
0e6719154ee5195111db51d323fa35c3bc56ec2b 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
 5f6cdd83ca6c6338f8c7a0a3c93b960c036cb05e 
  docs/README.md 7cea18f6a62a8dc51b593243709d841b32d3238b 
  docs/development/committers-guide.md 14f3b52ed39f0e066986237d262ce4488491b3dc 
  docs/development/design-documents.md 50aeafbc5f96a8c443c90269730cd8b4c4bfd6d7 
  docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
  docs/features/custom-executors.md 7438938d29901e0d69389288ac592f06c3c698c0 
  docs/features/job-updates.md 792f2ae5fd14b1ea9af8be000629ce5a7fc2fe8f 
  docs/features/multitenancy.md cb45beb213eb74296194f8cad9e1aefbde07af02 
  docs/features/resource-isolation.md 59da8231a3e25e64b4be8c30a44c1043188aff2c 
  docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
  docs/operations/configuration.md 15ec042ff4035abc07e1a73fe52f418695ff56f0 
  docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec 
  docs/reference/configuration.md 

Re: Review Request 51893: Allow cookie based authentication

[Giulio Eulisse]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/
---

(Updated Oct. 6, 2016, 9:10 a.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Repository: aurora


Description
---

Allow cookie based authentication

This allows aurora client to connect to servers which are behind a frontend 
which expects some sort of cookie to autheticate and authorize users. The 
cookie should be stored in MozillanCookieJar format in a file named 
`~/.aurora-token`.


Diffs (updated)
-

  .auroraversion e466c4e4b04ba39269cd00b8eb32872df5e82063 
  3rdparty/python/requirements.txt 5cc3cb1edf7dcf30e44ff094e90286df48fa445e 
  CHANGELOG b1dce5882bbda8d3217a8dcc1509c2a25ae55a21 
  CONTRIBUTING.md 13ebbe4be281f869d276ebe97bfae75123899cfb 
  KEYS d9e5ec932aea33dc5c2cb69e64bbefd1a155cced 
  LICENSE 775eaed2d116089179ef78c74631cb1ee7ac3d29 
  NOTICE 94ea47dd39856da3b337f40bdca736293794c6f2 
  README.md 77fb77063eb96da9574794f989641c7746d2c35c 
  RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
  Vagrantfile 88613bfdcabd6ec305efdbc5d21511ad28710aef 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
c5765b70501c101f0535b4eed94e9948c36808f9 
  build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
  build-support/packer/build.sh 7aed38f6345c18ff6d83bb3028acb88bf2935dc7 
  build-support/python/make-mesos-native-egg 
93874964b6e25ab419ca04c0fae674c3c2ce5e15 
  build.gradle d5a3a7a3bdb8349de6fc01d4a6271b32d942e531 
  buildSrc/gradle.properties 8cfb32885c90aa006cad1aa00a1adac36356eac3 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
 e906f9458970bc01cc840ebbefeac384fe4d4cf3 
  commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
538e8077ba762ec9a8f14f759740bb82144a5dc4 
  commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
  commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
8e73dd9ebc43e06f696bbdac4d658e4b225e7df7 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
75c1b1493eb178ea035a0e60f20df694626c7f50 
  commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
98b5ee4690482683526f2e8ce4c965ed052b0232 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
2720dd13a3cc5e39f7242664fbe98f00fb75eb08 
  commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java 
9d316088ffd51b2dce816e6cc18d8e2a4a23cfd5 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 
aeea02d81faa3c8841edb9002498515dd0b52242 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
ace4980d3e15dc830fea48b83f0688347c71d900 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 
01a54a5718388df7f02992388653d7b049422787 
  
commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java
 d9978a926e05e4303a168c7c51ee226a7dc94336 
  
commons/src/test/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParamsTest.java
 f1479bfea90bd78cd07d451fc62ca2b4d341d654 
  commons/src/test/java/org/apache/aurora/common/util/BackoffHelperTest.java 
bc30990d57f444f7d64805ed85c363f1302736d0 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java 
9c0cebe888d966fd64d17778c354136df0e13c7e 
  commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 
97a42d1bd6c60598d7936a2c065e163c1505ef3d 
  commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java 
2166123e9acd701e55e10b450a9eb89054c7afdd 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 
f0c0cb4491c7b5c34103864ee244a27db3972a94 
  commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 
0e6719154ee5195111db51d323fa35c3bc56ec2b 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
 5f6cdd83ca6c6338f8c7a0a3c93b960c036cb05e 
  docs/README.md 7cea18f6a62a8dc51b593243709d841b32d3238b 
  docs/development/committers-guide.md 14f3b52ed39f0e066986237d262ce4488491b3dc 
  docs/development/design-documents.md 50aeafbc5f96a8c443c90269730cd8b4c4bfd6d7 
  docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
  docs/features/custom-executors.md 7438938d29901e0d69389288ac592f06c3c698c0 
  docs/features/job-updates.md 792f2ae5fd14b1ea9af8be000629ce5a7fc2fe8f 
  docs/features/multitenancy.md cb45beb213eb74296194f8cad9e1aefbde07af02 
  docs/features/resource-isolation.md 59da8231a3e25e64b4be8c30a44c1043188aff2c 
  docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
  docs/operations/configuration.md 15ec042ff4035abc07e1a73fe52f418695ff56f0 
  docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec 
  docs/reference/configuration.md 

Re: Review Request 51893: Allow cookie based authentication

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/#review151636
---



This patch does not apply cleanly against master (5fc633c), do you need to 
rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 9:06 a.m., Giulio Eulisse wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51893/
> ---
> 
> (Updated Oct. 6, 2016, 9:06 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow cookie based authentication
> 
> This allows aurora client to connect to servers which are behind a frontend 
> which expects some sort of cookie to autheticate and authorize users. The 
> cookie should be stored in MozillanCookieJar format in a file named 
> `~/.aurora-token`.
> 
> 
> Diffs
> -
> 
>   .auroraversion e466c4e4b04ba39269cd00b8eb32872df5e82063 
>   3rdparty/python/requirements.txt 5cc3cb1edf7dcf30e44ff094e90286df48fa445e 
>   CHANGELOG b1dce5882bbda8d3217a8dcc1509c2a25ae55a21 
>   CONTRIBUTING.md 13ebbe4be281f869d276ebe97bfae75123899cfb 
>   KEYS d9e5ec932aea33dc5c2cb69e64bbefd1a155cced 
>   LICENSE 775eaed2d116089179ef78c74631cb1ee7ac3d29 
>   NOTICE 94ea47dd39856da3b337f40bdca736293794c6f2 
>   README.md 77fb77063eb96da9574794f989641c7746d2c35c 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   Vagrantfile 88613bfdcabd6ec305efdbc5d21511ad28710aef 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   build-support/packer/build.sh 7aed38f6345c18ff6d83bb3028acb88bf2935dc7 
>   build-support/python/make-mesos-native-egg 
> 93874964b6e25ab419ca04c0fae674c3c2ce5e15 
>   build.gradle d5a3a7a3bdb8349de6fc01d4a6271b32d942e531 
>   buildSrc/gradle.properties 8cfb32885c90aa006cad1aa00a1adac36356eac3 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
>  e906f9458970bc01cc840ebbefeac384fe4d4cf3 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> 538e8077ba762ec9a8f14f759740bb82144a5dc4 
>   commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
> 6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
>   commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
> 8e73dd9ebc43e06f696bbdac4d658e4b225e7df7 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
> 75c1b1493eb178ea035a0e60f20df694626c7f50 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
> 98b5ee4690482683526f2e8ce4c965ed052b0232 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
> 2720dd13a3cc5e39f7242664fbe98f00fb75eb08 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java 
> 9d316088ffd51b2dce816e6cc18d8e2a4a23cfd5 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 
> aeea02d81faa3c8841edb9002498515dd0b52242 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
> ace4980d3e15dc830fea48b83f0688347c71d900 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 
> 01a54a5718388df7f02992388653d7b049422787 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java
>  d9978a926e05e4303a168c7c51ee226a7dc94336 
>   
> commons/src/test/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParamsTest.java
>  f1479bfea90bd78cd07d451fc62ca2b4d341d654 
>   commons/src/test/java/org/apache/aurora/common/util/BackoffHelperTest.java 
> bc30990d57f444f7d64805ed85c363f1302736d0 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java
>  9c0cebe888d966fd64d17778c354136df0e13c7e 
>   commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 
> 97a42d1bd6c60598d7936a2c065e163c1505ef3d 
>   commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java 
> 2166123e9acd701e55e10b450a9eb89054c7afdd 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java
>  f0c0cb4491c7b5c34103864ee244a27db3972a94 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 
> 0e6719154ee5195111db51d323fa35c3bc56ec2b 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
>  5f6cdd83ca6c6338f8c7a0a3c93b960c036cb05e 
>   docs/README.md 7cea18f6a62a8dc51b593243709d841b32d3238b 
>   docs/development/committers-guide.md 
> 14f3b52ed39f0e066986237d262ce4488491b3dc 
>   docs/development/design-documents.md 
> 

Re: Review Request 51893: Allow cookie based authentication

[Giulio Eulisse]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/
---

(Updated Oct. 6, 2016, 9:06 a.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Repository: aurora


Description
---

Allow cookie based authentication

This allows aurora client to connect to servers which are behind a frontend 
which expects some sort of cookie to autheticate and authorize users. The 
cookie should be stored in MozillanCookieJar format in a file named 
`~/.aurora-token`.


Diffs
-

  .auroraversion e466c4e4b04ba39269cd00b8eb32872df5e82063 
  3rdparty/python/requirements.txt 5cc3cb1edf7dcf30e44ff094e90286df48fa445e 
  CHANGELOG b1dce5882bbda8d3217a8dcc1509c2a25ae55a21 
  CONTRIBUTING.md 13ebbe4be281f869d276ebe97bfae75123899cfb 
  KEYS d9e5ec932aea33dc5c2cb69e64bbefd1a155cced 
  LICENSE 775eaed2d116089179ef78c74631cb1ee7ac3d29 
  NOTICE 94ea47dd39856da3b337f40bdca736293794c6f2 
  README.md 77fb77063eb96da9574794f989641c7746d2c35c 
  RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
  Vagrantfile 88613bfdcabd6ec305efdbc5d21511ad28710aef 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
c5765b70501c101f0535b4eed94e9948c36808f9 
  build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
  build-support/packer/build.sh 7aed38f6345c18ff6d83bb3028acb88bf2935dc7 
  build-support/python/make-mesos-native-egg 
93874964b6e25ab419ca04c0fae674c3c2ce5e15 
  build.gradle d5a3a7a3bdb8349de6fc01d4a6271b32d942e531 
  buildSrc/gradle.properties 8cfb32885c90aa006cad1aa00a1adac36356eac3 
  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
 e906f9458970bc01cc840ebbefeac384fe4d4cf3 
  commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
538e8077ba762ec9a8f14f759740bb82144a5dc4 
  commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
  commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java 
8e73dd9ebc43e06f696bbdac4d658e4b225e7df7 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
75c1b1493eb178ea035a0e60f20df694626c7f50 
  commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
98b5ee4690482683526f2e8ce4c965ed052b0232 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
2720dd13a3cc5e39f7242664fbe98f00fb75eb08 
  commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java 
9d316088ffd51b2dce816e6cc18d8e2a4a23cfd5 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 
aeea02d81faa3c8841edb9002498515dd0b52242 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
ace4980d3e15dc830fea48b83f0688347c71d900 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 
01a54a5718388df7f02992388653d7b049422787 
  
commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java
 d9978a926e05e4303a168c7c51ee226a7dc94336 
  
commons/src/test/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParamsTest.java
 f1479bfea90bd78cd07d451fc62ca2b4d341d654 
  commons/src/test/java/org/apache/aurora/common/util/BackoffHelperTest.java 
bc30990d57f444f7d64805ed85c363f1302736d0 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java 
9c0cebe888d966fd64d17778c354136df0e13c7e 
  commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 
97a42d1bd6c60598d7936a2c065e163c1505ef3d 
  commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java 
2166123e9acd701e55e10b450a9eb89054c7afdd 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 
f0c0cb4491c7b5c34103864ee244a27db3972a94 
  commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 
0e6719154ee5195111db51d323fa35c3bc56ec2b 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
 5f6cdd83ca6c6338f8c7a0a3c93b960c036cb05e 
  docs/README.md 7cea18f6a62a8dc51b593243709d841b32d3238b 
  docs/development/committers-guide.md 14f3b52ed39f0e066986237d262ce4488491b3dc 
  docs/development/design-documents.md 50aeafbc5f96a8c443c90269730cd8b4c4bfd6d7 
  docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
  docs/features/custom-executors.md 7438938d29901e0d69389288ac592f06c3c698c0 
  docs/features/job-updates.md 792f2ae5fd14b1ea9af8be000629ce5a7fc2fe8f 
  docs/features/multitenancy.md cb45beb213eb74296194f8cad9e1aefbde07af02 
  docs/features/resource-isolation.md 59da8231a3e25e64b4be8c30a44c1043188aff2c 
  docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
  docs/operations/configuration.md 15ec042ff4035abc07e1a73fe52f418695ff56f0 
  docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec 
  docs/reference/configuration.md