Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152589 --- Ship it! Master (8256000) is green with this patch.

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152588 --- Ship it! LGTM, but I'm +1 on Zameer's suggestion to check that

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152587 --- Ship it! Nevermind, didn't realize there are multiple

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152583 --- src/test/python/apache/aurora/executor/test_thermos_executor.py

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread Justin Pinkul
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/ --- (Updated Oct. 13, 2016, 10:12 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152582 --- Master (8256000) is red with this patch.

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread Justin Pinkul
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/ --- (Updated Oct. 13, 2016, 9:14 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152575 --- This patch does not apply cleanly against master (8256000), do

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread Justin Pinkul
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/ --- (Updated Oct. 13, 2016, 8:35 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-13 Thread Zameer Manji
> On Oct. 13, 2016, 1:24 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java, line > > 215 > > > > > > Is there a reason we can't apply the `get` call here rather

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/#review152571 ---

Re: Review Request 52834: Introduce a --ip option to Thermos observer

2016-10-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52834/#review152566 --- Ship it! Ship It! - Joshua Cohen On Oct. 13, 2016, 3:32

Re: Review Request 52834: Introduce a --ip option to Thermos observer

2016-10-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52834/#review152561 --- Ship it! Ship It! - Zameer Manji On Oct. 13, 2016, 8:32

Re: Review Request 51893: Allow cookie based authentication

2016-10-13 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review152557 --- docs/operations/security.md (line 203)

Re: Review Request 51893: Allow cookie based authentication

2016-10-13 Thread David McLaughlin
> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 52834: Introduce a --ip option to Thermos observer

2016-10-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52834/#review152519 --- Ship it! Master (8256000) is green with this patch.

Review Request 52834: Introduce a --ip option to Thermos observer

2016-10-13 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52834/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description

Re: Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/#review152477 --- Master (8256000) is green with this patch.

Review Request 52821: Fix the -enable_revocable_ram flag

2016-10-13 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1794

Re: Review Request 51893: Allow cookie based authentication

2016-10-13 Thread Giulio Eulisse
> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

2016-10-13 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52776/ --- (Updated Oct. 13, 2016, 9:50 a.m.) Review request for Aurora and Zameer Manji.