Re: Review Request 58636: adding metrics for removals from bicache

2017-04-21 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58636/#review172730 --- src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java

Review Request 58636: adding metrics for removals from bicache

2017-04-21 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58636/ --- Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, and Santhosh

Re: Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Santhosh Kumar Shanmugham
> On April 21, 2017, 9:57 a.m., Aurora ReviewBot wrote: > > Master (b847db8) is green with this patch. > > ./build-support/jenkins/build.sh > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" We have decided that this patch is not necessary and

Re: Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/#review172676 --- Ship it! Master (b847db8) is green with this patch.

Re: Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Reza Motamedi via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/#review172674 --- Ship it! Ship It! - Reza Motamedi On April 21, 2017, 4:32

Re: Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/#review172673 --- Ship it! Ship It! - Stephan Erb On April 21, 2017, 6:32

Re: Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/ --- (Updated April 21, 2017, 9:32 a.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 58609: Switch Thermos runner to simple disk log layout

2017-04-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58609/#review172671 --- @ReviewBot retry - Stephan Erb On April 21, 2017, 11:35 a.m.,

Re: Review Request 58612: Improve cleanup hints in release and release-candidate scripts

2017-04-21 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58612/#review172665 --- Ship it! Ship It! - John Sirois On April 21, 2017, 5:24

Re: Review Request 58609: Switch Thermos runner to simple disk log layout

2017-04-21 Thread Joshua Cohen
> On April 21, 2017, 2:37 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/thermos_task_runner.py > > Line 257 (original), 257 (patched) > > > > > > I think a better place to do this might be in

Re: Review Request 58609: Switch Thermos runner to simple disk log layout

2017-04-21 Thread Stephan Erb
> On April 21, 2017, 4:37 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/thermos_task_runner.py > > Line 257 (original), 257 (patched) > > > > > > I think a better place to do this might be in

Re: Review Request 58609: Switch Thermos runner to simple disk log layout

2017-04-21 Thread Stephan Erb
> On April 21, 2017, 4:37 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/thermos_task_runner.py > > Line 257 (original), 257 (patched) > > > > > > I think a better place to do this might be in

Re: Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/#review172659 --- Ship it! Master (b847db8) is green with this patch.

Re: Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/#review172658 --- @ReviewBot retry - Stephan Erb On April 21, 2017, 9:58 a.m.,

Re: Review Request 58609: Switch Thermos runner to simple disk log layout

2017-04-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58609/#review172657 --- src/main/python/apache/aurora/executor/thermos_task_runner.py

Re: Review Request 58612: Improve cleanup hints in release and release-candidate scripts

2017-04-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58612/#review172656 --- Ship it! Ship It! - Joshua Cohen On April 21, 2017, 11:24

Re: Review Request 58611: Bump initial_task_kill_retry_interval to 15s.

2017-04-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58611/#review172647 --- Master (b847db8) is red with this patch.

Re: Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Stephan Erb
> On April 21, 2017, 2:35 p.m., Aurora ReviewBot wrote: > > Master (b847db8) is red with this patch. > > ./build-support/jenkins/build.sh > > > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$8 > > Test coverage missing for > >

Re: Review Request 58609: Switch Thermos runner to simple disk log layout

2017-04-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58609/#review172645 --- Master (b847db8) is red with this patch.

Re: Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/#review172642 --- Master (b847db8) is red with this patch.

Re: Review Request 58611: Bump initial_task_kill_retry_interval to 15s.

2017-04-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58611/#review172641 --- @ReviewBot retry - Stephan Erb On April 21, 2017, 12:36 p.m.,

Re: Review Request 58611: Bump initial_task_kill_retry_interval to 15s.

2017-04-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58611/#review172638 --- Master (b847db8) is red with this patch.

Re: Review Request 58612: Improve cleanup hints in release and release-candidate scripts

2017-04-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58612/#review172636 --- Master (b847db8) is red with this patch.

Review Request 58611: Bump initial_task_kill_retry_interval to 15s.

2017-04-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58611/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description

Re: Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/#review172620 --- Please mention this in the changelog. - Stephan Erb On April

Review Request 58609: Switch Thermos runner to simple disk log layout

2017-04-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58609/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Repository: aurora

Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/ --- Review request for Aurora, Stephan Erb and Zameer Manji. Repository: aurora