---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59640/#review176852
---
This has been merged to master.
- David McLaughlin
On June 1,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59699/#review176845
---
This has been merged to master.
- David McLaughlin
On June 2,
> On June 2, 2017, 5:28 p.m., Zameer Manji wrote:
> > I don't have comment access on the doc, so I will leave my questions here:
> >
> > 1. Should operators (via executor flags) be able to cap this value? That is
> > should `STOP_TIMEOUT` be an operator flag?
> > 2. Should the client cap this
> On June 2, 2017, 10:28 a.m., Zameer Manji wrote:
> > I don't have comment access on the doc, so I will leave my questions here:
> >
> > 1. Should operators (via executor flags) be able to cap this value? That is
> > should `STOP_TIMEOUT` be an operator flag?
> > 2. Should the client cap this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59699/#review176827
---
Ship it!
Ship It!
- Zameer Manji
On June 1, 2017, 5:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59698/#review176826
---
Ship it!
LGTM. (My guice knowledge is limited.)
- Santhosh
> On June 2, 2017, 5:28 p.m., Zameer Manji wrote:
> > I don't have comment access on the doc, so I will leave my questions here:
> >
> > 1. Should operators (via executor flags) be able to cap this value? That is
> > should `STOP_TIMEOUT` be an operator flag?
> > 2. Should the client cap this
> On June 2, 2017, 12:35 a.m., David McLaughlin wrote:
> > Ship It!
>
> Kai Huang wrote:
> It looks like the deleteTasks() method could be even simpler: perhaps we
> don't need to move taskStore.deleteTasks out of the deleteEvent factory
> method? The only trick here is that we generate a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59698/#review176817
---
Ping. This still needs committer Ship-Its.
- David McLaughlin
> On June 2, 2017, 5:28 p.m., Zameer Manji wrote:
> > I don't have comment access on the doc, so I will leave my questions here:
> >
> > 1. Should operators (via executor flags) be able to cap this value? That is
> > should `STOP_TIMEOUT` be an operator flag?
> > 2. Should the client cap this
> On June 2, 2017, 5:28 p.m., Zameer Manji wrote:
> > I don't have comment access on the doc, so I will leave my questions here:
> >
> > 1. Should operators (via executor flags) be able to cap this value? That is
> > should `STOP_TIMEOUT` be an operator flag?
> > 2. Should the client cap this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59733/#review176802
---
I don't have comment access on the doc, so I will leave my
> On June 2, 2017, 12:35 a.m., David McLaughlin wrote:
> > Ship It!
It looks like the deleteTasks() method could be even simpler: perhaps we don't
need to move taskStore.deleteTasks out of the deleteEvent factory method? The
only trick here is that we generate a single event for all task
13 matches
Mail list logo